All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@codeaurora.org>
To: David Brown <davidb@codeaurora.org>
Cc: Saravana Kannan <skannan@codeaurora.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] msm: clock: Remove unused code and definitions
Date: Wed, 26 Jan 2011 14:03:02 -0800	[thread overview]
Message-ID: <1296079382.29801.45.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <8ya1v3z8gu6.fsf@huya.qualcomm.com>

On Wed, 2011-01-26 at 14:01 -0800, David Brown wrote:
> On Tue, Jan 25 2011, Daniel Walker wrote:
> 
> > On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote:
> >> On 01/25/2011 01:38 PM, Daniel Walker wrote:
> >> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:
> >> >> Remove dead code and push out clock-7x30.h and clock-pcom.h to
> >> >> where they are actually used.
> >> >>
> >> >
> >> > I'd do two patches for this. The stuff your doing is too disconnected.
> >> >
> >> > Daniel
> >> >
> >> There is a whole bunch of unused code in the clock files and it's being 
> >> deleted. I don't see a point of splitting it up per file.
> >
> > It's easier to review when changes aren't merged that don't related to
> > each other.
> 
> In this particular case, the patch is a bunch of removal of dead code,
> and kind of makes sense to keep it together.  I'm fine with it as is.

He's adding stuff too .. So it's not _just_ removal which is what I was
getting at.

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: dwalker@codeaurora.org (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] msm: clock: Remove unused code and definitions
Date: Wed, 26 Jan 2011 14:03:02 -0800	[thread overview]
Message-ID: <1296079382.29801.45.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <8ya1v3z8gu6.fsf@huya.qualcomm.com>

On Wed, 2011-01-26 at 14:01 -0800, David Brown wrote:
> On Tue, Jan 25 2011, Daniel Walker wrote:
> 
> > On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote:
> >> On 01/25/2011 01:38 PM, Daniel Walker wrote:
> >> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:
> >> >> Remove dead code and push out clock-7x30.h and clock-pcom.h to
> >> >> where they are actually used.
> >> >>
> >> >
> >> > I'd do two patches for this. The stuff your doing is too disconnected.
> >> >
> >> > Daniel
> >> >
> >> There is a whole bunch of unused code in the clock files and it's being 
> >> deleted. I don't see a point of splitting it up per file.
> >
> > It's easier to review when changes aren't merged that don't related to
> > each other.
> 
> In this particular case, the patch is a bunch of removal of dead code,
> and kind of makes sense to keep it together.  I'm fine with it as is.

He's adding stuff too .. So it's not _just_ removal which is what I was
getting at.

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-01-26 22:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25  3:45 [PATCH 0/4] MSM: clock debugfs and cleanups Stephen Boyd
2011-01-25  3:45 ` Stephen Boyd
2011-01-25  3:45 ` [PATCH 1/4] msm: clock: Remove unused code and definitions Stephen Boyd
2011-01-25  3:45   ` Stephen Boyd
2011-01-25 21:38   ` Daniel Walker
2011-01-25 21:38     ` Daniel Walker
2011-01-25 21:52     ` Saravana Kannan
2011-01-25 21:52       ` Saravana Kannan
2011-01-25 22:02       ` Daniel Walker
2011-01-25 22:02         ` Daniel Walker
2011-01-26 22:01         ` David Brown
2011-01-26 22:01           ` David Brown
2011-01-26 22:03           ` Daniel Walker [this message]
2011-01-26 22:03             ` Daniel Walker
2011-01-26 22:50             ` Stephen Boyd
2011-01-26 22:50               ` Stephen Boyd
2011-01-25  3:45 ` [PATCH 2/4] msm: clock: Move debugfs code from clock.c to clock-debug.c Stephen Boyd
2011-01-25  3:45   ` Stephen Boyd
2011-01-25  3:45 ` [PATCH 3/4] msm: clock: Invert debugfs directory layout Stephen Boyd
2011-01-25  3:45   ` Stephen Boyd
2011-01-25  3:45 ` [PATCH 4/4] msm: clock: Add support for more proc_comm clocks Stephen Boyd
2011-01-25  3:45   ` Stephen Boyd
2011-01-25 21:58   ` Daniel Walker
2011-01-25 21:58     ` Daniel Walker
2011-01-26 22:03     ` David Brown
2011-01-26 22:03       ` David Brown
2011-01-26 22:04       ` Daniel Walker
2011-01-26 22:04         ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296079382.29801.45.camel@c-dwalke-linux.qualcomm.com \
    --to=dwalker@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=skannan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.