All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] n900: fix set online
@ 2011-01-27 10:51 Kai Vehmanen
  2011-01-27 11:18 ` Aki Niemi
  0 siblings, 1 reply; 2+ messages in thread
From: Kai Vehmanen @ 2011-01-27 10:51 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Invalid MTC_STATE_REQ messages were sent, causing failures in going
online.
---
 plugins/n900.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/n900.c b/plugins/n900.c
index 5b3a496..3d27b58 100644
--- a/plugins/n900.c
+++ b/plugins/n900.c
@@ -448,7 +448,7 @@ static void n900_set_online(struct ofono_modem *modem,
 	struct isi_cb_data *cbd = isi_cb_data_new(modem, cb, data);
 	const uint8_t req[] = {
 		MTC_STATE_REQ,
-		online ? MTC_NORMAL : MTC_RF_INACTIVE,
+		online ? MTC_NORMAL : MTC_RF_INACTIVE, 0
 	};
 
 	DBG("(%p) with %s", modem, isi->ifname);
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] n900: fix set online
  2011-01-27 10:51 [PATCH] n900: fix set online Kai Vehmanen
@ 2011-01-27 11:18 ` Aki Niemi
  0 siblings, 0 replies; 2+ messages in thread
From: Aki Niemi @ 2011-01-27 11:18 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

Hi Kai,

2011/1/27 Kai Vehmanen <kai.vehmanen@nokia.com>:
> Invalid MTC_STATE_REQ messages were sent, causing failures in going
> online.
> ---
>  plugins/n900.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Pushed, thanks!

Cheers,
Aki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-01-27 11:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-27 10:51 [PATCH] n900: fix set online Kai Vehmanen
2011-01-27 11:18 ` Aki Niemi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.