[Qemu-devel] [PATCH] qemu-io: Fix discard command

[Qemu-devel] [PATCH] qemu-io: Fix discard command

[Kevin Wolf]

qemu-io passed bytes where it's supposed to pass sectors, so discard requests
were off.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-io.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-io.c b/qemu-io.c
index 5b24c5e..4470e49 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -1465,7 +1465,7 @@ discard_f(int argc, char **argv)
 	}
 
 	gettimeofday(&t1, NULL);
-	ret = bdrv_discard(bs, offset, count);
+	ret = bdrv_discard(bs, offset >> BDRV_SECTOR_BITS, count >> BDRV_SECTOR_BITS);
 	gettimeofday(&t2, NULL);
 
 	if (ret < 0) {
-- 
1.7.2.3

Re: [Qemu-devel] [PATCH] qemu-io: Fix discard command

[Stefan Hajnoczi]

On Thu, Jan 27, 2011 at 01:36:12PM +0100, Kevin Wolf wrote:
> qemu-io passed bytes where it's supposed to pass sectors, so discard requests
> were off.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qemu-io.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-io.c b/qemu-io.c
> index 5b24c5e..4470e49 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -1465,7 +1465,7 @@ discard_f(int argc, char **argv)
>  	}
>  
>  	gettimeofday(&t1, NULL);
> -	ret = bdrv_discard(bs, offset, count);
> +	ret = bdrv_discard(bs, offset >> BDRV_SECTOR_BITS, count >> BDRV_SECTOR_BITS);

Oops, thanks for the fix.

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>