All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Brabec <utx@penguin.cz>
To: openembedded-devel@lists.openembedded.org
Subject: [RFC][PATCH] binconfig.bbclass: search configs in PKGD instead of S
Date: Thu, 27 Jan 2011 23:31:05 +0100	[thread overview]
Message-ID: <1296167465.14370.7.camel@utx.lan> (raw)

Hallo.

It seems that searching for binconfig in S makes more problems than it
brings benefits. It breaks for example ncurses - it populates
ncurses-config instead of ncurses5-config and ncursesw5-config).

Searching in the installed root seems to be more logical.

Most packages don't need to be ported to this change, as they install
config file with the same name as it exists in sources. But probably
several will need porting.

--- a/classes/binconfig.bbclass
+++ b/classes/binconfig.bbclass
@@ -49,7 +49,7 @@
 SYSROOT_PREPROCESS_FUNCS += "binconfig_sysroot_preprocess"
 
 binconfig_sysroot_preprocess () {
-	for config in `find ${S} -name '${BINCONFIG_GLOB}'`; do
+	for config in `find ${PKGD} -name '${BINCONFIG_GLOB}'`; do
 		configname=`basename $config`
 		install -d ${SYSROOT_DESTDIR}${STAGING_BINDIR_CROSS}
 		cat $config | sed ${@get_binconfig_mangle(d)} > ${SYSROOT_DESTDIR}${STAGING_BINDIR_CROSS}/$configname

-- 

________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus




             reply	other threads:[~2011-01-27 22:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 22:31 Stanislav Brabec [this message]
2011-01-28  1:19 ` [RFC][PATCH] binconfig.bbclass: search configs in PKGD instead of S Andreas Oberritter
2011-01-28 14:32   ` Stanislav Brabec
2011-01-28  5:03 ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296167465.14370.7.camel@utx.lan \
    --to=utx@penguin.cz \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.