From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [RFC][PATCH] binconfig.bbclass: search configs in PKGD instead of S
Date: Fri, 28 Jan 2011 02:19:07 +0100 [thread overview]
Message-ID: <4D42198B.5070604@opendreambox.org> (raw)
In-Reply-To: <1296167465.14370.7.camel@utx.lan>
On 01/27/2011 11:31 PM, Stanislav Brabec wrote:
> It seems that searching for binconfig in S makes more problems than it
> brings benefits. It breaks for example ncurses - it populates
> ncurses-config instead of ncurses5-config and ncursesw5-config).
Indeed. Installing *-config files which don't get installed by the
recipe is prone to cause subtle errors. I modified pkgconfig.bbclass in
a similar way in commit c2c8fe4c5629add94bd0b922f5b3446624a9f4d8.
"find recipes -name "*-config" -type f" shows candidates which may cause
breakage with this patch applied, in case they need to be installed but
only get copied to the source directory.
> Searching in the installed root seems to be more logical.
>
> Most packages don't need to be ported to this change, as they install
> config file with the same name as it exists in sources. But probably
> several will need porting.
Why is this function needed at all? Isn't it possible to do the mangling
before or after do_install like in pkgconfig.bbclass?
Regards,
Andreas
next prev parent reply other threads:[~2011-01-28 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 22:31 [RFC][PATCH] binconfig.bbclass: search configs in PKGD instead of S Stanislav Brabec
2011-01-28 1:19 ` Andreas Oberritter [this message]
2011-01-28 14:32 ` Stanislav Brabec
2011-01-28 5:03 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D42198B.5070604@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.