All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haiying Wang <Haiying.Wang@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] p1021mds: add QE and UEC support
Date: Mon, 31 Jan 2011 15:50:13 -0500	[thread overview]
Message-ID: <1296507013.2049.506.camel@haiying-laptop> (raw)
In-Reply-To: <20110131201154.B982BD4D67C@gemini.denx.de>

On Mon, 2011-01-31 at 21:11 +0100, Wolfgang Denk wrote:
> >  
> > +#ifdef CONFIG_P1021
> > +	ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
> > +
> > +	/* QE9 and QE12 need to be set for enabling QE MII managment signals */
> > +	setbits_be32(&gur->pmuxcr, MPC85xx_PMUXCR_QE9);
> > +	setbits_be32(&gur->pmuxcr, MPC85xx_PMUXCR_QE12);
> > +#endif
> ...
> 
> Can we please avoid having board specific code in common files?
I wish I could, but only P1021 has such pin mux problems.

> If this is really necessary, it shoud be a feature-specific #define,
> not a board specific one.
I don't know whether this *feature* will show up on other SoC. But if
you insist, I can use CONFIG_QE_PIN_MUX.

Thanks.

Haiying

  reply	other threads:[~2011-01-31 20:50 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 18:41 [U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 1/6] Introduce the Tertiary Program loader Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 2/6] powerpc/85xx: add TPL support Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support Haiying.Wang at freescale.com
2011-01-31 20:03   ` Wolfgang Denk
2011-01-31 20:08     ` Scott Wood
2011-01-31 20:18       ` Wolfgang Denk
2011-01-31 20:23         ` Scott Wood
2011-01-31 21:39     ` Haiying Wang
2011-01-31 22:05       ` Kumar Gala
2011-01-31 22:16         ` Wolfgang Denk
2011-01-31 22:14       ` Wolfgang Denk
2011-01-31 21:40     ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 4/6] powerpc/p1021: add more P1021 defines Haiying.Wang at freescale.com
2011-01-31 20:07   ` Wolfgang Denk
2011-01-31 21:08   ` Kumar Gala
2011-01-31 23:36     ` Timur Tabi
2011-02-01  4:04       ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 5/6] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash Haiying.Wang at freescale.com
2011-01-31 20:08   ` Wolfgang Denk
2011-01-31 21:02     ` Haiying Wang
2011-01-31 21:37       ` Wolfgang Denk
2011-02-02  4:29         ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 6/6] p1021mds: add QE and UEC support Haiying.Wang at freescale.com
2011-01-31 20:11   ` Wolfgang Denk
2011-01-31 20:50     ` Haiying Wang [this message]
2011-01-31 21:28       ` Kumar Gala
2011-02-01  3:14         ` Haiying Wang
2011-02-01 16:50           ` Scott Wood
2011-02-01 17:01             ` Haiying Wang
2011-02-01 19:15               ` Kumar Gala
2011-02-01 19:46                 ` Haiying Wang
2011-02-02  4:25                   ` Kumar Gala
2011-01-31 19:39 ` [U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board Wolfgang Denk
2011-01-31 20:13   ` Scott Wood
2011-01-31 20:22     ` Wolfgang Denk
2011-01-31 20:31       ` Scott Wood
2011-01-31 20:39         ` Kumar Gala
2011-01-31 20:50           ` Wolfgang Denk
2011-01-31 20:50         ` Wolfgang Denk
2011-01-31 21:15           ` Scott Wood
2011-01-31 21:34             ` Wolfgang Denk
2011-01-31 22:07               ` Scott Wood
2011-01-31 22:40                 ` Wolfgang Denk
2011-01-31 22:55                   ` Scott Wood
2011-02-01  5:26 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296507013.2049.506.camel@haiying-laptop \
    --to=haiying.wang@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.