All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support
Date: Mon, 31 Jan 2011 23:16:17 +0100	[thread overview]
Message-ID: <20110131221617.DFF94D4D67C@gemini.denx.de> (raw)
In-Reply-To: <AE2E740C-25BB-48DB-BB6F-A92B91D57938@kernel.crashing.org>

Dear Kumar Gala,

In message <AE2E740C-25BB-48DB-BB6F-A92B91D57938@kernel.crashing.org> you wrote:
> 
> >>> +LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds
> >>> +endif
> >>> +endif
> >>> +endif
> >> 
> >> Why is this config.mk needed?  Can you not do all this in the board
> >> config file instead?
> > Do you mean the board header file or arch/powerpc/config.mk? I did not
> see any LDSCRIPT defined in Freescale board header file.
> 
> I think something like:
> 
> diff --git a/include/configs/MPC8572DS.h b/include/configs/MPC8572DS.h
> index e6b60cf..f2d6cdb 100644
> --- a/include/configs/MPC8572DS.h
> +++ b/include/configs/MPC8572DS.h
> @@ -37,6 +37,7 @@
>  #define CONFIG_NAND_U_BOOT
>  #define CONFIG_RAMBOOT_NAND
>  #ifdef CONFIG_NAND_SPL
> +#define CONFIG_SYS_LDSCRIPT "arch/powerpc/cpu/mpc85xx/u-boot-nand.lds"

This will eventually break with out of tree builds.

Rather use

#define CONFIG_SYS_LDSCRIPT $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
	-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
	   stardate unknown.

  reply	other threads:[~2011-01-31 22:16 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 18:41 [U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 1/6] Introduce the Tertiary Program loader Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 2/6] powerpc/85xx: add TPL support Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support Haiying.Wang at freescale.com
2011-01-31 20:03   ` Wolfgang Denk
2011-01-31 20:08     ` Scott Wood
2011-01-31 20:18       ` Wolfgang Denk
2011-01-31 20:23         ` Scott Wood
2011-01-31 21:39     ` Haiying Wang
2011-01-31 22:05       ` Kumar Gala
2011-01-31 22:16         ` Wolfgang Denk [this message]
2011-01-31 22:14       ` Wolfgang Denk
2011-01-31 21:40     ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 4/6] powerpc/p1021: add more P1021 defines Haiying.Wang at freescale.com
2011-01-31 20:07   ` Wolfgang Denk
2011-01-31 21:08   ` Kumar Gala
2011-01-31 23:36     ` Timur Tabi
2011-02-01  4:04       ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 5/6] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash Haiying.Wang at freescale.com
2011-01-31 20:08   ` Wolfgang Denk
2011-01-31 21:02     ` Haiying Wang
2011-01-31 21:37       ` Wolfgang Denk
2011-02-02  4:29         ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 6/6] p1021mds: add QE and UEC support Haiying.Wang at freescale.com
2011-01-31 20:11   ` Wolfgang Denk
2011-01-31 20:50     ` Haiying Wang
2011-01-31 21:28       ` Kumar Gala
2011-02-01  3:14         ` Haiying Wang
2011-02-01 16:50           ` Scott Wood
2011-02-01 17:01             ` Haiying Wang
2011-02-01 19:15               ` Kumar Gala
2011-02-01 19:46                 ` Haiying Wang
2011-02-02  4:25                   ` Kumar Gala
2011-01-31 19:39 ` [U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board Wolfgang Denk
2011-01-31 20:13   ` Scott Wood
2011-01-31 20:22     ` Wolfgang Denk
2011-01-31 20:31       ` Scott Wood
2011-01-31 20:39         ` Kumar Gala
2011-01-31 20:50           ` Wolfgang Denk
2011-01-31 20:50         ` Wolfgang Denk
2011-01-31 21:15           ` Scott Wood
2011-01-31 21:34             ` Wolfgang Denk
2011-01-31 22:07               ` Scott Wood
2011-01-31 22:40                 ` Wolfgang Denk
2011-01-31 22:55                   ` Scott Wood
2011-02-01  5:26 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110131221617.DFF94D4D67C@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.