[PATCH 0/2] Fix issue with DST

[PATCH 0/2] Fix issue with DST

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi,

 Following patch converts the DST from hours to seconds which is the
expected outcome.

Regards,
Jeevaka

Jeevaka Badrappan (2):
  atmodem: convert dst from hours to seconds
  isimodem: convert dst from hours to seconds

 drivers/atmodem/network-registration.c  |    2 +-
 drivers/isimodem/network-registration.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 1/2] atmodem: convert dst from hours to seconds

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

---
 drivers/atmodem/network-registration.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
index 4913611..3df72af 100644
--- a/drivers/atmodem/network-registration.c
+++ b/drivers/atmodem/network-registration.c
@@ -741,7 +741,7 @@ static void ifx_ctzdst_notify(GAtResult *result, gpointer user_data)
 
 	DBG("dst %d", dst);
 
-	nd->time.dst = dst;
+	nd->time.dst = dst * 60 * 60;
 
 	ofono_netreg_time_notify(netreg, &nd->time);
 }
-- 
1.7.0.4

[PATCH 2/2] isimodem: convert dst from hours to seconds

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

---
 drivers/isimodem/network-registration.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isimodem/network-registration.c b/drivers/isimodem/network-registration.c
index 6518968..8711670 100644
--- a/drivers/isimodem/network-registration.c
+++ b/drivers/isimodem/network-registration.c
@@ -704,7 +704,7 @@ static gboolean parse_nettime(GIsiSubBlockIter *iter,
 	if (time->utc & 0x80)
 		info->utcoff *= -1;
 
-	info->dst = time->dst != NET_INVALID_TIME ? time->dst : -1;
+	info->dst = time->dst != NET_INVALID_TIME ? time->dst * 60 * 60 : -1;
 	return TRUE;
 }
 
-- 
1.7.0.4

Re: [PATCH 0/2] Fix issue with DST

[=?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

On Tuesday 01 February 2011 13:44:03 ext Jeevaka Badrappan, you wrote:
> Hi,
> 
>  Following patch converts the DST from hours to seconds which is the
> expected outcome.

Is it? I think DST is just a boolean.

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki

RE: [PATCH 0/2] Fix issue with DST

[Jeevaka.Badrappan]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

ofono-bounces(a)ofono.org wrote:
> On Tuesday 01 February 2011 13:44:03 ext Jeevaka Badrappan, you wrote:
>> Hi,
>> 
>>  Following patch converts the DST from hours to seconds which is the
>> expected outcome.
> 
> Is it? I think DST is just a boolean.

Refere 3GPP TS 24.008 section 10.5.3.12

Regards,
Jeevaka