* [PATCH] ASoC: Tegra: Harmony: Remove redundant !!
@ 2011-01-31 18:00 Stephen Warren
2011-02-01 14:01 ` Liam Girdwood
2011-02-01 14:14 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Warren @ 2011-01-31 18:00 UTC (permalink / raw)
To: broonie, lrg; +Cc: linux-tegra, alsa-devel, Stephen Warren
gpio_set_value* should accept logic values not just 0 or 1. The WM8903 GPIO
driver has been fixed to work this way, so remove the redundant !!
previously required when it didn't accept values >1.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
sound/soc/tegra/harmony.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/tegra/harmony.c b/sound/soc/tegra/harmony.c
index d1faa63..11e2cb8 100644
--- a/sound/soc/tegra/harmony.c
+++ b/sound/soc/tegra/harmony.c
@@ -132,7 +132,7 @@ static int harmony_event_int_spk(struct snd_soc_dapm_widget *w,
struct harmony_audio_platform_data *pdata = harmony->pdata;
gpio_set_value_cansleep(pdata->gpio_spkr_en,
- !!SND_SOC_DAPM_EVENT_ON(event));
+ SND_SOC_DAPM_EVENT_ON(event));
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Tegra: Harmony: Remove redundant !!
2011-01-31 18:00 [PATCH] ASoC: Tegra: Harmony: Remove redundant !! Stephen Warren
@ 2011-02-01 14:01 ` Liam Girdwood
2011-02-01 14:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-02-01 14:01 UTC (permalink / raw)
To: Stephen Warren; +Cc: linux-tegra, alsa-devel, broonie
On Mon, 2011-01-31 at 11:00 -0700, Stephen Warren wrote:
> gpio_set_value* should accept logic values not just 0 or 1. The WM8903 GPIO
> driver has been fixed to work this way, so remove the redundant !!
> previously required when it didn't accept values >1.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> sound/soc/tegra/harmony.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/tegra/harmony.c b/sound/soc/tegra/harmony.c
> index d1faa63..11e2cb8 100644
> --- a/sound/soc/tegra/harmony.c
> +++ b/sound/soc/tegra/harmony.c
> @@ -132,7 +132,7 @@ static int harmony_event_int_spk(struct snd_soc_dapm_widget *w,
> struct harmony_audio_platform_data *pdata = harmony->pdata;
>
> gpio_set_value_cansleep(pdata->gpio_spkr_en,
> - !!SND_SOC_DAPM_EVENT_ON(event));
> + SND_SOC_DAPM_EVENT_ON(event));
>
> return 0;
> }
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Tegra: Harmony: Remove redundant !!
2011-01-31 18:00 [PATCH] ASoC: Tegra: Harmony: Remove redundant !! Stephen Warren
2011-02-01 14:01 ` Liam Girdwood
@ 2011-02-01 14:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-02-01 14:14 UTC (permalink / raw)
To: Stephen Warren; +Cc: linux-tegra, alsa-devel, lrg
On Mon, Jan 31, 2011 at 11:00:17AM -0700, Stephen Warren wrote:
> gpio_set_value* should accept logic values not just 0 or 1. The WM8903 GPIO
> driver has been fixed to work this way, so remove the redundant !!
> previously required when it didn't accept values >1.
Applied thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-01 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-31 18:00 [PATCH] ASoC: Tegra: Harmony: Remove redundant !! Stephen Warren
2011-02-01 14:01 ` Liam Girdwood
2011-02-01 14:14 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.