All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5
Date: Tue, 01 Feb 2011 16:43:13 +0100	[thread overview]
Message-ID: <1296574993.1520.272.camel@aeonflux> (raw)
In-Reply-To: <ee97ff346483182ef6af8e5d023b10ffe12dd28f.1296569048.git.jessica.j.nilsson@stericsson.com>

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi Jessica,

>  drivers/isimodem/debug.c   |  132 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/isimodem/debug.h   |    9 +++
>  drivers/isimodem/mtc.h     |   38 +++++++++++++
>  drivers/isimodem/version.h |   26 +++++++++
>  4 files changed, 205 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/isimodem/version.h

<snip>

> +enum isi_version {
> +	ISI_20 = 0,
> +	ISI_25 = 1
> +};

so what is the final decision here now. ISI doing auto-detection and
this gets not exposed to the modem drivers or we do.

Aki, I remember you saying that this is not needed at all.

Regards

Marcel



  reply	other threads:[~2011-02-01 15:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 14:13 [PATCH v2 0/3] ISI modem version detection with plugin Jessica Nilsson
2011-02-01 14:13 ` [PATCH v2 1/3] u8500: add plugin for u8500 Jessica Nilsson
2011-02-01 15:41   ` Marcel Holtmann
2011-02-01 14:13 ` [PATCH v2 2/3] udev: u8500 support and style fix Jessica Nilsson
2011-02-01 15:39   ` Marcel Holtmann
2011-02-01 15:55     ` Andreas WESTIN
2011-02-01 16:12       ` Marcel Holtmann
2011-02-01 14:13 ` [PATCH v2 3/3] isimodem: header updates for ISI2.5 Jessica Nilsson
2011-02-01 15:43   ` Marcel Holtmann [this message]
2011-02-01 16:29     ` Andreas WESTIN
2011-02-01 19:32     ` Aki Niemi
2011-02-02  9:03       ` Andreas WESTIN
2011-02-02 13:03         ` Aki Niemi
2011-02-03  9:32           ` Andreas WESTIN
2011-02-04  9:05             ` Aki Niemi
2011-02-02 10:47       ` Marcel Holtmann
2011-02-08 15:16       ` Aki Niemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296574993.1520.272.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.