From: Aki Niemi <aki@protocolpolice.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5
Date: Fri, 04 Feb 2011 11:05:34 +0200 [thread overview]
Message-ID: <AANLkTi=_pF5mSkMsAYhrrrYWmNqz-g9eaXqiewH_AOk3@mail.gmail.com> (raw)
In-Reply-To: <4D4A7621.6030508@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
Hi Andreas,
2011/2/3 Andreas WESTIN <andreas.westin@stericsson.com>:
>> I don't see what that has to do with the device supporting the "PC
>> suite" USB profile, which allows modem access using cdc_phonet.
>
> Currently our platform does not support this.
Well, I know of platforms that do, and have different versions of ISI modems.
>> That is exactly what I meant. This version allows building quirks inside
>> the drivers. An example in pseudo-code:
>>
>> if GIsiVersion.major == 15 and GIsiVersion.minor>= 3:
>> send( { FOO, value, filler, filler}, callback1 )
>> else:
>> send( { FOO, value }, callback2 )
>>
>
> Yes, we use a similar solution in gisi, but Rémi pointed out that it would
> be a maintenance problem once there are more versions to support and I tend
> to agree. A solution could be to use a lookup function, but this function
> would need to return something to compare with, an enum perhaps.
> Also are you certain that e.g major == 15 and minor == 25 is still the same
> ISI version, if not then the lookup function could become messy.
The PNS_SUBSCRIBED_RESOURCES_EXTEND_IND is a bit of a special case, as
it requires quirking inside GIsiModem. But see my other response in
that thread.
Cheers,
Aki
next prev parent reply other threads:[~2011-02-04 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 14:13 [PATCH v2 0/3] ISI modem version detection with plugin Jessica Nilsson
2011-02-01 14:13 ` [PATCH v2 1/3] u8500: add plugin for u8500 Jessica Nilsson
2011-02-01 15:41 ` Marcel Holtmann
2011-02-01 14:13 ` [PATCH v2 2/3] udev: u8500 support and style fix Jessica Nilsson
2011-02-01 15:39 ` Marcel Holtmann
2011-02-01 15:55 ` Andreas WESTIN
2011-02-01 16:12 ` Marcel Holtmann
2011-02-01 14:13 ` [PATCH v2 3/3] isimodem: header updates for ISI2.5 Jessica Nilsson
2011-02-01 15:43 ` Marcel Holtmann
2011-02-01 16:29 ` Andreas WESTIN
2011-02-01 19:32 ` Aki Niemi
2011-02-02 9:03 ` Andreas WESTIN
2011-02-02 13:03 ` Aki Niemi
2011-02-03 9:32 ` Andreas WESTIN
2011-02-04 9:05 ` Aki Niemi [this message]
2011-02-02 10:47 ` Marcel Holtmann
2011-02-08 15:16 ` Aki Niemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=_pF5mSkMsAYhrrrYWmNqz-g9eaXqiewH_AOk3@mail.gmail.com' \
--to=aki@protocolpolice.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.