From: john stultz <johnstul@us.ibm.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
David Miller <davem@davemloft.net>,
Krzysztof Halasa <khc@pm.waw.pl>,
Peter Zijlstra <peterz@infradead.org>,
Rodolfo Giometti <giometti@linux.it>,
Thomas Gleixner <tglx@linutronix.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Mike Frysinger <vapier@gentoo.org>,
Paul Mackerras <paulus@samba.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH V10 14/15] ptp: Added a clock driver for the IXP46x.
Date: Tue, 01 Feb 2011 18:10:49 -0800 [thread overview]
Message-ID: <1296612649.3336.213.camel@work-vm> (raw)
In-Reply-To: <0319138702479bc484596a2b10c681a7d8313b98.1296124770.git.richard.cochran@omicron.at>
On Thu, 2011-01-27 at 12:00 +0100, Richard Cochran wrote:
> This patch adds a driver for the hardware time stamping unit found on the
> IXP465. The basic clock operations and an external trigger are implemented.
>
> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
Minor nit below, but otherwise,
Acked-by: John Stultz <johnstul@us.ibm.com>
> diff --git a/drivers/ptp/ptp_ixp46x.c b/drivers/ptp/ptp_ixp46x.c
> new file mode 100644
> index 0000000..c860030
> --- /dev/null
> +++ b/drivers/ptp/ptp_ixp46x.c
[snip]
> +static int __init ptp_ixp_init(void)
> +{
> + if (!cpu_is_ixp46x())
> + return -ENODEV;
> +
> + ixp_clock.regs =
> + (struct ixp46x_ts_regs __iomem *)IXP4XX_TIMESYNC_BASE_VIRT;
Minor whitespace issue here
WARNING: multiple messages have this Message-ID (diff)
From: john stultz <johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Richard Cochran <richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Krzysztof Halasa <khc-9GfyWEdoJtJmR6Xm/wNWPw@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Rodolfo Giometti <giometti-k2GhghHVRtY@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Subject: Re: [PATCH V10 14/15] ptp: Added a clock driver for the IXP46x.
Date: Tue, 01 Feb 2011 18:10:49 -0800 [thread overview]
Message-ID: <1296612649.3336.213.camel@work-vm> (raw)
In-Reply-To: <0319138702479bc484596a2b10c681a7d8313b98.1296124770.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
On Thu, 2011-01-27 at 12:00 +0100, Richard Cochran wrote:
> This patch adds a driver for the hardware time stamping unit found on the
> IXP465. The basic clock operations and an external trigger are implemented.
>
> Signed-off-by: Richard Cochran <richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
Minor nit below, but otherwise,
Acked-by: John Stultz <johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> diff --git a/drivers/ptp/ptp_ixp46x.c b/drivers/ptp/ptp_ixp46x.c
> new file mode 100644
> index 0000000..c860030
> --- /dev/null
> +++ b/drivers/ptp/ptp_ixp46x.c
[snip]
> +static int __init ptp_ixp_init(void)
> +{
> + if (!cpu_is_ixp46x())
> + return -ENODEV;
> +
> + ixp_clock.regs =
> + (struct ixp46x_ts_regs __iomem *)IXP4XX_TIMESYNC_BASE_VIRT;
Minor whitespace issue here
next prev parent reply other threads:[~2011-02-02 2:10 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 10:53 [PATCH V10 00/15] ptp: IEEE 1588 hardware clock support Richard Cochran
2011-01-27 10:53 ` Richard Cochran
2011-01-27 10:54 ` [PATCH V10 01/15] time: Introduce timekeeping_inject_offset John Stultz
2011-01-27 18:48 ` John Stultz
2011-01-28 7:08 ` Richard Cochran
2011-01-28 7:08 ` Richard Cochran
2011-01-28 12:05 ` Arnd Bergmann
2011-01-28 12:05 ` Arnd Bergmann
2011-01-28 12:43 ` Peter Zijlstra
2011-01-28 12:54 ` Arnd Bergmann
2011-01-28 12:54 ` Arnd Bergmann
2011-01-27 10:54 ` [PATCH V10 02/15] time: Correct the *settime* parameters Richard Cochran
2011-01-27 10:55 ` [PATCH V10 03/15] ntp: add ADJ_SETOFFSET mode bit Richard Cochran
2011-01-27 10:55 ` [PATCH V10 04/15] posix clocks: introduce a syscall for clock tuning Richard Cochran
2011-01-27 10:55 ` Richard Cochran
2011-01-27 10:56 ` [PATCH V10 05/15] posix_clocks: add clock_adjtime for arm Richard Cochran
2011-01-27 10:56 ` Richard Cochran
2011-01-27 10:57 ` [PATCH V10 06/15] posix_clocks: add clock_adjtime for blackfin Richard Cochran
2011-01-27 10:57 ` [PATCH V10 07/15] posix_clocks: add clock_adjtime for powerpc Richard Cochran
2011-01-27 10:57 ` [PATCH V10 08/15] posix_clocks: add clock_adjtime for x86 Richard Cochran
2011-01-27 10:58 ` [PATCH V10 09/15] posix clocks: cleanup the CLOCK_DISPTACH macro Richard Cochran
2011-01-27 10:58 ` Richard Cochran
2011-01-27 10:58 ` [PATCH V10 10/15] posix clocks: remove useless default methods Richard Cochran
2011-01-27 10:58 ` Richard Cochran
2011-01-27 10:58 ` [PATCH V10 11/15] posix clocks: introduce dynamic clocks Richard Cochran
2011-01-27 10:58 ` Richard Cochran
2011-01-27 10:59 ` [PATCH V10 12/15] ptp: Added a brand new class driver for ptp clocks Richard Cochran
2011-02-02 2:00 ` John Stultz
2011-02-02 2:00 ` John Stultz
2011-02-11 8:15 ` Richard Cochran
2011-02-11 8:15 ` Richard Cochran
2011-02-15 17:29 ` Richard Cochran
2011-01-27 10:59 ` [PATCH V10 13/15] ptp: Added a clock that uses the eTSEC found on the MPC85xx Richard Cochran
2011-01-27 10:59 ` Richard Cochran
2011-02-02 2:04 ` john stultz
2011-02-02 2:04 ` john stultz
2011-01-27 11:00 ` [PATCH V10 14/15] ptp: Added a clock driver for the IXP46x Richard Cochran
2011-02-02 2:10 ` john stultz [this message]
2011-02-02 2:10 ` john stultz
2011-01-27 11:00 ` [PATCH V10 15/15] ptp: Added a clock driver for the National Semiconductor PHYTER Richard Cochran
2011-01-27 11:00 ` Richard Cochran
2011-02-02 2:11 ` john stultz
2011-02-02 2:11 ` john stultz
2011-02-11 8:19 ` Richard Cochran
2011-01-31 9:29 ` [PATCH V10 00/15] ptp: IEEE 1588 hardware clock support Thomas Gleixner
2011-01-31 9:29 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296612649.3336.213.camel@work-vm \
--to=johnstul@us.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=giometti@linux.it \
--cc=hpa@zytor.com \
--cc=khc@pm.waw.pl \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.