All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Vivek Natarajan <vnatarajan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Fix a race on enabling power save.
Date: Fri, 04 Feb 2011 11:31:30 +0100	[thread overview]
Message-ID: <1296815490.3671.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1296800640-6381-2-git-send-email-vnatarajan@atheros.com>

On Fri, 2011-02-04 at 11:54 +0530, Vivek Natarajan wrote:

> @@ -1648,6 +1649,11 @@ static void ieee80211_xmit(struct ieee80211_sub_if_data *sdata,
>  				return;
>  			}
>  
> +	ifmgd = &sdata->u.mgd;
> +	if (!(ieee80211_is_nullfunc(hdr->frame_control)) &&
> +	    (ifmgd->flags & IEEE80211_STA_PS_PENDING))
> +		ifmgd->flags &= ~IEEE80211_STA_PS_PENDING;
> +

Without even trying to understand the logic of the patch, this is
clearly broken since it assumes that all interfaces are of managed type.

johannes


  parent reply	other threads:[~2011-02-04 10:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04  6:23 [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame Vivek Natarajan
2011-02-04  6:24 ` [PATCH 2/2] mac80211: Fix a race on enabling power save Vivek Natarajan
2011-02-04  7:37   ` Luis R. Rodriguez
2011-02-04  9:26     ` Vivek Natarajan
2011-02-04 10:31   ` Johannes Berg [this message]
2011-02-04  7:36 ` [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame Luis R. Rodriguez
2011-02-04  7:36   ` Luis R. Rodriguez
2011-02-04 14:21     ` John W. Linville
2011-02-04 14:57       ` Greg KH
2011-02-04  8:28 ` Sujith
2011-02-04  9:17   ` Vivek Natarajan
2011-02-04 10:23     ` Sujith
2011-02-04 10:47       ` Vivek Natarajan
2011-02-04 11:07         ` Sujith
2011-02-09 19:06     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296815490.3671.1.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=vnatarajan@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.