All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
	Vivek Natarajan <vnatarajan@atheros.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame.
Date: Fri, 4 Feb 2011 06:57:07 -0800	[thread overview]
Message-ID: <20110204145707.GB11581@kroah.com> (raw)
In-Reply-To: <20110204142130.GB2539@tuxdriver.com>

On Fri, Feb 04, 2011 at 09:21:30AM -0500, John W. Linville wrote:
> On Thu, Feb 03, 2011 at 11:36:27PM -0800, Luis R. Rodriguez wrote:
> > Adding Greg for real this time.
> > 
> >   Luis
> > 
> > On Thu, Feb 3, 2011 at 11:36 PM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > > On Thu, Feb 3, 2011 at 10:23 PM, Vivek Natarajan <vnatarajan@atheros.com> wrote:
> > >> In a highly noisy environment, a data frame which is queued before
> > >> a nullfunc frame on a different hw queue may be sent over the air
> > >> after the tx completion of nullfunc frame. This causes the station
> > >> to enter power save and the AP to see the station as awake and
> > >> continues to send the data traffic. Fix this by draining all tx
> > >> queues before we send the null function frame with PM bit set.
> > >>
> > >> Signed-off-by: Vivek Natarajan <vnatarajan@atheros.com>
> > >
> > > Hm nice, this is a good example of one of those random not-so-critical
> > > but still nice fixes which I wish would go to stable. John, Greg, any
> > > qualms for such things to go to stable if they apply? It was my
> > > impression we could send it, but I want to verify with both you guys
> > > so neither we or John get bashed if we try to send it as a stable fix.
> 
> I think the feeling is that it is silly to mark something for stable if
> it is not important enough to be sent as a fix for the current release.

I totally agree.

thanks,

greg k-h

  reply	other threads:[~2011-02-04 14:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04  6:23 [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame Vivek Natarajan
2011-02-04  6:24 ` [PATCH 2/2] mac80211: Fix a race on enabling power save Vivek Natarajan
2011-02-04  7:37   ` Luis R. Rodriguez
2011-02-04  9:26     ` Vivek Natarajan
2011-02-04 10:31   ` Johannes Berg
2011-02-04  7:36 ` [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame Luis R. Rodriguez
2011-02-04  7:36   ` Luis R. Rodriguez
2011-02-04 14:21     ` John W. Linville
2011-02-04 14:57       ` Greg KH [this message]
2011-02-04  8:28 ` Sujith
2011-02-04  9:17   ` Vivek Natarajan
2011-02-04 10:23     ` Sujith
2011-02-04 10:47       ` Vivek Natarajan
2011-02-04 11:07         ` Sujith
2011-02-09 19:06     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110204145707.GB11581@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    --cc=vnatarajan@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.