From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
akpm@linux-foundation.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH -mm 2/6] powerpc: convert little-endian bitops macros to static inline functions
Date: Mon, 07 Feb 2011 10:14:46 +1100 [thread overview]
Message-ID: <1297034086.14982.8.camel@pasglop> (raw)
In-Reply-To: <1296136583-13815-3-git-send-email-akinobu.mita@gmail.com>
On Thu, 2011-01-27 at 22:56 +0900, Akinobu Mita wrote:
> (This patch is intended to be folded into the patch in -mm:
> powerpc-introduce-little-endian-bitops.patch)
>
> The little-endian bitops on powerpc are written as preprocessor
> macros with the cast to "unsigned long *".
> This means that even non-pointers will be accepted without an error, and
> that is a Very Bad Thing.
>
> This converts the little-endian bitops macros to static inline functions
> with proper prototypes.
No objection to the powerpc variant of the patches. What is the status
with the wholes series tho ? Does it looks like its going to be
accepted ? Do you expect my Ack and will merge the whole thing at once ?
Does it break bisection unless it's merged as one single giant patch ?
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
akpm@linux-foundation.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 2/6] powerpc: convert little-endian bitops macros to static inline functions
Date: Mon, 07 Feb 2011 10:14:46 +1100 [thread overview]
Message-ID: <1297034086.14982.8.camel@pasglop> (raw)
In-Reply-To: <1296136583-13815-3-git-send-email-akinobu.mita@gmail.com>
On Thu, 2011-01-27 at 22:56 +0900, Akinobu Mita wrote:
> (This patch is intended to be folded into the patch in -mm:
> powerpc-introduce-little-endian-bitops.patch)
>
> The little-endian bitops on powerpc are written as preprocessor
> macros with the cast to "unsigned long *".
> This means that even non-pointers will be accepted without an error, and
> that is a Very Bad Thing.
>
> This converts the little-endian bitops macros to static inline functions
> with proper prototypes.
No objection to the powerpc variant of the patches. What is the status
with the wholes series tho ? Does it looks like its going to be
accepted ? Do you expect my Ack and will merge the whole thing at once ?
Does it break bisection unless it's merged as one single giant patch ?
Cheers,
Ben.
next prev parent reply other threads:[~2011-02-06 23:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 13:56 [PATCH -mm 0/6] convert little-endian bitops macros to inline functions Akinobu Mita
2011-01-27 13:56 ` [PATCH -mm 1/6] asm-generic: convert little-endian bitops macros to static " Akinobu Mita
2011-01-27 13:56 ` Akinobu Mita
2011-01-27 13:56 ` [PATCH -mm 2/6] powerpc: " Akinobu Mita
2011-01-27 13:56 ` Akinobu Mita
2011-02-06 23:14 ` Benjamin Herrenschmidt [this message]
2011-02-06 23:14 ` Benjamin Herrenschmidt
2011-02-07 3:08 ` Akinobu Mita
2011-02-07 3:08 ` Akinobu Mita
2011-01-27 13:56 ` [PATCH -mm 3/6] s390: " Akinobu Mita
2011-01-27 13:56 ` [PATCH -mm 4/6] arm: " Akinobu Mita
2011-01-27 13:56 ` [PATCH -mm 5/6] m68k: " Akinobu Mita
2011-01-27 13:56 ` [PATCH -mm 6/6] m68knommu: " Akinobu Mita
2011-01-28 0:36 ` Greg Ungerer
2011-01-28 0:36 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297034086.14982.8.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.