* [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration @ 2011-02-09 9:54 julien.boibessot at free.fr 2011-02-10 13:10 ` Sascha Hauer 0 siblings, 1 reply; 5+ messages in thread From: julien.boibessot at free.fr @ 2011-02-09 9:54 UTC (permalink / raw) To: linux-arm-kernel From: Julien Boibessot <julien.boibessot@armadeus.com> Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com> --- arch/arm/plat-mxc/include/mach/iomux-mx51.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-mxc/include/mach/iomux-mx51.h b/arch/arm/plat-mxc/include/mach/iomux-mx51.h index b6767f9..df531aa 100644 --- a/arch/arm/plat-mxc/include/mach/iomux-mx51.h +++ b/arch/arm/plat-mxc/include/mach/iomux-mx51.h @@ -473,7 +473,7 @@ #define _MX51_PAD_UART2_RXD__UART2_RXD IOMUX_PAD(0x628, 0x238, 0, 0x09ec, 2, 0) #define _MX51_PAD_UART2_TXD__FIRI_RXD IOMUX_PAD(0x62c, 0x23c, 1, 0x0000, 0, 0) #define _MX51_PAD_UART2_TXD__GPIO1_21 IOMUX_PAD(0x62c, 0x23c, 3, 0x0000, 0, 0) -#define _MX51_PAD_UART2_TXD__UART2_TXD IOMUX_PAD(0x62c, 0x23c, 0, 0x09ec, 3, 0) +#define _MX51_PAD_UART2_TXD__UART2_TXD IOMUX_PAD(0x62c, 0x23c, 0, 0x0000, 0, 0) #define _MX51_PAD_UART3_RXD__CSI1_D0 IOMUX_PAD(0x630, 0x240, 2, 0x0000, 0, 0) #define _MX51_PAD_UART3_RXD__GPIO1_22 IOMUX_PAD(0x630, 0x240, 3, 0x0000, 0, 0) #define _MX51_PAD_UART3_RXD__UART1_DTR IOMUX_PAD(0x630, 0x240, 0, 0x0000, 0, 0) -- 1.6.0.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration 2011-02-09 9:54 [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration julien.boibessot at free.fr @ 2011-02-10 13:10 ` Sascha Hauer 2011-02-10 13:54 ` Julien Boibessot 2011-02-11 8:16 ` Richard Zhao 0 siblings, 2 replies; 5+ messages in thread From: Sascha Hauer @ 2011-02-10 13:10 UTC (permalink / raw) To: linux-arm-kernel Hi Julien, The patch is probably fine. Can you provide a better commit log, something like 'fixes uart3 on $myboard'? ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration 2011-02-10 13:10 ` Sascha Hauer @ 2011-02-10 13:54 ` Julien Boibessot 2011-02-10 20:55 ` Sascha Hauer 2011-02-11 8:16 ` Richard Zhao 1 sibling, 1 reply; 5+ messages in thread From: Julien Boibessot @ 2011-02-10 13:54 UTC (permalink / raw) To: linux-arm-kernel Hi Sascha, Sascha Hauer a ?crit : > The patch is probably fine. Can you provide a better commit log, > something like 'fixes uart3 on $myboard'? > yes, I will try :-) > >From looking at the datasheet it is not clear to me how the current pin > configuration bahaves. It looks like a uart tx loopback in the iomuxer. > Is this correct? > Well I just reverted the setting back to what it was on 2.6.36, before the recent MX51 iomux reorganisation. IOMUXC_UART2_IPP_UART_RXD_MUX_SELECT_INPUT register (0x09ec) shouldn't be used to configure UART2_TXD PAD, otherwise you overwrite current UART2_RXD PAD config. Current pin configuration seems to act as a kind of Tx->Rx loopback, yes. Without my patch, my board (not mainlined yet) can't receive anything on UART2 (used as console). Julien ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration 2011-02-10 13:54 ` Julien Boibessot @ 2011-02-10 20:55 ` Sascha Hauer 0 siblings, 0 replies; 5+ messages in thread From: Sascha Hauer @ 2011-02-10 20:55 UTC (permalink / raw) To: linux-arm-kernel On Thu, Feb 10, 2011 at 02:54:52PM +0100, Julien Boibessot wrote: > Hi Sascha, > > Sascha Hauer a ?crit : > > The patch is probably fine. Can you provide a better commit log, > > something like 'fixes uart3 on $myboard'? > > > yes, I will try :-) > > >From looking at the datasheet it is not clear to me how the current pin > > configuration bahaves. It looks like a uart tx loopback in the iomuxer. > > Is this correct? > > > Well I just reverted the setting back to what it was on 2.6.36, before > the recent MX51 iomux reorganisation. > IOMUXC_UART2_IPP_UART_RXD_MUX_SELECT_INPUT register (0x09ec) shouldn't > be used to configure UART2_TXD PAD, otherwise you overwrite current > UART2_RXD PAD config. > Current pin configuration seems to act as a kind of Tx->Rx loopback, yes. Ok, would be good to have this in the commit log aswell. Sascha > > Without my patch, my board (not mainlined yet) can't receive anything on > UART2 (used as console). > > Julien > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration 2011-02-10 13:10 ` Sascha Hauer 2011-02-10 13:54 ` Julien Boibessot @ 2011-02-11 8:16 ` Richard Zhao 1 sibling, 0 replies; 5+ messages in thread From: Richard Zhao @ 2011-02-11 8:16 UTC (permalink / raw) To: linux-arm-kernel Hi Sascha, On Thu, Feb 10, 2011 at 02:10:51PM +0100, Sascha Hauer wrote: > Hi Julien, > > The patch is probably fine. Can you provide a better commit log, > something like 'fixes uart3 on $myboard'? > > From looking at the datasheet it is not clear to me how the current pin > configuration bahaves. It looks like a uart tx loopback in the iomuxer. > Is this correct? Yes. IOMUXC_UART2_IPP_UART_RXD_MUX_SELECT_INPUT is used to select input of IPP_UART_RXD. We always want it to connect to actual RXD pad. I'll check mx50 iomux header for such issues. Thanks Richard > > Sascha > > On Wed, Feb 09, 2011 at 10:54:01AM +0100, julien.boibessot at free.fr wrote: > > From: Julien Boibessot <julien.boibessot@armadeus.com> > > > > > > Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com> > > --- > > arch/arm/plat-mxc/include/mach/iomux-mx51.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/plat-mxc/include/mach/iomux-mx51.h b/arch/arm/plat-mxc/include/mach/iomux-mx51.h > > index b6767f9..df531aa 100644 > > --- a/arch/arm/plat-mxc/include/mach/iomux-mx51.h > > +++ b/arch/arm/plat-mxc/include/mach/iomux-mx51.h > > @@ -473,7 +473,7 @@ > > #define _MX51_PAD_UART2_RXD__UART2_RXD IOMUX_PAD(0x628, 0x238, 0, 0x09ec, 2, 0) > > #define _MX51_PAD_UART2_TXD__FIRI_RXD IOMUX_PAD(0x62c, 0x23c, 1, 0x0000, 0, 0) > > #define _MX51_PAD_UART2_TXD__GPIO1_21 IOMUX_PAD(0x62c, 0x23c, 3, 0x0000, 0, 0) > > -#define _MX51_PAD_UART2_TXD__UART2_TXD IOMUX_PAD(0x62c, 0x23c, 0, 0x09ec, 3, 0) > > +#define _MX51_PAD_UART2_TXD__UART2_TXD IOMUX_PAD(0x62c, 0x23c, 0, 0x0000, 0, 0) > > #define _MX51_PAD_UART3_RXD__CSI1_D0 IOMUX_PAD(0x630, 0x240, 2, 0x0000, 0, 0) > > #define _MX51_PAD_UART3_RXD__GPIO1_22 IOMUX_PAD(0x630, 0x240, 3, 0x0000, 0, 0) > > #define _MX51_PAD_UART3_RXD__UART1_DTR IOMUX_PAD(0x630, 0x240, 0, 0x0000, 0, 0) > > -- > > 1.6.0.4 > > > > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-02-11 8:16 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-02-09 9:54 [PATCH] i.MX51 iomux: Fixes MX51_PAD_UART2_TXD__UART2_TXD declaration julien.boibessot at free.fr 2011-02-10 13:10 ` Sascha Hauer 2011-02-10 13:54 ` Julien Boibessot 2011-02-10 20:55 ` Sascha Hauer 2011-02-11 8:16 ` Richard Zhao
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.