All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables
Date: Thu, 10 Feb 2011 11:07:27 +0100	[thread overview]
Message-ID: <1297332447-23532-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <4D52F566.1070009@ru.mvista.com>

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
Hello,

On Wed, Feb 09, 2011 at 11:13:26PM +0300, Sergei Shtylyov wrote:
> >>>-static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
> >>>+static struct spi_board_info __maybe_unused
> >>>+eukrea_mbimx27_spi_board_info[] __initdata = {
>
> >>   I think the second line should be somewhat indented.
> 
> >I like it as it is.  There are no rules for that, no?
> 
>    Documentation/CodingStyle, chapter 2.
hmm, this is how vim indents and checkpatch doesn't diagnose a style problem.
Though I prefer it unindented, too, I don't care enough.  So here's a patch
with the 2nd line having 2 tabs.  Up to Sascha which to include ...

Best regards and thanks,
Uwe

 arch/arm/mach-imx/eukrea_mbimx27-baseboard.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
index 275c858..d12815d 100644
--- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
+++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
@@ -249,7 +249,7 @@ static const struct imxuart_platform_data uart_pdata __initconst = {
 
 #define ADS7846_PENDOWN (GPIO_PORTD | 25)
 
-static void ads7846_dev_init(void)
+static void __maybe_unused ads7846_dev_init(void)
 {
 	if (gpio_request(ADS7846_PENDOWN, "ADS7846 pendown") < 0) {
 		printk(KERN_ERR "can't get ads746 pen down GPIO\n");
@@ -268,7 +268,8 @@ static struct ads7846_platform_data ads7846_config __initdata = {
 	.keep_vref_on		= 1,
 };
 
-static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
+static struct spi_board_info __maybe_unused
+		eukrea_mbimx27_spi_board_info[] __initdata = {
 	[0] = {
 		.modalias	= "ads7846",
 		.bus_num	= 0,
-- 
1.7.2.3

      reply	other threads:[~2011-02-10 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 20:17 [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables Uwe Kleine-König
2011-02-09 13:57 ` Sergei Shtylyov
2011-02-09 19:39   ` Uwe Kleine-König
2011-02-09 20:13     ` Sergei Shtylyov
2011-02-10 10:07       ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297332447-23532-1-git-send-email-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.