All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables
Date: Wed, 09 Feb 2011 23:13:26 +0300	[thread overview]
Message-ID: <4D52F566.1070009@ru.mvista.com> (raw)
In-Reply-To: <20110209193907.GS27982@pengutronix.de>

Hello.

Uwe Kleine-K?nig wrote:

>>> Signed-off-by: Uwe Kleine-K?nig<u.kleine-koenig@pengutronix.de>
>> [...]

>>> diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
>>> index 275c858..9ac5348 100644
>>> --- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
>>> +++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
>> [...]
>>> @@ -268,7 +268,8 @@ static struct ads7846_platform_data ads7846_config __initdata = {
>>>  	.keep_vref_on		= 1,
>>>  };
>>>
>>> -static struct spi_board_info eukrea_mbimx27_spi_board_info[] __initdata = {
>>> +static struct spi_board_info __maybe_unused
>>> +eukrea_mbimx27_spi_board_info[] __initdata = {

>>    I think the second line should be somewhat indented.

> I like it as it is.  There are no rules for that, no?

    Documentation/CodingStyle, chapter 2.

> Uwe

WBR, Sergei

  reply	other threads:[~2011-02-09 20:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 20:17 [PATCH] ARM: imx/eukrea_mbimx27: fix compile warnings about unused variables Uwe Kleine-König
2011-02-09 13:57 ` Sergei Shtylyov
2011-02-09 19:39   ` Uwe Kleine-König
2011-02-09 20:13     ` Sergei Shtylyov [this message]
2011-02-10 10:07       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D52F566.1070009@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.