From: Dan Rosenberg <drosenberg@vsecurity.com> To: aelder@sgi.com, xfs-masters@oss.sgi.com, xfs@oss.sgi.com Cc: linux-kernel@vger.kernel.org, stable@kernel.org, security@kernel.org Subject: [PATCH] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1 Date: Thu, 10 Feb 2011 09:25:04 -0500 [thread overview] Message-ID: <1297347904.13370.9.camel@dan> (raw) The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to xfs_fs_geometry() with a version number of 3. This code path does not fill in the logsunit member of the passed xfs_fsop_geom_t, leading to the leaking of four bytes of uninitialized stack data to potentially unprivileged callers. Since all other members are filled in all code paths and there are no padding bytes in this structure, it's safe to avoid an expensive memset() in favor of just clearing this one field. Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com> --- fs/xfs/xfs_fsops.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c index cec89dd..17c4785 100644 --- a/fs/xfs/xfs_fsops.c +++ b/fs/xfs/xfs_fsops.c @@ -102,6 +102,7 @@ xfs_fs_geometry( mp->m_sb.sb_logsectsize : BBSIZE; geo->rtsectsize = mp->m_sb.sb_blocksize; geo->dirblocksize = mp->m_dirblksize; + geo->logsunit = 0; } if (new_version >= 4) { geo->flags |=
WARNING: multiple messages have this Message-ID (diff)
From: Dan Rosenberg <drosenberg@vsecurity.com> To: aelder@sgi.com, xfs-masters@oss.sgi.com, xfs@oss.sgi.com Cc: security@kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org Subject: [PATCH] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1 Date: Thu, 10 Feb 2011 09:25:04 -0500 [thread overview] Message-ID: <1297347904.13370.9.camel@dan> (raw) The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to xfs_fs_geometry() with a version number of 3. This code path does not fill in the logsunit member of the passed xfs_fsop_geom_t, leading to the leaking of four bytes of uninitialized stack data to potentially unprivileged callers. Since all other members are filled in all code paths and there are no padding bytes in this structure, it's safe to avoid an expensive memset() in favor of just clearing this one field. Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com> --- fs/xfs/xfs_fsops.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c index cec89dd..17c4785 100644 --- a/fs/xfs/xfs_fsops.c +++ b/fs/xfs/xfs_fsops.c @@ -102,6 +102,7 @@ xfs_fs_geometry( mp->m_sb.sb_logsectsize : BBSIZE; geo->rtsectsize = mp->m_sb.sb_blocksize; geo->dirblocksize = mp->m_dirblksize; + geo->logsunit = 0; } if (new_version >= 4) { geo->flags |= _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2011-02-10 14:25 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-10 14:25 Dan Rosenberg [this message] 2011-02-10 14:25 ` [PATCH] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1 Dan Rosenberg 2011-02-14 8:41 ` [Security] " Eugene Teo 2011-02-14 8:41 ` Eugene Teo 2011-02-14 11:46 ` Dave Chinner 2011-02-14 11:46 ` Dave Chinner 2011-02-14 13:45 ` [PATCH v2] " Dan Rosenberg 2011-02-14 13:45 ` Dan Rosenberg 2011-02-14 23:39 ` Eugene Teo 2011-02-14 23:39 ` Eugene Teo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1297347904.13370.9.camel@dan \ --to=drosenberg@vsecurity.com \ --cc=aelder@sgi.com \ --cc=linux-kernel@vger.kernel.org \ --cc=security@kernel.org \ --cc=stable@kernel.org \ --cc=xfs-masters@oss.sgi.com \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.