* [PATCH net-next-2.6] ipv4: fix rcu lock imbalance in fib_select_default()
@ 2011-02-14 14:02 Eric Dumazet
2011-02-14 19:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2011-02-14 14:02 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Commit 0c838ff1ade7 (ipv4: Consolidate all default route selection
implementations.) forgot to remove one rcu_read_unlock() from
fib_select_default().
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/ipv4/fib_semantics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 146bd82..562f34c 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -1189,7 +1189,7 @@ void fib_select_default(struct fib_result *res)
fib_result_assign(res, last_resort);
tb->tb_default = last_idx;
out:
- rcu_read_unlock();
+ return;
}
#ifdef CONFIG_IP_ROUTE_MULTIPATH
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next-2.6] ipv4: fix rcu lock imbalance in fib_select_default()
2011-02-14 14:02 [PATCH net-next-2.6] ipv4: fix rcu lock imbalance in fib_select_default() Eric Dumazet
@ 2011-02-14 19:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-02-14 19:23 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Feb 2011 15:02:04 +0100
> Commit 0c838ff1ade7 (ipv4: Consolidate all default route selection
> implementations.) forgot to remove one rcu_read_unlock() from
> fib_select_default().
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-14 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-14 14:02 [PATCH net-next-2.6] ipv4: fix rcu lock imbalance in fib_select_default() Eric Dumazet
2011-02-14 19:23 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.