[PATCH]move double quotation marks so that keep MAINTAINERS consistent

[PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Harry Wei]

Hi us,
    When i see MAITAINERS, i find an inconsistent double-quotation-marks.
So i patch for it:) patcher like following.

Thanks.
Best Regards.
Harry Wei.


Signed-off-by: Harry Wei <harryxiyou@gmail.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index afb6f7c..95ac55c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -139,7 +139,7 @@ S:	Supported
 F:	drivers/scsi/3w-*
 
 53C700 AND 53C700-66 SCSI DRIVER
-M:	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
+M:	James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
 L:	linux-scsi@vger.kernel.org
 S:	Maintained
 F:	drivers/scsi/53c700*
-- 
1.7.0.4

Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Greg KH]

On Thu, Feb 10, 2011 at 10:51:35AM +0800, Harry Wei wrote:
> Hi us,
>     When i see MAITAINERS, i find an inconsistent double-quotation-marks.
> So i patch for it:) patcher like following.

The quotes are there to handle the '.' character which email clients
need.  If you have a question about a specific person's entry, why not
email them about it?  To not do so is a bit rude.

thanks,

greg k-h

Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Andrew Morton]

On Thu, 10 Feb 2011 10:51:35 +0800 Harry Wei <jiaweiwei.xiyou@gmail.com> wrote:

> Hi us,
>     When i see MAITAINERS, i find an inconsistent double-quotation-marks.
> So i patch for it:) patcher like following.
> 
> Thanks.
> Best Regards.
> Harry Wei.
> 
> 
> Signed-off-by: Harry Wei <harryxiyou@gmail.com>
> ---
>  MAINTAINERS |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index afb6f7c..95ac55c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -139,7 +139,7 @@ S:	Supported
>  F:	drivers/scsi/3w-*
>  
>  53C700 AND 53C700-66 SCSI DRIVER
> -M:	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> +M:	James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
>  L:	linux-scsi@vger.kernel.org
>  S:	Maintained
>  F:	drivers/scsi/53c700*

I suspect that some mail clients will explode if you provide them with
an unquoted string containing periods.  That would make copy-n-paste
rather a hassle.

Re: Fwd: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Harry Wei]

On Thu, Feb 10, 2011 at 11:10:16AM +0800, harryxiyou wrote:
> ---------- Forwarded message ----------
> From: Greg KH <greg@kroah.com>
> Date: 2011/2/10
> Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS
> consistent
> To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, joe@perches.com,
> davem@davemloft.net, rdunlap@xenotime.net
> 
> 
> On Thu, Feb 10, 2011 at 10:51:35AM +0800, Harry Wei wrote:
> > Hi us,
> >     When i see MAITAINERS, i find an inconsistent double-quotation-marks.
> > So i patch for it:) patcher like following.
> 
> The quotes are there to handle the '.' character which email clients
> need.  If you have a question about a specific person's entry, why not
> email them about it?  To not do so is a bit rude.
Hi greg, Andrew
	So sorry. I ignored it :(
	I will send a mail to James E. J. Bottomley for this matter. Then i will decide if we should delete this double-quotation-marks.

	Thanks.
	Best Regards.
	Harry Wei.

> 
> thanks,
> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> 
> -- 
> Best Regards.
> Harry Wei.
> Do what u like!

Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[David Miller]

From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 9 Feb 2011 19:06:31 -0800

> I suspect that some mail clients will explode if you provide them with
> an unquoted string containing periods.  That would make copy-n-paste
> rather a hassle.

It's not clients, it's servers.

SMTP rules state that characters such as "." cannot appear
unquoted in email headers.

vger.kernel.org rejects mail when this violation occurs.

Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Pavel Machek]

On Wed 2011-02-09 19:17:52, David Miller wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed, 9 Feb 2011 19:06:31 -0800
> 
> > I suspect that some mail clients will explode if you provide them with
> > an unquoted string containing periods.  That would make copy-n-paste
> > rather a hassle.
> 
> It's not clients, it's servers.
> 
> SMTP rules state that characters such as "." cannot appear
> unquoted in email headers.
> 
> vger.kernel.org rejects mail when this violation occurs.

Ok, but should not MUA do this quotation? Quick test shows that mutt does... 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Joe Perches]

On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> On Wed 2011-02-09 19:17:52, David Miller wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> > > I suspect that some mail clients will explode if you provide them with
> > > an unquoted string containing periods.  That would make copy-n-paste
> > > rather a hassle.
> > It's not clients, it's servers.
> > SMTP rules state that characters such as "." cannot appear
> > unquoted in email headers.
> > vger.kernel.org rejects mail when this violation occurs.
> Ok, but should not MUA do this quotation? Quick test shows that mutt does... 

My recollection is that the get_maintainer script
cannot parse M: lines with multiple entries with
periods without the quotes.

M:	First I. Last <fil@foo.bar>, Last.I.First <lif@foo.bar>

fails and

M:	"First I. Last" <fil@foo.bar>, "Last.I.First" <lif@foo.bar>

succeeds.

You are welcome to improve the parsing in that routine.

Re: Fwd: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Harry Wei]

On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> ---------- Forwarded message ----------
> From: Joe Perches <joe@perches.com>
> Date: 2011/2/20
> Subject: Re: [PATCH]move double quotation marks so that keep MAINTAINERS
> consistent
> To: Pavel Machek <pavel@ucw.cz>
> Cc: David Miller <davem@davemloft.net>, akpm@linux-foundation.org,
> jiaweiwei.xiyou@gmail.com, linux-kernel@vger.kernel.org, greg@kroah.com,
> rdunlap@xenotime.net
> 
> 
> On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > From: Andrew Morton <akpm@linux-foundation.org>
> > > > I suspect that some mail clients will explode if you provide them with
> > > > an unquoted string containing periods.  That would make copy-n-paste
> > > > rather a hassle.
> > > It's not clients, it's servers.
> > > SMTP rules state that characters such as "." cannot appear
> > > unquoted in email headers.
> > > vger.kernel.org rejects mail when this violation occurs.
> > Ok, but should not MUA do this quotation? Quick test shows that mutt
> does...
> 
> My recollection is that the get_maintainer script
> cannot parse M: lines with multiple entries with
> periods without the quotes.
> 
> M:      First I. Last <fil@foo.bar>, Last.I.First <lif@foo.bar>
> 
> fails and
> 
> M:      "First I. Last" <fil@foo.bar>, "Last.I.First" <lif@foo.bar>
> 
> succeeds.
> 
> You are welcome to improve the parsing in that routine.
Hi Joe,
   	In order to improve the parsing in that routine we should remove all the the double-quotation-marks in the MAINTAINERS ?  Maybe we have other better ways?  Tell me and i will patch for us.
	Like the Greg K-H said, we should firstly notify the maintainers who have the double-quotation-marks in their M:. Then we can make this patch :)
 
Thanks.
Best Regards.
Harry Wei.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> 
> -- 
> Best Regards.
> Harry Wei.
> Do what u like!

[PATCH] MAINTAINERS: Quote non-alphanumeric email addresses

[Joe Perches]

Add quotes around email address with periods and commas.

Signed-off-by: Joe Perches <joe@perches.com>
---
On Sun, 2011-02-20 at 10:48 +0800, Harry Wei wrote:
> On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> > From: Joe Perches <joe@perches.com>
> > On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > > From: Andrew Morton <akpm@linux-foundation.org>
> > > > > I suspect that some mail clients will explode if you provide them with
> > > > > an unquoted string containing periods.  That would make copy-n-paste
> > > > > rather a hassle.
> > > > It's not clients, it's servers.
> > > > SMTP rules state that characters such as "." cannot appear
> > > > unquoted in email headers.
> > > > vger.kernel.org rejects mail when this violation occurs.
> > > Ok, but should not MUA do this quotation? Quick test shows that mutt
> > does...
> > My recollection is that the get_maintainer script
> > cannot parse M: lines with multiple entries with
> > periods without the quotes.
> > M:      First I. Last <fil@foo.bar>, Last.I.First <lif@foo.bar>
> > fails and
> > M:      "First I. Last" <fil@foo.bar>, "Last.I.First" <lif@foo.bar>
> > succeeds.
> > You are welcome to improve the parsing in that routine.
> In order to improve the parsing in that routine we should remove all
> the the double-quotation-marks in the MAINTAINERS ?

No, that'd be wrong before improving parsing and
verifying that all currently used client/MUAs work
without quotes.

> Maybe we have other better ways?  Tell me and i will patch for us.

I think leaving the quotes is the right thing to do.

Quoting names that have non alphanumeric
characters before any open angle bracket '<'
is better than remove quotes.

 MAINTAINERS |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e45eabe..af586f8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1044,7 +1044,7 @@ L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 
 ARM/TETON BGA MACHINE SUPPORT
-M:	Mark F. Brown <mark.brown314@gmail.com>
+M:	"Mark F. Brown" <mark.brown314@gmail.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 
@@ -1448,7 +1448,7 @@ F:	drivers/mtd/devices/block2mtd.c
 
 BLUETOOTH DRIVERS
 M:	Marcel Holtmann <marcel@holtmann.org>
-M:	Gustavo F. Padovan <padovan@profusion.mobi>
+M:	"Gustavo F. Padovan" <padovan@profusion.mobi>
 L:	linux-bluetooth@vger.kernel.org
 W:	http://www.bluez.org/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
@@ -1457,7 +1457,7 @@ F:	drivers/bluetooth/
 
 BLUETOOTH SUBSYSTEM
 M:	Marcel Holtmann <marcel@holtmann.org>
-M:	Gustavo F. Padovan <padovan@profusion.mobi>
+M:	"Gustavo F. Padovan" <padovan@profusion.mobi>
 L:	linux-bluetooth@vger.kernel.org
 W:	http://www.bluez.org/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
@@ -2909,7 +2909,7 @@ F:	Documentation/blockdev/cpqarray.txt
 F:	drivers/block/cpqarray.*
 
 HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)
-M:	Stephen M. Cameron <scameron@beardog.cce.hp.com>
+M:	"Stephen M. Cameron" <scameron@beardog.cce.hp.com>
 L:	iss_storagedev@hp.com
 S:	Supported
 F:	Documentation/scsi/hpsa.txt
@@ -4197,7 +4197,7 @@ F:	Documentation/serial/moxa-smartio
 F:	drivers/char/mxser.*
 
 MSI LAPTOP SUPPORT
-M:	Lee, Chun-Yi <jlee@novell.com>
+M:	"Lee, Chun-Yi" <jlee@novell.com>
 L:	platform-driver-x86@vger.kernel.org
 S:	Maintained
 F:	drivers/platform/x86/msi-laptop.c

Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses

[Harry Wei]

On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> Add quotes around email address with periods and commas.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
  Acked-by: Harry Wei <harryxiyou@gmail.com>

  But i think you should also tell the maintainers 
  you add quotes for their M: in the MAINTAINERS.
> ---
> On Sun, 2011-02-20 at 10:48 +0800, Harry Wei wrote:
> > On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> > > From: Joe Perches <joe@perches.com>
> > > On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > > > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > > > From: Andrew Morton <akpm@linux-foundation.org>
> > > > > > I suspect that some mail clients will explode if you provide them with
> > > > > > an unquoted string containing periods.  That would make copy-n-paste
> > > > > > rather a hassle.
> > > > > It's not clients, it's servers.
> > > > > SMTP rules state that characters such as "." cannot appear
> > > > > unquoted in email headers.
> > > > > vger.kernel.org rejects mail when this violation occurs.
> > > > Ok, but should not MUA do this quotation? Quick test shows that mutt
> > > does...
> > > My recollection is that the get_maintainer script
> > > cannot parse M: lines with multiple entries with
> > > periods without the quotes.
> > > M:      First I. Last <fil@foo.bar>, Last.I.First <lif@foo.bar>
> > > fails and
> > > M:      "First I. Last" <fil@foo.bar>, "Last.I.First" <lif@foo.bar>
> > > succeeds.
> > > You are welcome to improve the parsing in that routine.
> > In order to improve the parsing in that routine we should remove all
> > the the double-quotation-marks in the MAINTAINERS ?
> 
> No, that'd be wrong before improving parsing and
> verifying that all currently used client/MUAs work
> without quotes.
> 
> > Maybe we have other better ways?  Tell me and i will patch for us.
> 
> I think leaving the quotes is the right thing to do.
> 
> Quoting names that have non alphanumeric
> characters before any open angle bracket '<'
> is better than remove quotes.
> 
>  MAINTAINERS |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e45eabe..af586f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1044,7 +1044,7 @@ L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  S:	Maintained
>  
>  ARM/TETON BGA MACHINE SUPPORT
> -M:	Mark F. Brown <mark.brown314@gmail.com>
> +M:	"Mark F. Brown" <mark.brown314@gmail.com>
>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  S:	Maintained
>  
> @@ -1448,7 +1448,7 @@ F:	drivers/mtd/devices/block2mtd.c
>  
>  BLUETOOTH DRIVERS
>  M:	Marcel Holtmann <marcel@holtmann.org>
> -M:	Gustavo F. Padovan <padovan@profusion.mobi>
> +M:	"Gustavo F. Padovan" <padovan@profusion.mobi>
>  L:	linux-bluetooth@vger.kernel.org
>  W:	http://www.bluez.org/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -1457,7 +1457,7 @@ F:	drivers/bluetooth/
>  
>  BLUETOOTH SUBSYSTEM
>  M:	Marcel Holtmann <marcel@holtmann.org>
> -M:	Gustavo F. Padovan <padovan@profusion.mobi>
> +M:	"Gustavo F. Padovan" <padovan@profusion.mobi>
>  L:	linux-bluetooth@vger.kernel.org
>  W:	http://www.bluez.org/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -2909,7 +2909,7 @@ F:	Documentation/blockdev/cpqarray.txt
>  F:	drivers/block/cpqarray.*
>  
>  HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)
> -M:	Stephen M. Cameron <scameron@beardog.cce.hp.com>
> +M:	"Stephen M. Cameron" <scameron@beardog.cce.hp.com>
>  L:	iss_storagedev@hp.com
>  S:	Supported
>  F:	Documentation/scsi/hpsa.txt
> @@ -4197,7 +4197,7 @@ F:	Documentation/serial/moxa-smartio
>  F:	drivers/char/mxser.*
>  
>  MSI LAPTOP SUPPORT
> -M:	Lee, Chun-Yi <jlee@novell.com>
> +M:	"Lee, Chun-Yi" <jlee@novell.com>
>  L:	platform-driver-x86@vger.kernel.org
>  S:	Maintained
>  F:	drivers/platform/x86/msi-laptop.c
> 
> 

Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses

[Harry Wei]

On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> Add quotes around email address with periods and commas.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> On Sun, 2011-02-20 at 10:48 +0800, Harry Wei wrote:
> > On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote:
> > > From: Joe Perches <joe@perches.com>
> > > On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > > > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > > > From: Andrew Morton <akpm@linux-foundation.org>
> > > > > > I suspect that some mail clients will explode if you provide them with
> > > > > > an unquoted string containing periods.  That would make copy-n-paste
> > > > > > rather a hassle.
> > > > > It's not clients, it's servers.
> > > > > SMTP rules state that characters such as "." cannot appear
> > > > > unquoted in email headers.
> > > > > vger.kernel.org rejects mail when this violation occurs.
> > > > Ok, but should not MUA do this quotation? Quick test shows that mutt
> > > does...
> > > My recollection is that the get_maintainer script
> > > cannot parse M: lines with multiple entries with
> > > periods without the quotes.
> > > M:      First I. Last <fil@foo.bar>, Last.I.First <lif@foo.bar>
> > > fails and
> > > M:      "First I. Last" <fil@foo.bar>, "Last.I.First" <lif@foo.bar>
> > > succeeds.
> > > You are welcome to improve the parsing in that routine.
> > In order to improve the parsing in that routine we should remove all
> > the the double-quotation-marks in the MAINTAINERS ?
> 
> No, that'd be wrong before improving parsing and
> verifying that all currently used client/MUAs work
> without quotes.
> 
> > Maybe we have other better ways?  Tell me and i will patch for us.
> 
> I think leaving the quotes is the right thing to do.
> 
> Quoting names that have non alphanumeric
> characters before any open angle bracket '<'
> is better than remove quotes.
Hmm, what about some other conditions except 
for periods and commas in maintainers' M:. 
Like following:

1> Character '-' in M:
CALGARY x86-64 IOMMU
Muli Ben-Yehuda <muli@il.ibm.com>

2> No name of the M:
M:      support@lsi.com  

3> Messy code in M:
M:      Benoît Cousson <b-cousson@ti.com>

Should we also patch for them?
Can client/MUAs work them well?

Thanks.
Best Regards.
Harry Wei.
> 
>  MAINTAINERS |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e45eabe..af586f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1044,7 +1044,7 @@ L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  S:	Maintained
>  
>  ARM/TETON BGA MACHINE SUPPORT
> -M:	Mark F. Brown <mark.brown314@gmail.com>
> +M:	"Mark F. Brown" <mark.brown314@gmail.com>
>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  S:	Maintained
>  
> @@ -1448,7 +1448,7 @@ F:	drivers/mtd/devices/block2mtd.c
>  
>  BLUETOOTH DRIVERS
>  M:	Marcel Holtmann <marcel@holtmann.org>
> -M:	Gustavo F. Padovan <padovan@profusion.mobi>
> +M:	"Gustavo F. Padovan" <padovan@profusion.mobi>
>  L:	linux-bluetooth@vger.kernel.org
>  W:	http://www.bluez.org/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -1457,7 +1457,7 @@ F:	drivers/bluetooth/
>  
>  BLUETOOTH SUBSYSTEM
>  M:	Marcel Holtmann <marcel@holtmann.org>
> -M:	Gustavo F. Padovan <padovan@profusion.mobi>
> +M:	"Gustavo F. Padovan" <padovan@profusion.mobi>
>  L:	linux-bluetooth@vger.kernel.org
>  W:	http://www.bluez.org/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git
> @@ -2909,7 +2909,7 @@ F:	Documentation/blockdev/cpqarray.txt
>  F:	drivers/block/cpqarray.*
>  
>  HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)
> -M:	Stephen M. Cameron <scameron@beardog.cce.hp.com>
> +M:	"Stephen M. Cameron" <scameron@beardog.cce.hp.com>
>  L:	iss_storagedev@hp.com
>  S:	Supported
>  F:	Documentation/scsi/hpsa.txt
> @@ -4197,7 +4197,7 @@ F:	Documentation/serial/moxa-smartio
>  F:	drivers/char/mxser.*
>  
>  MSI LAPTOP SUPPORT
> -M:	Lee, Chun-Yi <jlee@novell.com>
> +M:	"Lee, Chun-Yi" <jlee@novell.com>
>  L:	platform-driver-x86@vger.kernel.org
>  S:	Maintained
>  F:	drivers/platform/x86/msi-laptop.c
> 
> 

Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses

[Joe Perches]

On Sun, 2011-02-20 at 21:59 +0800, Harry Wei wrote:
> On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> > Add quotes around email address with periods and commas.
> Hmm, what about some other conditions except 
> for periods and commas in maintainers' M:. 
> Like following:
> 1> Character '-' in M:

Dashes are not an issue.

> 2> No name of the M:
> M:      support@lsi.com  

Names and angle brackets are optional.

> 3> Messy code in M:
> M:      Benoît Cousson <b-cousson@ti.com>

8 bit characters _might_ be an issue, but
no one has reported any problems yet.

I think you should read and understand rfc 2822
before continuing with this.

Utilities like git send-email and get_maintainer.pl
generally provide email address parsing for only a
subset of all valid address styles.

As these utilities are done mostly by regex, not
all valid email addresses are supported because the
regex validations get ridiculously complicated.

There are some "monster" regex classes that attempt
to support a greater range of valid email address
styles, but the pain of implementation generally
isn't worth it.

You're free to try to improve it of course, but I
think that modifications to the address styles
currently used in MAINTAINERS to remove "special"
address style handling isn't necessary.

Re: Fwd: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses

[Harry Wei]

On Mon, Feb 21, 2011 at 12:59:16PM +0800, jiaweiwei wrote:
> ---------- Forwarded message ----------
> From: Joe Perches <joe@perches.com>
> Date: 2011/2/21
> Subject: Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses
> To: Harry Wei <jiaweiwei.xiyou@gmail.com>
> Cc: davem@davemloft.net, akpm@linux-foundation.org,
> linux-kernel@vger.kernel.org, greg@kroah.com, rdunlap@xenotime.net,
> pavel@ucw.cz
> 
> 
> On Sun, 2011-02-20 at 21:59 +0800, Harry Wei wrote:
> > On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> > > Add quotes around email address with periods and commas.
> > Hmm, what about some other conditions except
> > for periods and commas in maintainers' M:.
> > Like following:
> > 1> Character '-' in M:
> 
> Dashes are not an issue.
Get it.
> 
> > 2> No name of the M:
> > M:      support@lsi.com
> 
> Names and angle brackets are optional.
Ok.
> 
> > 3> Messy code in M:
> > M:      Benoît Cousson <b-cousson@ti.com>
> 
> 8 bit characters _might_ be an issue, but
> no one has reported any problems yet.
Get it. 
> 
> I think you should read and understand rfc 2822
> before continuing with this.
Thanks, i will read it :)
> 
> Utilities like git send-email and get_maintainer.pl
> generally provide email address parsing for only a
> subset of all valid address styles.
> 
> As these utilities are done mostly by regex, not
> all valid email addresses are supported because the
> regex validations get ridiculously complicated.
> 
> There are some "monster" regex classes that attempt
> to support a greater range of valid email address
> styles, but the pain of implementation generally
> isn't worth it.
> 
> You're free to try to improve it of course, but I
> think that modifications to the address styles
> currently used in MAINTAINERS to remove "special"
> address style handling isn't necessary.
Get it, thanks.

Best Regards.
Harry Wei.
> 
> 
> 
> 
> -- 
>  do kernel

Re: [PATCH]move double quotation marks so that keep MAINTAINERS consistent

[Florian Mickler]

On Sat, 19 Feb 2011 13:59:50 -0800
Joe Perches <joe@perches.com> wrote:

> On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote:
> > On Wed 2011-02-09 19:17:52, David Miller wrote:
> > > From: Andrew Morton <akpm@linux-foundation.org>
> > > > I suspect that some mail clients will explode if you provide them with
> > > > an unquoted string containing periods.  That would make copy-n-paste
> > > > rather a hassle.
> > > It's not clients, it's servers.
> > > SMTP rules state that characters such as "." cannot appear
> > > unquoted in email headers.
> > > vger.kernel.org rejects mail when this violation occurs.
> > Ok, but should not MUA do this quotation? Quick test shows that mutt does... 
> 
> My recollection is that the get_maintainer script
> cannot parse M: lines with multiple entries with
> periods without the quotes.
> 
> M:	First I. Last <fil@foo.bar>, Last.I.First <lif@foo.bar>
> 
> fails and
> 
> M:	"First I. Last" <fil@foo.bar>, "Last.I.First" <lif@foo.bar>
> 
> succeeds.
> 
> You are welcome to improve the parsing in that routine.
> 

There are perl modules providing full rfc parsing of email addresses
(with all those weird cases nobody uses) ... but i doubt it's urgent,
especially as we can more or less control the input to get_maintainer.pl
by controlling the MAINTAINER file and the git version history ...