ALSA: hda - 4930g add internal lfe slider

ALSA: hda - 4930g add internal lfe slider

[Łukasz Wojniłowicz]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

Hello,
Lately I sent patch that switched lfe with side in mixer for
acer-aspire-4930g. Then I connected 5.1 speaker system and noticed that
lfe slider wasn't working and that old lfe slider worked. What I'm doing
now is:

- reverting old patch
- adding internal lfe slider
- removing side as it is superfluous (ALC888S-VC is 7.1 but in fact
laptop can only do 5.1 and it is so in drivers for MS Windows)

Cheers,
Łukasz


[-- Attachment #2: patch_realtek.patch --]
[-- Type: text/x-patch, Size: 1845 bytes --]

From: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>
Subject: ALSA: hda - 4930g add internal lfe slider

Signed-off-by: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>

--- patch_realtek.c	2011-02-22 08:21:56.000000000 +0100
+++ patch_realtek.c	2011-02-23 18:19:19.203076469 +0100
@@ -2295,13 +2295,13 @@
 	HDA_BIND_MUTE("Front Playback Switch", 0x0c, 2, HDA_INPUT),
 	HDA_CODEC_VOLUME("Surround Playback Volume", 0x0d, 0x0, HDA_OUTPUT),
 	HDA_BIND_MUTE("Surround Playback Switch", 0x0d, 2, HDA_INPUT),
-	HDA_CODEC_VOLUME_MONO("Center Playback Volume", 0x0f, 2, 0x0,
+	HDA_CODEC_VOLUME_MONO("Center Playback Volume", 0x0e, 1, 0x0,
 		HDA_OUTPUT),
-	HDA_BIND_MUTE_MONO("Center Playback Switch", 0x0f, 2, 2, HDA_INPUT),
-	HDA_CODEC_VOLUME_MONO("LFE Playback Volume", 0x0f, 1, 0x0, HDA_OUTPUT),
-	HDA_BIND_MUTE_MONO("LFE Playback Switch", 0x0f, 1, 2, HDA_INPUT),
-	HDA_CODEC_VOLUME("Side Playback Volume", 0x0e, 0x0, HDA_OUTPUT),
-	HDA_BIND_MUTE("Side Playback Switch", 0x0e, 2, HDA_INPUT),
+	HDA_BIND_MUTE_MONO("Center Playback Switch", 0x0e, 1, 2, HDA_INPUT),
+	HDA_CODEC_VOLUME_MONO("LFE Playback Volume", 0x0e, 2, 0x0, HDA_OUTPUT),
+	HDA_BIND_MUTE_MONO("LFE Playback Switch", 0x0e, 2, 2, HDA_INPUT),
+	HDA_CODEC_VOLUME_MONO("Internal LFE Playback Volume", 0x0f, 1, 0x0, HDA_OUTPUT),
+	HDA_BIND_MUTE_MONO("Internal LFE Playback Switch", 0x0f, 1, 2, HDA_INPUT),
 	HDA_CODEC_VOLUME("CD Playback Volume", 0x0b, 0x04, HDA_INPUT),
 	HDA_CODEC_MUTE("CD Playback Switch", 0x0b, 0x04, HDA_INPUT),
 	HDA_CODEC_VOLUME("Line Playback Volume", 0x0b, 0x02, HDA_INPUT),
@@ -2312,7 +2312,6 @@
 	{ } /* end */
 };
 
-
 static struct snd_kcontrol_new alc889_acer_aspire_8930g_mixer[] = {
 	HDA_CODEC_VOLUME("Front Playback Volume", 0x0c, 0x0, HDA_OUTPUT),
 	HDA_BIND_MUTE("Front Playback Switch", 0x0c, 2, HDA_INPUT),

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: ALSA: hda - 4930g add internal lfe slider

[Takashi Iwai]

At Wed, 23 Feb 2011 18:50:20 +0100,
Łukasz Wojniłowicz wrote:
> 
> Hello,
> Lately I sent patch that switched lfe with side in mixer for
> acer-aspire-4930g. Then I connected 5.1 speaker system and noticed that
> lfe slider wasn't working and that old lfe slider worked. What I'm doing
> now is:
> 
> - reverting old patch
> - adding internal lfe slider
> - removing side as it is superfluous (ALC888S-VC is 7.1 but in fact
> laptop can only do 5.1 and it is so in drivers for MS Windows)
> 
> Cheers,
> Łukasz

Thanks, applied now.


Takashi

> 
> [2 patch_realtek.patch <text/x-patch; UTF-8 (8bit)>]
> From: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>
> Subject: ALSA: hda - 4930g add internal lfe slider
> 
> Signed-off-by: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>
> 
> --- patch_realtek.c	2011-02-22 08:21:56.000000000 +0100
> +++ patch_realtek.c	2011-02-23 18:19:19.203076469 +0100
> @@ -2295,13 +2295,13 @@
>  	HDA_BIND_MUTE("Front Playback Switch", 0x0c, 2, HDA_INPUT),
>  	HDA_CODEC_VOLUME("Surround Playback Volume", 0x0d, 0x0, HDA_OUTPUT),
>  	HDA_BIND_MUTE("Surround Playback Switch", 0x0d, 2, HDA_INPUT),
> -	HDA_CODEC_VOLUME_MONO("Center Playback Volume", 0x0f, 2, 0x0,
> +	HDA_CODEC_VOLUME_MONO("Center Playback Volume", 0x0e, 1, 0x0,
>  		HDA_OUTPUT),
> -	HDA_BIND_MUTE_MONO("Center Playback Switch", 0x0f, 2, 2, HDA_INPUT),
> -	HDA_CODEC_VOLUME_MONO("LFE Playback Volume", 0x0f, 1, 0x0, HDA_OUTPUT),
> -	HDA_BIND_MUTE_MONO("LFE Playback Switch", 0x0f, 1, 2, HDA_INPUT),
> -	HDA_CODEC_VOLUME("Side Playback Volume", 0x0e, 0x0, HDA_OUTPUT),
> -	HDA_BIND_MUTE("Side Playback Switch", 0x0e, 2, HDA_INPUT),
> +	HDA_BIND_MUTE_MONO("Center Playback Switch", 0x0e, 1, 2, HDA_INPUT),
> +	HDA_CODEC_VOLUME_MONO("LFE Playback Volume", 0x0e, 2, 0x0, HDA_OUTPUT),
> +	HDA_BIND_MUTE_MONO("LFE Playback Switch", 0x0e, 2, 2, HDA_INPUT),
> +	HDA_CODEC_VOLUME_MONO("Internal LFE Playback Volume", 0x0f, 1, 0x0, HDA_OUTPUT),
> +	HDA_BIND_MUTE_MONO("Internal LFE Playback Switch", 0x0f, 1, 2, HDA_INPUT),
>  	HDA_CODEC_VOLUME("CD Playback Volume", 0x0b, 0x04, HDA_INPUT),
>  	HDA_CODEC_MUTE("CD Playback Switch", 0x0b, 0x04, HDA_INPUT),
>  	HDA_CODEC_VOLUME("Line Playback Volume", 0x0b, 0x02, HDA_INPUT),
> @@ -2312,7 +2312,6 @@
>  	{ } /* end */
>  };
>  
> -
>  static struct snd_kcontrol_new alc889_acer_aspire_8930g_mixer[] = {
>  	HDA_CODEC_VOLUME("Front Playback Volume", 0x0c, 0x0, HDA_OUTPUT),
>  	HDA_BIND_MUTE("Front Playback Switch", 0x0c, 2, HDA_INPUT),
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel