From: Bastien Nocera <hadess@hadess.net> To: Antonio Ospite <ospite@studenti.unina.it> Cc: linux-bluetooth@vger.kernel.org, linux-input@vger.kernel.org, Jim Paris <jim@jtan.com>, Ranulf Doswell <ralf@ranulf.net>, "Pascal A . Brisset" <pascal44973@pabr.org>, Marcin Tolysz <tolysz@gmail.com>, Christian Birchinger <joker@netswarm.net>, Filipe Lopes <falktx@gmail.com>, Alan Ott <alan@signal11.us>, Mikko Virkkila <virkkila@kapsi.fi> Subject: Re: [PATCH v2 0/3] Another try for the Sixaxis plugin Date: Fri, 25 Feb 2011 12:34:02 +0000 [thread overview] Message-ID: <1298637244.10364.19.camel@novo.hadess.net> (raw) In-Reply-To: <1298628292-8842-1-git-send-email-ospite@studenti.unina.it> On Fri, 2011-02-25 at 11:04 +0100, Antonio Ospite wrote: > Hi, > > this is another attempt to get the sixaxis plugin merged upstream in > bluez, now cable pairing is done without libusb, which is good because > the hid driver does not need to be detached anymore. Good stuff. > The work is based on patches by Bastian Nocera, so its SOB line comes > first on the third patch, even though many parts have been totally > reimplemented. More comments on the patch itself. > > Bastien, I took the liberty to impersonate you in the second patch about > re-adding manager_get_default_adapter(), because the change was taken > out from your bluez rpm package. I hope this is OK. Both fine by me. > I was wondering if it was possible to have the equivalent of this plugin > as a separate daemon doing the association part with bluez over dbus, > instead of having it builtin (I do not know the bluez dbus interface at > all), and if there were any major drawbacks with that compared to the > builtin plugin. What are your opinions on that? This was already discussed, and I even created a patch to allow outside pairing. I don't think there's much of a point doing this outside of bluetoothd though, and Marcel preferred the pairing to be done within bluetoothd. > Anyhow, > > HOWTO test it: > - Get a kernel supporting HIDIOCSFEATURE and HIDIOCGFEATURE: linux-next > should have that, or Jiki Kosina's hidraw-feature branch: > http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=shortlog;h=refs/heads/hidraw-feature > - Build it and install it with its linux-libc-dev package ("make > deb-pkg" on recent kernels builds that already). > - Apply the patches in this series and configure bluez, the ioctl > above should be detected automatically and the plugin enabled. > - If there is any problem, try backing up and cleaning up > /var/lib/bluetooth/ > > TODO before merging: > - Check the routine about bluetooth association. Also, is it strictly > necessary to grant manually the first connection? The line setting the device trust should be enough to not have to manually grant the first connection. You might want to double-check what changes between the state of /var/lib/bluetooth after cable pairing and before connecting for the first time. > - Add the actual official version of linux-libc-dev in which the > hidraw ioctl will be merged (now it is just 2.6.3x as a > placeholder). > - Check the last comment from Marcel about the timeout in > http://marc.info/?l=linux-bluetooth&m=125525415718147&w=2 Could you > comment on the third patch about that, please? The timeout was to avoid reading data while udev was probing the device. This might not be necessary anymore. > - When the controller is connected via USB after it is working over BT > it is seen as a second controller and the second LED is turned on, > should we force BT disconnection on USB connection? If we can assert that the device is the same one, yes, I think we should. > - Test with multiple controllers, and/or multiple BT adapters, which I > can't do right now. > - Remove the XXX comment about the lowercase hex bdaddr format. > > > FUTURE plans: > - Add support for battery status report Where is the battery level exported currently? > - Add support for Playstation Move (I don't have the hardware, tho), > Pascal? The PS3 add-on keyboard, and the PS3 headset both use cable pairing. I have them around, but was unable to get them to pair. Cheers
WARNING: multiple messages have this Message-ID (diff)
From: Bastien Nocera <hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org> To: Antonio Ospite <ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org> Cc: linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jim Paris <jim-XrPbb/hENzg@public.gmane.org>, Ranulf Doswell <ralf-fD3LYpizeBGsTnJN9+BGXg@public.gmane.org>, "Pascal A . Brisset" <pascal44973-dXI0m6hRz7k@public.gmane.org>, Marcin Tolysz <tolysz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Christian Birchinger <joker-vQrvfurPyUjk1uMJSBkQmQ@public.gmane.org>, Filipe Lopes <falktx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>, Mikko Virkkila <virkkila-/1wQRMveznE@public.gmane.org> Subject: Re: [PATCH v2 0/3] Another try for the Sixaxis plugin Date: Fri, 25 Feb 2011 12:34:02 +0000 [thread overview] Message-ID: <1298637244.10364.19.camel@novo.hadess.net> (raw) In-Reply-To: <1298628292-8842-1-git-send-email-ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org> On Fri, 2011-02-25 at 11:04 +0100, Antonio Ospite wrote: > Hi, > > this is another attempt to get the sixaxis plugin merged upstream in > bluez, now cable pairing is done without libusb, which is good because > the hid driver does not need to be detached anymore. Good stuff. > The work is based on patches by Bastian Nocera, so its SOB line comes > first on the third patch, even though many parts have been totally > reimplemented. More comments on the patch itself. > > Bastien, I took the liberty to impersonate you in the second patch about > re-adding manager_get_default_adapter(), because the change was taken > out from your bluez rpm package. I hope this is OK. Both fine by me. > I was wondering if it was possible to have the equivalent of this plugin > as a separate daemon doing the association part with bluez over dbus, > instead of having it builtin (I do not know the bluez dbus interface at > all), and if there were any major drawbacks with that compared to the > builtin plugin. What are your opinions on that? This was already discussed, and I even created a patch to allow outside pairing. I don't think there's much of a point doing this outside of bluetoothd though, and Marcel preferred the pairing to be done within bluetoothd. > Anyhow, > > HOWTO test it: > - Get a kernel supporting HIDIOCSFEATURE and HIDIOCGFEATURE: linux-next > should have that, or Jiki Kosina's hidraw-feature branch: > http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=shortlog;h=refs/heads/hidraw-feature > - Build it and install it with its linux-libc-dev package ("make > deb-pkg" on recent kernels builds that already). > - Apply the patches in this series and configure bluez, the ioctl > above should be detected automatically and the plugin enabled. > - If there is any problem, try backing up and cleaning up > /var/lib/bluetooth/ > > TODO before merging: > - Check the routine about bluetooth association. Also, is it strictly > necessary to grant manually the first connection? The line setting the device trust should be enough to not have to manually grant the first connection. You might want to double-check what changes between the state of /var/lib/bluetooth after cable pairing and before connecting for the first time. > - Add the actual official version of linux-libc-dev in which the > hidraw ioctl will be merged (now it is just 2.6.3x as a > placeholder). > - Check the last comment from Marcel about the timeout in > http://marc.info/?l=linux-bluetooth&m=125525415718147&w=2 Could you > comment on the third patch about that, please? The timeout was to avoid reading data while udev was probing the device. This might not be necessary anymore. > - When the controller is connected via USB after it is working over BT > it is seen as a second controller and the second LED is turned on, > should we force BT disconnection on USB connection? If we can assert that the device is the same one, yes, I think we should. > - Test with multiple controllers, and/or multiple BT adapters, which I > can't do right now. > - Remove the XXX comment about the lowercase hex bdaddr format. > > > FUTURE plans: > - Add support for battery status report Where is the battery level exported currently? > - Add support for Playstation Move (I don't have the hardware, tho), > Pascal? The PS3 add-on keyboard, and the PS3 headset both use cable pairing. I have them around, but was unable to get them to pair. Cheers
next prev parent reply other threads:[~2011-02-25 12:34 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-25 10:04 [PATCH v2 0/3] Another try for the Sixaxis plugin Antonio Ospite 2011-02-25 10:04 ` [PATCH v2 1/3] Remove input/sixpair.c Antonio Ospite 2011-02-25 10:04 ` Antonio Ospite 2011-02-25 10:04 ` [PATCH v2 2/3] Re-add manager_get_default_adapter() Antonio Ospite 2011-02-25 10:04 ` [PATCH v2 3/3] Add sixaxis plugin: USB pairing and LEDs settings Antonio Ospite 2011-02-25 10:04 ` Antonio Ospite 2011-05-06 1:14 ` Bastien Nocera 2011-05-06 1:14 ` Bastien Nocera 2011-05-06 8:45 ` Antonio Ospite 2011-05-06 8:45 ` Antonio Ospite 2011-05-06 23:14 ` Antonio Ospite 2011-05-06 23:14 ` Antonio Ospite 2011-05-07 16:57 ` Bastien Nocera 2011-05-07 16:57 ` Bastien Nocera 2011-06-03 11:59 ` Antonio Ospite 2011-06-03 15:25 ` Bastien Nocera 2011-06-03 15:25 ` Bastien Nocera 2011-06-03 15:56 ` simon 2011-06-08 9:20 ` Antonio Ospite 2011-02-25 12:34 ` Bastien Nocera [this message] 2011-02-25 12:34 ` [PATCH v2 0/3] Another try for the Sixaxis plugin Bastien Nocera 2011-03-24 17:32 ` Antonio Ospite 2011-03-25 15:31 ` Jim Paris 2011-03-25 16:27 ` Antonio Ospite 2011-02-25 14:11 ` pascal44973 2011-02-25 15:49 ` Simon Kenyon 2011-02-25 15:49 ` Simon Kenyon 2011-02-25 16:02 ` Bastien Nocera 2011-02-25 16:02 ` Bastien Nocera 2011-04-30 11:31 ` Joakim Plate
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1298637244.10364.19.camel@novo.hadess.net \ --to=hadess@hadess.net \ --cc=alan@signal11.us \ --cc=falktx@gmail.com \ --cc=jim@jtan.com \ --cc=joker@netswarm.net \ --cc=linux-bluetooth@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=ospite@studenti.unina.it \ --cc=pascal44973@pabr.org \ --cc=ralf@ranulf.net \ --cc=tolysz@gmail.com \ --cc=virkkila@kapsi.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.