All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martin <javier.martin@vista-silicon.com>
To: alsa-devel@alsa-project.org
Cc: s.hauer@pengutronix.de, broonie@opensource.wolfsonmicro.com,
	b32542@freescale.com, linux-arm-kernel@lists.infradead.org,
	Javier Martin <javier.martin@vista-silicon.com>
Subject: [PATCH v2 2/4] ASoC: Fix burstsize and DSP_B format problems in imx-ssi.
Date: Tue,  1 Mar 2011 15:02:06 +0100	[thread overview]
Message-ID: <1298988128-11520-3-git-send-email-javier.martin@vista-silicon.com> (raw)
In-Reply-To: <1298988128-11520-1-git-send-email-javier.martin@vista-silicon.com>

When choosing IMX_DMA flag, burtsizes are set to its default
value (0) which leads to driver malfunction. Change them to 4.

DSP_B interface needs additional flag to match DSP_B formats
as described in several codecs as wm8741 and aic3205.

Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
---
 sound/soc/imx/imx-ssi.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/sound/soc/imx/imx-ssi.c b/sound/soc/imx/imx-ssi.c
index 390b6ff..971d3db 100644
--- a/sound/soc/imx/imx-ssi.c
+++ b/sound/soc/imx/imx-ssi.c
@@ -108,7 +108,7 @@ static int imx_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
 		break;
 	case SND_SOC_DAIFMT_DSP_B:
 		/* data on rising edge of bclk, frame high with data */
-		strcr |= SSI_STCR_TFSL;
+		strcr |= SSI_STCR_TFSL | SSI_STCR_TXBIT0;
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
 		/* data on rising edge of bclk, frame high 1clk before data */
@@ -656,6 +656,9 @@ static int imx_ssi_probe(struct platform_device *pdev)
 	ssi->dma_params_rx.dma_addr = res->start + SSI_SRX0;
 	ssi->dma_params_tx.dma_addr = res->start + SSI_STX0;
 
+	ssi->dma_params_tx.burstsize = 4;
+	ssi->dma_params_rx.burstsize = 4;
+
 	res = platform_get_resource_byname(pdev, IORESOURCE_DMA, "tx0");
 	if (res)
 		ssi->dma_params_tx.dma = res->start;
-- 
1.7.0.4

WARNING: multiple messages have this Message-ID (diff)
From: javier.martin@vista-silicon.com (Javier Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] ASoC: Fix burstsize and DSP_B format problems in imx-ssi.
Date: Tue,  1 Mar 2011 15:02:06 +0100	[thread overview]
Message-ID: <1298988128-11520-3-git-send-email-javier.martin@vista-silicon.com> (raw)
In-Reply-To: <1298988128-11520-1-git-send-email-javier.martin@vista-silicon.com>

When choosing IMX_DMA flag, burtsizes are set to its default
value (0) which leads to driver malfunction. Change them to 4.

DSP_B interface needs additional flag to match DSP_B formats
as described in several codecs as wm8741 and aic3205.

Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
---
 sound/soc/imx/imx-ssi.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/sound/soc/imx/imx-ssi.c b/sound/soc/imx/imx-ssi.c
index 390b6ff..971d3db 100644
--- a/sound/soc/imx/imx-ssi.c
+++ b/sound/soc/imx/imx-ssi.c
@@ -108,7 +108,7 @@ static int imx_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
 		break;
 	case SND_SOC_DAIFMT_DSP_B:
 		/* data on rising edge of bclk, frame high with data */
-		strcr |= SSI_STCR_TFSL;
+		strcr |= SSI_STCR_TFSL | SSI_STCR_TXBIT0;
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
 		/* data on rising edge of bclk, frame high 1clk before data */
@@ -656,6 +656,9 @@ static int imx_ssi_probe(struct platform_device *pdev)
 	ssi->dma_params_rx.dma_addr = res->start + SSI_SRX0;
 	ssi->dma_params_tx.dma_addr = res->start + SSI_STX0;
 
+	ssi->dma_params_tx.burstsize = 4;
+	ssi->dma_params_rx.burstsize = 4;
+
 	res = platform_get_resource_byname(pdev, IORESOURCE_DMA, "tx0");
 	if (res)
 		ssi->dma_params_tx.dma = res->start;
-- 
1.7.0.4

  parent reply	other threads:[~2011-03-01 14:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 14:02 (no subject) Javier Martin
2011-03-01 14:02 ` No subject Javier Martin
2011-03-01 14:02 ` [PATCH v2 1/4] ASoC: Add TI tlv320aic32x4 codec support Javier Martin
2011-03-01 14:02   ` Javier Martin
2011-03-01 14:22   ` Mark Brown
2011-03-01 14:22     ` Mark Brown
2011-03-01 14:36     ` javier Martin
2011-03-01 14:36       ` javier Martin
2011-03-01 14:43       ` Mark Brown
2011-03-01 14:43         ` Mark Brown
2011-03-01 14:02 ` Javier Martin [this message]
2011-03-01 14:02   ` [PATCH v2 2/4] ASoC: Fix burstsize and DSP_B format problems in imx-ssi Javier Martin
2011-03-01 20:59   ` Liam Girdwood
2011-03-01 20:59     ` Liam Girdwood
2011-03-01 23:31   ` Mark Brown
2011-03-01 23:31     ` Mark Brown
2011-03-01 14:02 ` [PATCH v2 3/4] ASoC: Add machine driver for Visstrim_M10 board Javier Martin
2011-03-01 14:02   ` Javier Martin
2011-03-01 14:02 ` [PATCH v2 4/4] ARM: Add SSI and aic3204 code to Visstrim_M10 boards Javier Martin
2011-03-01 14:02   ` Javier Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298988128-11520-3-git-send-email-javier.martin@vista-silicon.com \
    --to=javier.martin@vista-silicon.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b32542@freescale.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.