r8169 disable ASPM patch

r8169 disable ASPM patch

[David Miller]

What is the status of Stanislaw Gruszka's "disable ASPM" r8169
patch?

	http://patchwork.ozlabs.org/patch/83961/

Is it waiting for your testing?  Is it waiting for feedback from
Hayes?

Is there going to be a MAINTAINERS patch that adds Hayes?  If so
what is stalling that?

Thanks.

Re: r8169 disable ASPM patch

[Francois Romieu]

(Hayes added to the Cc:)

David Miller <davem@davemloft.net> :
[...]
> What is the status of Stanislaw Gruszka's "disable ASPM" r8169
> patch?
> 
> 	http://patchwork.ozlabs.org/patch/83961/
> 
> Is it waiting for your testing ?

No.

I can test it against regression but I do not have the technical
knowledge to tell if it is right or not.

I have read (again) the PR as well as its sibling and there is little
evidence for me that the patch is 1) needed 2) better than the global
pcie_aspm switch. Either Realtek's in-house knowledge helps making
a technical decision or it is a policy-guided choice.

> Is it waiting for feedback from Hayes?

Yes.

Something like :
[ ] Ack. So far there is no way to handle ASPM reliably on the 816x
[ ] Not optimal but it is ok as an interim fix. For instance :
    - if some 816x (8168 ? 810{2, 3} ?) are known broken while others are not
    - it can be mitigated but the fix is not available yet
    - needs more tester / vendor work
    - etc.
[ ] Nak. The adequate fix is ...

> Is there going to be a MAINTAINERS patch that adds Hayes?  If so
> what is stalling that?

Realtek nic team asked me privately (end 2010) in rather general terms if
they could maintain the r8169 kernel driver. I have given some relevant
pointers for kernel code maintenance. Realtek did its housework.

I have stated publicly that I'll ack such a patch if Hayes wants to
add himself. Hayes was Cced. Either Hayes sends a patch or a plain
"please do it".

-- 
Ueimor

RE: r8169 disable ASPM patch

[hayeswang]

Sorry for my late response. 

> -----Original Message-----
> From: Francois Romieu [mailto:romieu@fr.zoreil.com]
> Sent: Thursday, March 03, 2011 5:45 PM
> To: David Miller
> Cc: netdev@vger.kernel.org; Hayeswang; sgruszka@redhat.com
> Subject: Re: r8169 disable ASPM patch
> 
> (Hayes added to the Cc:)
> 
> David Miller <davem@davemloft.net> :
> [...]
> > What is the status of Stanislaw Gruszka's "disable ASPM" 
> r8169 patch?
> > 
> > 	http://patchwork.ozlabs.org/patch/83961/
> > 
> > Is it waiting for your testing ?
> 
> No.
> 
> I can test it against regression but I do not have the technical 
> knowledge to tell if it is right or not.
> 
> I have read (again) the PR as well as its sibling and there is little 
> evidence for me that the patch is 1) needed 2) better than the global 
> pcie_aspm switch. Either Realtek's in-house knowledge helps making a 
> technical decision or it is a policy-guided choice.
> 
> > Is it waiting for feedback from Hayes?
> 
> Yes.
> 

Our hardware engineer says that it has an issue indeed for 8111B (that is, rev
01) when the aspm is enabled. For the other chips, the aspm would affect the
performance. We suggest to disable for stablity.

> Something like :
> [ ] Ack. So far there is no way to handle ASPM reliably on the 816x [ 
> ]  Not optimal but it is ok as an interim fix. For instance :
>     - if some 816x (8168 ? 810{2, 3} ?) are known broken while others 
> are not
>     - it can be mitigated but the fix is not available yet
>     - needs more tester / vendor work
>     - etc.
> [ ] Nak. The adequate fix is ...
> 
> > Is there going to be a MAINTAINERS patch that adds Hayes?  
> If so what
> > is stalling that?

Realtek would continue handling the kernel. However, the person may be different
for different period. Therefore, I think keeping the current mode is better.

> 
> Realtek nic team asked me privately (end 2010) in rather 
> general terms if they could maintain the r8169 kernel driver. 
> I have given some relevant pointers for kernel code 
> maintenance. Realtek did its housework.
> 
> I have stated publicly that I'll ack such a patch if Hayes 
> wants to add himself. Hayes was Cced. Either Hayes sends a 
> patch or a plain "please do it".
> 

 
Best Regards,
Hayes

RE: r8169 disable ASPM patch

[Ben Hutchings]

On Thu, 2011-03-03 at 19:35 +0800, hayeswang wrote:
[...]
> > > Is there going to be a MAINTAINERS patch that adds Hayes?  If so what
> > > is stalling that?
> 
> Realtek would continue handling the kernel. However, the person may be different
> for different period. Therefore, I think keeping the current mode is better.
[...]

Perhaps you could add a contact alias address, like our
linux-net-drivers@solarflare.com.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: r8169 disable ASPM patch

[David Miller]

From: hayeswang <hayeswang@realtek.com>
Date: Thu, 3 Mar 2011 19:35:11 +0800

> Our hardware engineer says that it has an issue indeed for 8111B (that is, rev
> 01) when the aspm is enabled. For the other chips, the aspm would affect the
> performance. We suggest to disable for stablity.

Ok, I will apply Stanislaw's patch, thanks.

RE: r8169 disable ASPM patch

[hayeswang]

> -----Original Message-----
> From: Ben Hutchings [mailto:bhutchings@solarflare.com] 
> Sent: Thursday, March 03, 2011 9:48 PM
> To: Hayeswang
> Cc: 'Francois Romieu'; 'David Miller'; 
> netdev@vger.kernel.org; sgruszka@redhat.com
> Subject: RE: r8169 disable ASPM patch
> 
> On Thu, 2011-03-03 at 19:35 +0800, hayeswang wrote:
> [...]
> > > > Is there going to be a MAINTAINERS patch that adds 
> Hayes?  If so 
> > > > what is stalling that?
> > 
> > Realtek would continue handling the kernel. However, the 
> person may be 
> > different for different period. Therefore, I think keeping 
> the current mode is better.
> [...]
> 
> Perhaps you could add a contact alias address, like our 
> linux-net-drivers@solarflare.com.
> 

Thanks for your suggestion. I would ask my leader and IT.
 
Best Regards,
Hayes