[Power-supply]: Error handling in max17042_battery.c

[Power-supply]: Error handling in max17042_battery.c

[Pallala, Ramakrishna]

Hi All,

I am working on the I2C based max17042 fuel gauge driver
Which is drivers/power/max17042_battery.c

In max17042_get_property(...), the values returned by
Max17042_read_reg are directly assigned to the variables,
even if the read results in an error. Shouldn't we check
for the 'correctness' of the returned values and then
assign them ? Can I submit a patch to change this ?

Or Is this done intentionally ?

Thanks,
Ram

RE: [Power-supply]: Error handling in max17042_battery.c

[Pallala, Ramakrishna]

> Hi All,
> 
> I am working on the I2C based max17042 fuel gauge driver
> Which is drivers/power/max17042_battery.c
> 
> In max17042_get_property(...), the values returned by
> Max17042_read_reg are directly assigned to the variables,
> even if the read results in an error. Shouldn't we check
> for the 'correctness' of the returned values and then
> assign them ? Can I submit a patch to change this ?
> 
> Or Is this done intentionally ?

Any inputs on this?

Thanks,
Ram

Re: [Power-supply]: Error handling in max17042_battery.c

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1071 bytes --]

Sender : Pallala, Ramakrishna<ramakrishna.pallala@intel.com> Date : 2011-08-26 14:46 (GMT+09:00)
> Hi All,
> 
> I am working on the I2C based max17042 fuel gauge driver
> Which is drivers/power/max17042_battery.c
> 
> In max17042_get_property(...), the values returned by
> Max17042_read_reg are directly assigned to the variables,
> even if the read results in an error. Shouldn't we check
> for the 'correctness' of the returned values and then
> assign them ? Can I submit a patch to change this ?
> 
> Or Is this done intentionally ?
> 
> Thanks,
> Ram
> 

Hello,

I did not ignore and return the error values from max17042_read_reg() intentionally, I've just missed them somehow (maybe was too lazy that day?). 

Handling errors from max17042_read_reg() at the side of max17042_get_property() is a feature missing. And, I'd be much appreciated if you'd send the patch you've mentioned.

Thank you,
MyungJooÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥