From: Jonathan Cameron <jic23@kernel.org> To: Rob Herring <robh@kernel.org>, Fabrice Gasnier <fabrice.gasnier@st.com> Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net, benjamin.gaignard@linaro.org, benjamin.gaignard@st.com, linus.walleij@linaro.org Subject: Re: [PATCH v3 1/6] dt-bindings: iio: introduce trigger providers, consumers Date: Sun, 5 Mar 2017 12:13:36 +0000 [thread overview] Message-ID: <12a6a2f8-9ff6-a4f0-c9a2-c7de037019ef@kernel.org> (raw) In-Reply-To: <948e5b96-7a8f-406d-6d03-d129d1b2ce54@kernel.org> On 05/03/17 11:43, Jonathan Cameron wrote: > On 03/03/17 06:21, Rob Herring wrote: >> On Tue, Feb 28, 2017 at 05:51:14PM +0100, Fabrice Gasnier wrote: >>> Document iio provider and consumer bindings. >>> >>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> >>> --- >>> .../devicetree/bindings/iio/iio-bindings.txt | 38 ++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iio/iio-bindings.txt b/Documentation/devicetree/bindings/iio/iio-bindings.txt >>> index 68d6f8c..01765e9 100644 >>> --- a/Documentation/devicetree/bindings/iio/iio-bindings.txt >>> +++ b/Documentation/devicetree/bindings/iio/iio-bindings.txt >>> @@ -95,3 +95,41 @@ vdd channel is connected to output 0 of the &ref device. >>> io-channels = <&adc 10>, <&adc 11>; >>> io-channel-names = "adc1", "adc2"; >>> }; >>> + >>> +==IIO trigger providers== >>> +Sources of IIO triggers can be represented by any node in the device >>> +tree. Those nodes are designated as IIO trigger providers. IIO trigger >>> +consumer uses a phandle and an IIO trigger specifier to connect to an >>> +IIO trigger provider. >>> +An IIO trigger specifier is an array of one or more cells identifying >>> +the IIO trigger output on a device. The length of an IIO trigger >>> +specifier is defined by the value of a #io-trigger-cells property in >>> +the IIO trigger provider node. >>> + >>> +Required properties: >>> +#io-trigger-cells: >>> + Number of cells in an IIO trigger specifier; Typically >>> + 0 for nodes with a simple IIO trigger output. >>> + >>> +Example: >>> + trig0: interrupt-trigger0 { >>> + #io-trigger-cells = <0>; >>> + compatible = "interrupt-trigger"; >>> + interrupts = <11 0>; >>> + interrupt-parent = <&gpioa>; >>> + } >>> + >>> +==IIO trigger consumers== >>> +Required properties: >>> +- io-triggers: List of phandle representing the IIO trigger specifier. >>> + >>> +Optional properties: >>> +- io-trigger-names : >>> + List of IIO trigger name strings that matches elements >>> + in 'io-triggers' list property. >>> + >>> +Example: >>> + some_trigger_consumer { >>> + io-triggers = <&trig0>; >>> + io-trigger-names = "mytrig"; >>> + } >> >> I have some reservations about this. We could just as easily add the >> interrupt directly to the consumer node and use "trigger" for a standard >> interrupt name. So the question is whether this extra level of >> indirection is needed? > > First thing to note here, is that Fabrice's use of the generic interrupt > trigger is an extremely 'unusual' one! Normal use case is that we have > a random gpio pin providing interrupts to driver triggering on random > devices - there need be no association between the two whatsoever. > So what we are doing here is 'allowing' an interrupt to provide a trigger. > It's not necessarily the one going to be used by any particular device > driver. The decision of which trigger to use is definitely one for > userspace, not something that should be configured in to the device tree. > > For this particular case you could in theory just do it by using an interrupt > as you describe. Ultimately though we should be able to play more complex > games with this device and having it able to handle any trigger - which > includes those not using the direct hardware route. It'll be up to the > driver to figure out when it can use the fast method and when it can't. > > Conversely, even when we are using this hardware route to drive the > triggering it should be possible to hang off a device to be triggered > by the interrupt via the kernel rather than directly. > > So from a device tree point of view we are just describing the fact that > there is a pin, which may be used to trigger something. What that something > is, is a question for userspace not the device tree. > Ah, I'm half asleep this morning. Clearly there is a more general follow up question. If we are arguing these are generic, why are we setting up the mapping in device tree? My gut feeling is we shouldn't be. So I think we need the first chunk above but the latter part should be a job for userspace not the devicetree. Jonathan > Jonathan >> >> Rob >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/6] dt-bindings: iio: introduce trigger providers, consumers Date: Sun, 5 Mar 2017 12:13:36 +0000 [thread overview] Message-ID: <12a6a2f8-9ff6-a4f0-c9a2-c7de037019ef@kernel.org> (raw) In-Reply-To: <948e5b96-7a8f-406d-6d03-d129d1b2ce54@kernel.org> On 05/03/17 11:43, Jonathan Cameron wrote: > On 03/03/17 06:21, Rob Herring wrote: >> On Tue, Feb 28, 2017 at 05:51:14PM +0100, Fabrice Gasnier wrote: >>> Document iio provider and consumer bindings. >>> >>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> >>> --- >>> .../devicetree/bindings/iio/iio-bindings.txt | 38 ++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iio/iio-bindings.txt b/Documentation/devicetree/bindings/iio/iio-bindings.txt >>> index 68d6f8c..01765e9 100644 >>> --- a/Documentation/devicetree/bindings/iio/iio-bindings.txt >>> +++ b/Documentation/devicetree/bindings/iio/iio-bindings.txt >>> @@ -95,3 +95,41 @@ vdd channel is connected to output 0 of the &ref device. >>> io-channels = <&adc 10>, <&adc 11>; >>> io-channel-names = "adc1", "adc2"; >>> }; >>> + >>> +==IIO trigger providers== >>> +Sources of IIO triggers can be represented by any node in the device >>> +tree. Those nodes are designated as IIO trigger providers. IIO trigger >>> +consumer uses a phandle and an IIO trigger specifier to connect to an >>> +IIO trigger provider. >>> +An IIO trigger specifier is an array of one or more cells identifying >>> +the IIO trigger output on a device. The length of an IIO trigger >>> +specifier is defined by the value of a #io-trigger-cells property in >>> +the IIO trigger provider node. >>> + >>> +Required properties: >>> +#io-trigger-cells: >>> + Number of cells in an IIO trigger specifier; Typically >>> + 0 for nodes with a simple IIO trigger output. >>> + >>> +Example: >>> + trig0: interrupt-trigger0 { >>> + #io-trigger-cells = <0>; >>> + compatible = "interrupt-trigger"; >>> + interrupts = <11 0>; >>> + interrupt-parent = <&gpioa>; >>> + } >>> + >>> +==IIO trigger consumers== >>> +Required properties: >>> +- io-triggers: List of phandle representing the IIO trigger specifier. >>> + >>> +Optional properties: >>> +- io-trigger-names : >>> + List of IIO trigger name strings that matches elements >>> + in 'io-triggers' list property. >>> + >>> +Example: >>> + some_trigger_consumer { >>> + io-triggers = <&trig0>; >>> + io-trigger-names = "mytrig"; >>> + } >> >> I have some reservations about this. We could just as easily add the >> interrupt directly to the consumer node and use "trigger" for a standard >> interrupt name. So the question is whether this extra level of >> indirection is needed? > > First thing to note here, is that Fabrice's use of the generic interrupt > trigger is an extremely 'unusual' one! Normal use case is that we have > a random gpio pin providing interrupts to driver triggering on random > devices - there need be no association between the two whatsoever. > So what we are doing here is 'allowing' an interrupt to provide a trigger. > It's not necessarily the one going to be used by any particular device > driver. The decision of which trigger to use is definitely one for > userspace, not something that should be configured in to the device tree. > > For this particular case you could in theory just do it by using an interrupt > as you describe. Ultimately though we should be able to play more complex > games with this device and having it able to handle any trigger - which > includes those not using the direct hardware route. It'll be up to the > driver to figure out when it can use the fast method and when it can't. > > Conversely, even when we are using this hardware route to drive the > triggering it should be possible to hang off a device to be triggered > by the interrupt via the kernel rather than directly. > > So from a device tree point of view we are just describing the fact that > there is a pin, which may be used to trigger something. What that something > is, is a question for userspace not the device tree. > Ah, I'm half asleep this morning. Clearly there is a more general follow up question. If we are arguing these are generic, why are we setting up the mapping in device tree? My gut feeling is we shouldn't be. So I think we need the first chunk above but the latter part should be a job for userspace not the devicetree. Jonathan > Jonathan >> >> Rob >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2017-03-05 12:13 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-28 16:51 [PATCH v3 0/6] Add EXTI GPIO trigger support to STM32 ADC Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` [PATCH v3 1/6] dt-bindings: iio: introduce trigger providers, consumers Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-03-03 6:21 ` Rob Herring 2017-03-03 6:21 ` Rob Herring 2017-03-03 6:21 ` Rob Herring 2017-03-03 9:32 ` Fabrice Gasnier 2017-03-03 9:32 ` Fabrice Gasnier 2017-03-03 9:32 ` Fabrice Gasnier 2017-03-05 11:45 ` Jonathan Cameron 2017-03-05 11:45 ` Jonathan Cameron 2017-03-05 11:45 ` Jonathan Cameron 2017-03-05 11:43 ` Jonathan Cameron 2017-03-05 11:43 ` Jonathan Cameron 2017-03-05 11:43 ` Jonathan Cameron 2017-03-05 12:13 ` Jonathan Cameron [this message] 2017-03-05 12:13 ` Jonathan Cameron 2017-03-15 19:25 ` Rob Herring 2017-03-15 19:25 ` Rob Herring 2017-03-15 19:25 ` Rob Herring 2017-03-17 15:59 ` Fabrice Gasnier 2017-03-17 15:59 ` Fabrice Gasnier 2017-03-17 15:59 ` Fabrice Gasnier 2017-03-19 22:58 ` Jonathan Cameron 2017-03-19 22:58 ` Jonathan Cameron 2017-03-19 22:58 ` Jonathan Cameron 2017-02-28 16:51 ` [PATCH v3 2/6] iio: trigger: add OF support Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-03-05 12:11 ` Jonathan Cameron 2017-03-05 12:11 ` Jonathan Cameron 2017-03-05 12:11 ` Jonathan Cameron 2017-03-14 15:22 ` Linus Walleij 2017-03-14 15:22 ` Linus Walleij 2017-03-14 15:22 ` Linus Walleij 2017-03-14 15:22 ` Linus Walleij 2017-02-28 16:51 ` [PATCH v3 3/6] dt-bindings: iio: document interrupt trigger support Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-03-05 12:16 ` Jonathan Cameron 2017-03-05 12:16 ` Jonathan Cameron 2017-03-05 12:16 ` Jonathan Cameron 2017-03-15 19:29 ` Rob Herring 2017-03-15 19:29 ` Rob Herring 2017-03-15 19:29 ` Rob Herring 2017-02-28 16:51 ` [PATCH v3 4/6] iio: iio-interrupt-trigger: device-tree support Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-03-05 12:18 ` Jonathan Cameron 2017-03-05 12:18 ` Jonathan Cameron 2017-03-05 12:18 ` Jonathan Cameron 2017-02-28 16:51 ` [PATCH v3 5/6] dt-bindings: iio: stm32-adc: add external interrupt trigger Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` [PATCH v3 6/6] iio: adc: stm32: add support for EXTI trigger Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-02-28 16:51 ` Fabrice Gasnier 2017-03-03 11:45 ` Lars-Peter Clausen 2017-03-03 11:45 ` Lars-Peter Clausen 2017-03-03 11:45 ` Lars-Peter Clausen 2017-03-03 13:00 ` Fabrice Gasnier 2017-03-03 13:00 ` Fabrice Gasnier 2017-03-03 13:00 ` Fabrice Gasnier 2017-03-03 15:46 ` Lars-Peter Clausen 2017-03-03 15:46 ` Lars-Peter Clausen 2017-03-03 15:46 ` Lars-Peter Clausen 2017-03-03 15:47 ` Lars-Peter Clausen 2017-03-03 15:47 ` Lars-Peter Clausen 2017-03-03 15:47 ` Lars-Peter Clausen 2017-03-05 12:21 ` Jonathan Cameron 2017-03-05 12:21 ` Jonathan Cameron 2017-03-05 12:21 ` Jonathan Cameron 2017-03-05 12:28 ` Jonathan Cameron 2017-03-05 12:28 ` Jonathan Cameron 2017-03-05 12:28 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=12a6a2f8-9ff6-a4f0-c9a2-c7de037019ef@kernel.org \ --to=jic23@kernel.org \ --cc=alexandre.torgue@st.com \ --cc=benjamin.gaignard@linaro.org \ --cc=benjamin.gaignard@st.com \ --cc=devicetree@vger.kernel.org \ --cc=fabrice.gasnier@st.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=pmeerw@pmeerw.net \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.