All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"heiko@sntech.de" <heiko@sntech.de>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>
Subject: Re: [RFC PATCH v1 1/3] dt-bindings: mmc: combine common mmc and dw-mshc properties
Date: Wed, 15 Jan 2020 14:02:18 +0100	[thread overview]
Message-ID: <12bbbdbc-027e-90de-fd57-291013167b06@gmail.com> (raw)
In-Reply-To: <CAL_Jsq+8X0oRykiQOKVyaxis4H0yO=nzUtnFF_BXdwBkuigr7g@mail.gmail.com>

Hi,

Thank you for your explanation.
I was not aware that was playing.
So now we go from a 'simple' txt to yaml conversion to a complete
'change your node name first' operation.
Can you indicate if that common yaml file for dw-mshc and Rockchip
is still a good idea?

Thanks


On 1/14/20 11:06 PM, Rob Herring wrote:
> On Tue, Jan 14, 2020 at 3:38 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Combine the common properties for mmc and dw-mshc in
>> mmc-controller-common.yaml
>
> Commit messages should explain the why, not what.
>
> AFAICT, the only reason is to not have a node name of 'mmc'. That's
> entirely the reason why it is defined. Fix your node names to use the
> standard name.
>
>
>
> Rob
>

WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v1 1/3] dt-bindings: mmc: combine common mmc and dw-mshc properties
Date: Wed, 15 Jan 2020 14:02:18 +0100	[thread overview]
Message-ID: <12bbbdbc-027e-90de-fd57-291013167b06@gmail.com> (raw)
In-Reply-To: <CAL_Jsq+8X0oRykiQOKVyaxis4H0yO=nzUtnFF_BXdwBkuigr7g@mail.gmail.com>

Hi,

Thank you for your explanation.
I was not aware that was playing.
So now we go from a 'simple' txt to yaml conversion to a complete
'change your node name first' operation.
Can you indicate if that common yaml file for dw-mshc and Rockchip
is still a good idea?

Thanks


On 1/14/20 11:06 PM, Rob Herring wrote:
> On Tue, Jan 14, 2020 at 3:38 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Combine the common properties for mmc and dw-mshc in
>> mmc-controller-common.yaml
>
> Commit messages should explain the why, not what.
>
> AFAICT, the only reason is to not have a node name of 'mmc'. That's
> entirely the reason why it is defined. Fix your node names to use the
> standard name.
>
>
>
> Rob
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-15 13:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 21:38 [RFC PATCH v1 1/3] dt-bindings: mmc: combine common mmc and dw-mshc properties Johan Jonker
2020-01-14 21:38 ` Johan Jonker
2020-01-14 21:38 ` Johan Jonker
2020-01-14 21:38 ` [RFC PATCH v1 2/3] dt-bindings: mmc: convert synopsys dw-mshc bindings to yaml Johan Jonker
2020-01-14 21:38   ` Johan Jonker
2020-01-15 15:18   ` Rob Herring
2020-01-15 15:18     ` Rob Herring
2020-01-15 15:18     ` Rob Herring
2020-01-16 12:00     ` Johan Jonker
2020-01-16 12:00       ` Johan Jonker
2020-01-16 12:00       ` Johan Jonker
2020-01-16 14:07       ` Rob Herring
2020-01-16 14:07         ` Rob Herring
2020-01-16 14:07         ` Rob Herring
2020-01-14 21:38 ` [RFC PATCH v1 3/3] dt-bindings: mmc: convert rockchip " Johan Jonker
2020-01-14 21:38   ` Johan Jonker
2020-01-14 21:38   ` Johan Jonker
2020-01-15 15:09   ` Rob Herring
2020-01-15 15:09     ` Rob Herring
2020-01-15 15:09     ` Rob Herring
2020-01-14 22:06 ` [RFC PATCH v1 1/3] dt-bindings: mmc: combine common mmc and dw-mshc properties Rob Herring
2020-01-14 22:06   ` Rob Herring
2020-01-14 22:06   ` Rob Herring
2020-01-15 13:02   ` Johan Jonker [this message]
2020-01-15 13:02     ` Johan Jonker
2020-01-15 13:02     ` Johan Jonker
2020-01-15 15:03     ` Rob Herring
2020-01-15 15:03       ` Rob Herring
2020-01-15 15:03       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12bbbdbc-027e-90de-fd57-291013167b06@gmail.com \
    --to=jbx6244@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.