* [PATCH v 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support
@ 2017-07-05 13:01 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 13:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, linux-renesas-soc, linux-arm-kernel, netdev,
Biju Das
This series aims to add Gigabit Ethernet E-MAC support on r8a7743 (RZ/G1M) SoC.
The iWave RZ/G1M Qseven SOM supports Gigabit Ethernet Phy from Micrel(KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
This series has been tested against linux-next tag next-20170704.
Biju Das (2):
ravb: Add support for r8a7743 SoC
ARM: shmobile: defconfig: Enable Ethernet AVB
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
arch/arm/configs/shmobile_defconfig | 1 +
drivers/net/ethernet/renesas/ravb_main.c | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support
@ 2017-07-05 13:01 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 13:01 UTC (permalink / raw)
To: linux-arm-kernel
This series aims to add Gigabit Ethernet E-MAC support on r8a7743 (RZ/G1M) SoC.
The iWave RZ/G1M Qseven SOM supports Gigabit Ethernet Phy from Micrel(KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
This series has been tested against linux-next tag next-20170704.
Biju Das (2):
ravb: Add support for r8a7743 SoC
ARM: shmobile: defconfig: Enable Ethernet AVB
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
arch/arm/configs/shmobile_defconfig | 1 +
drivers/net/ethernet/renesas/ravb_main.c | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 13:01 ` Biju Das
@ 2017-07-05 13:01 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 13:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, linux-renesas-soc, linux-arm-kernel, netdev,
Biju Das
Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
family.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
drivers/net/ethernet/renesas/ravb_main.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b519503..bc692ab 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
interface contains.
Required properties:
-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
+- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
+ "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
"renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
"renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
"renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 5931e85..e35b30f 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
}
static const struct of_device_id ravb_match_table[] = {
+ { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 13:01 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 13:01 UTC (permalink / raw)
To: linux-arm-kernel
Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
family.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
drivers/net/ethernet/renesas/ravb_main.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b519503..bc692ab 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
interface contains.
Required properties:
-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
+- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
+ "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
"renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
"renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
"renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 5931e85..e35b30f 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
}
static const struct of_device_id ravb_match_table[] = {
+ { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
2017-07-05 13:01 ` Biju Das
@ 2017-07-05 13:01 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 13:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, linux-renesas-soc, linux-arm-kernel, netdev,
Biju Das
The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
To increase hardware support enable the driver in the shmobile_defconfig
multiplatform configuration.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3c66a42..d992911 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
# CONFIG_NET_VENDOR_MICREL is not set
# CONFIG_NET_VENDOR_NATSEMI is not set
CONFIG_SH_ETH=y
+CONFIG_RAVB=y
# CONFIG_NET_VENDOR_SEEQ is not set
CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-05 13:01 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 13:01 UTC (permalink / raw)
To: linux-arm-kernel
The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
To increase hardware support enable the driver in the shmobile_defconfig
multiplatform configuration.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3c66a42..d992911 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
# CONFIG_NET_VENDOR_MICREL is not set
# CONFIG_NET_VENDOR_NATSEMI is not set
CONFIG_SH_ETH=y
+CONFIG_RAVB=y
# CONFIG_NET_VENDOR_SEEQ is not set
CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 13:01 ` Biju Das
@ 2017-07-05 13:20 ` Sergei Shtylyov
-1 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-05 13:20 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
Hello!
On 07/05/2017 04:01 PM, Biju Das wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 5931e85..e35b30f 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
MBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 13:20 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-05 13:20 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 07/05/2017 04:01 PM, Biju Das wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 5931e85..e35b30f 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
MBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
2017-07-05 13:01 ` Biju Das
@ 2017-07-05 13:45 ` Geert Uytterhoeven
-1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-05 13:45 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Russell King, Sergei Shtylyov,
Simon Horman, Magnus Damm, Chris Paterson, devicetree,
Linux-Renesas, linux-arm-kernel, netdev
On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
> Gigabit Ethernet support is available in Renesas AVB driver.
> To increase hardware support enable the driver in the shmobile_defconfig
> multiplatform configuration.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-05 13:45 ` Geert Uytterhoeven
0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-05 13:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
> Gigabit Ethernet support is available in Renesas AVB driver.
> To increase hardware support enable the driver in the shmobile_defconfig
> multiplatform configuration.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 13:01 ` Biju Das
(?)
@ 2017-07-05 13:47 ` Geert Uytterhoeven
-1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-05 13:47 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Russell King, Sergei Shtylyov,
Simon Horman, Magnus Damm, Chris Paterson, devicetree,
Linux-Renesas, linux-arm-kernel, netdev
Hi Biju,
On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Thanks for your patch!
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
As Sergei already mentioned, a driver update is not needed due to the
presence of family-specific compatible values.
Please drop that part, and you can add my:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 13:47 ` Geert Uytterhoeven
0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-05 13:47 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Russell King, Sergei Shtylyov,
Simon Horman, Magnus Damm, Chris Paterson, devicetree,
Linux-Renesas, linux-arm-kernel, netdev
Hi Biju,
On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Thanks for your patch!
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
As Sergei already mentioned, a driver update is not needed due to the
presence of family-specific compatible values.
Please drop that part, and you can add my:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 13:47 ` Geert Uytterhoeven
0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-05 13:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi Biju,
On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Thanks for your patch!
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
As Sergei already mentioned, a driver update is not needed due to the
presence of family-specific compatible values.
Please drop that part, and you can add my:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 13:47 ` Geert Uytterhoeven
@ 2017-07-05 13:51 ` Chris Paterson
-1 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-05 13:51 UTC (permalink / raw)
To: Geert Uytterhoeven, Sergei Shtylyov
Cc: Rob Herring, Mark Rutland, Russell King, Biju Das, Simon Horman,
Magnus Damm, devicetree, Linux-Renesas, linux-arm-kernel, netdev
Hello Geert, Sergei,
> From: geert.uytterhoeven@gmail.com
> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 05 July 2017 14:47
>
> Hi Biju,
>
> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv) }
> >
> > static const struct of_device_id ravb_match_table[] = {
> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void
> > + *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
>
> As Sergei already mentioned, a driver update is not needed due to the
> presence of family-specific compatible values.
> Please drop that part, and you can add my:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Should the other compatible values (r8a7790, 94 etc) be removed then? Or are they needed for backwards compatibility?
Kind regards, Chris
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 13:51 ` Chris Paterson
0 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-05 13:51 UTC (permalink / raw)
To: linux-arm-kernel
Hello Geert, Sergei,
> From: geert.uytterhoeven at gmail.com
> [mailto:geert.uytterhoeven at gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 05 July 2017 14:47
>
> Hi Biju,
>
> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv) }
> >
> > static const struct of_device_id ravb_match_table[] = {
> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void
> > + *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
>
> As Sergei already mentioned, a driver update is not needed due to the
> presence of family-specific compatible values.
> Please drop that part, and you can add my:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Should the other compatible values (r8a7790, 94 etc) be removed then? Or are they needed for backwards compatibility?
Kind regards, Chris
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 13:51 ` Chris Paterson
@ 2017-07-05 14:55 ` Geert Uytterhoeven
-1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-05 14:55 UTC (permalink / raw)
To: Chris Paterson
Cc: Sergei Shtylyov, Rob Herring, Mark Rutland, Russell King,
Biju Das, Simon Horman, Magnus Damm, devicetree, Linux-Renesas,
linux-arm-kernel, netdev
Hi Chris,
On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson
<Chris.Paterson2@renesas.com> wrote:
>> From: geert.uytterhoeven@gmail.com
>> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven
>> Sent: 05 July 2017 14:47
>> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
>> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
>> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
>> > Gen2 family.
>> >
>> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>>
>> Thanks for your patch!
>>
>> > --- a/drivers/net/ethernet/renesas/ravb_main.c
>> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
>> > *priv) }
>> >
>> > static const struct of_device_id ravb_match_table[] = {
>> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void
>> > + *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
>> *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
>> *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
>> > *)RCAR_GEN2 },
>>
>> As Sergei already mentioned, a driver update is not needed due to the
>> presence of family-specific compatible values.
>> Please drop that part, and you can add my:
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Should the other compatible values (r8a7790, 94 etc) be removed then? Or are they needed for backwards compatibility?
The other compatible values in DT bindings and DTS files should be kept,
to allow handling of SoC-specific quirks if/when they are ever detected.
The other compatible values in the driver should be kept for
backwards-compatibility with old DTB files that lack the (newer)
family-specific compatible values.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 14:55 ` Geert Uytterhoeven
0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-05 14:55 UTC (permalink / raw)
To: linux-arm-kernel
Hi Chris,
On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson
<Chris.Paterson2@renesas.com> wrote:
>> From: geert.uytterhoeven at gmail.com
>> [mailto:geert.uytterhoeven at gmail.com] On Behalf Of Geert Uytterhoeven
>> Sent: 05 July 2017 14:47
>> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote:
>> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
>> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
>> > Gen2 family.
>> >
>> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>>
>> Thanks for your patch!
>>
>> > --- a/drivers/net/ethernet/renesas/ravb_main.c
>> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
>> > *priv) }
>> >
>> > static const struct of_device_id ravb_match_table[] = {
>> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void
>> > + *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
>> *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
>> *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
>> > *)RCAR_GEN2 },
>>
>> As Sergei already mentioned, a driver update is not needed due to the
>> presence of family-specific compatible values.
>> Please drop that part, and you can add my:
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Should the other compatible values (r8a7790, 94 etc) be removed then? Or are they needed for backwards compatibility?
The other compatible values in DT bindings and DTS files should be kept,
to allow handling of SoC-specific quirks if/when they are ever detected.
The other compatible values in the driver should be kept for
backwards-compatibility with old DTB files that lack the (newer)
family-specific compatible values.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 14:55 ` Geert Uytterhoeven
(?)
@ 2017-07-05 14:59 ` Chris Paterson
-1 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-05 14:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sergei Shtylyov, Rob Herring, Mark Rutland, Russell King,
Biju Das, Simon Horman, Magnus Damm,
devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-Renesas,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA
Hello Geert,
> From: geert.uytterhoeven@gmail.com
> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 05 July 2017 15:56
>
> Hi Chris,
>
> On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson
> <Chris.Paterson2@renesas.com> wrote:
> >> From: geert.uytterhoeven@gmail.com
> >> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert
> Uytterhoeven
> >> Sent: 05 July 2017 14:47
> >> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com>
> wrote:
> >> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> >> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the
> >> > R-Car
> >> > Gen2 family.
> >> >
> >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> >>
> >> Thanks for your patch!
> >>
> >> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> >> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> >> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct
> >> > ravb_private
> >> > *priv) }
> >> >
> >> > static const struct of_device_id ravb_match_table[] = {
> >> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void
> >> > + *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> >> > *)RCAR_GEN2 },
> >>
> >> As Sergei already mentioned, a driver update is not needed due to the
> >> presence of family-specific compatible values.
> >> Please drop that part, and you can add my:
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Should the other compatible values (r8a7790, 94 etc) be removed then? Or
> are they needed for backwards compatibility?
>
> The other compatible values in DT bindings and DTS files should be kept, to
> allow handling of SoC-specific quirks if/when they are ever detected.
>
> The other compatible values in the driver should be kept for backwards-
> compatibility with old DTB files that lack the (newer) family-specific
> compatible values.
Thank you for the comprehensive answer.
Kind regards, Chris
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 14:59 ` Chris Paterson
0 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-05 14:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sergei Shtylyov, Rob Herring, Mark Rutland, Russell King,
Biju Das, Simon Horman, Magnus Damm, devicetree, Linux-Renesas,
linux-arm-kernel, netdev
Hello Geert,
> From: geert.uytterhoeven@gmail.com
> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 05 July 2017 15:56
>
> Hi Chris,
>
> On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson
> <Chris.Paterson2@renesas.com> wrote:
> >> From: geert.uytterhoeven@gmail.com
> >> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert
> Uytterhoeven
> >> Sent: 05 July 2017 14:47
> >> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com>
> wrote:
> >> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> >> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the
> >> > R-Car
> >> > Gen2 family.
> >> >
> >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> >>
> >> Thanks for your patch!
> >>
> >> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> >> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> >> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct
> >> > ravb_private
> >> > *priv) }
> >> >
> >> > static const struct of_device_id ravb_match_table[] = {
> >> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void
> >> > + *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> >> > *)RCAR_GEN2 },
> >>
> >> As Sergei already mentioned, a driver update is not needed due to the
> >> presence of family-specific compatible values.
> >> Please drop that part, and you can add my:
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Should the other compatible values (r8a7790, 94 etc) be removed then? Or
> are they needed for backwards compatibility?
>
> The other compatible values in DT bindings and DTS files should be kept, to
> allow handling of SoC-specific quirks if/when they are ever detected.
>
> The other compatible values in the driver should be kept for backwards-
> compatibility with old DTB files that lack the (newer) family-specific
> compatible values.
Thank you for the comprehensive answer.
Kind regards, Chris
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 14:59 ` Chris Paterson
0 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-05 14:59 UTC (permalink / raw)
To: linux-arm-kernel
Hello Geert,
> From: geert.uytterhoeven at gmail.com
> [mailto:geert.uytterhoeven at gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 05 July 2017 15:56
>
> Hi Chris,
>
> On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson
> <Chris.Paterson2@renesas.com> wrote:
> >> From: geert.uytterhoeven at gmail.com
> >> [mailto:geert.uytterhoeven at gmail.com] On Behalf Of Geert
> Uytterhoeven
> >> Sent: 05 July 2017 14:47
> >> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com>
> wrote:
> >> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> >> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the
> >> > R-Car
> >> > Gen2 family.
> >> >
> >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> >>
> >> Thanks for your patch!
> >>
> >> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> >> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> >> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct
> >> > ravb_private
> >> > *priv) }
> >> >
> >> > static const struct of_device_id ravb_match_table[] = {
> >> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void
> >> > + *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> >> > *)RCAR_GEN2 },
> >>
> >> As Sergei already mentioned, a driver update is not needed due to the
> >> presence of family-specific compatible values.
> >> Please drop that part, and you can add my:
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Should the other compatible values (r8a7790, 94 etc) be removed then? Or
> are they needed for backwards compatibility?
>
> The other compatible values in DT bindings and DTS files should be kept, to
> allow handling of SoC-specific quirks if/when they are ever detected.
>
> The other compatible values in the driver should be kept for backwards-
> compatibility with old DTB files that lack the (newer) family-specific
> compatible values.
Thank you for the comprehensive answer.
Kind regards, Chris
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 13:20 ` Sergei Shtylyov
(?)
@ 2017-07-05 15:02 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:02 UTC (permalink / raw)
To: Sergei Shtylyov, Rob Herring, Mark Rutland, Russell King
Cc: Simon Horman, Magnus Damm, Chris Paterson,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2432 bytes --]
> -----Original Message-----
> From: devicetree-owner@vger.kernel.org [mailto:devicetree-
> owner@vger.kernel.org] On Behalf Of Sergei Shtylyov
> Sent: 05 July 2017 14:21
> To: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>;
> Mark Rutland <mark.rutland@arm.com>; Russell King
> <linux@armlinux.org.uk>
> Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
> <magnus.damm@gmail.com>; Chris Paterson
> <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> Hello!
>
> On 07/05/2017 04:01 PM, Biju Das wrote:
>
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> [...]
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv) }
> >
> > static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
>
> No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".
>
Thanks for the review. I will remove this change.
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
>
> MBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in the body
> of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
N§²æìr¸yúèØb²X¬¶Ç§vØ^)Þº{.nÇ+·zøzÚÞz)í
æèw*\x1fjg¬±¨\x1e¶Ý¢j.ïÛ°\½½MúgjÌæa×\x02' ©Þ¢¸\f¢·¦j:+v¨wèjØm¶ÿ¾\a«êçzZ+ùÝ¢j"ú!¶i
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 15:02 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:02 UTC (permalink / raw)
To: Sergei Shtylyov, Rob Herring, Mark Rutland, Russell King
Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
> -----Original Message-----
> From: devicetree-owner@vger.kernel.org [mailto:devicetree-
> owner@vger.kernel.org] On Behalf Of Sergei Shtylyov
> Sent: 05 July 2017 14:21
> To: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>;
> Mark Rutland <mark.rutland@arm.com>; Russell King
> <linux@armlinux.org.uk>
> Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
> <magnus.damm@gmail.com>; Chris Paterson
> <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> Hello!
>
> On 07/05/2017 04:01 PM, Biju Das wrote:
>
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> [...]
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv) }
> >
> > static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
>
> No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".
>
Thanks for the review. I will remove this change.
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
>
> MBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in the body
> of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-05 15:02 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:02 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: devicetree-owner at vger.kernel.org [mailto:devicetree-
> owner at vger.kernel.org] On Behalf Of Sergei Shtylyov
> Sent: 05 July 2017 14:21
> To: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>;
> Mark Rutland <mark.rutland@arm.com>; Russell King
> <linux@armlinux.org.uk>
> Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
> <magnus.damm@gmail.com>; Chris Paterson
> <Chris.Paterson2@renesas.com>; devicetree at vger.kernel.org; linux-renesas-
> soc at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> netdev at vger.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> Hello!
>
> On 07/05/2017 04:01 PM, Biju Das wrote:
>
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> [...]
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv) }
> >
> > static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
>
> No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".
>
Thanks for the review. I will remove this change.
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
>
> MBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in the body
> of a message to majordomo at vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support
2017-07-05 13:20 ` Sergei Shtylyov
@ 2017-07-05 15:56 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:56 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, linux-renesas-soc, linux-arm-kernel, netdev,
Biju Das
Hi All,
This series aims to upstream the Ethernet AVB driver support for RZ/G1M (r8a7743) SoC .
The iWave RZ/G1M Qseven SOM supports Gigabit Ethernet Phy from Micrel(KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
This series has been tested against linux-next tag next-20170704.
Modifications:
v1->v2
-Dropped the driver update,as is it not needed due to the presence of family-specific compatible values.
-Added Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> for the DT binding patch
-Added Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> for the defconfig: Enable Ethernet AVB patch
History:
-------
[v1]: https://www.spinics.net/lists/arm-kernel/msg592366.html
Biju Das (2):
ravb: Document binding for r8a7743 SoC
ARM: shmobile: defconfig: Enable Ethernet AVB
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
arch/arm/configs/shmobile_defconfig | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support
@ 2017-07-05 15:56 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi All,
This series aims to upstream the Ethernet AVB driver support for RZ/G1M (r8a7743) SoC .
The iWave RZ/G1M Qseven SOM supports Gigabit Ethernet Phy from Micrel(KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
This series has been tested against linux-next tag next-20170704.
Modifications:
v1->v2
-Dropped the driver update,as is it not needed due to the presence of family-specific compatible values.
-Added Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> for the DT binding patch
-Added Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> for the defconfig: Enable Ethernet AVB patch
History:
-------
[v1]: https://www.spinics.net/lists/arm-kernel/msg592366.html
Biju Das (2):
ravb: Document binding for r8a7743 SoC
ARM: shmobile: defconfig: Enable Ethernet AVB
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
arch/arm/configs/shmobile_defconfig | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2 1/2] ravb: Document binding for r8a7743 SoC
2017-07-05 15:56 ` Biju Das
@ 2017-07-05 15:56 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:56 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, linux-renesas-soc, linux-arm-kernel, netdev,
Biju Das
Add a new compatible string for the RZ/G1M (R8A7743) SoC.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b519503..bc692ab 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
interface contains.
Required properties:
-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
+- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
+ "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
"renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
"renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
"renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v2 1/2] ravb: Document binding for r8a7743 SoC
@ 2017-07-05 15:56 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:56 UTC (permalink / raw)
To: linux-arm-kernel
Add a new compatible string for the RZ/G1M (R8A7743) SoC.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b519503..bc692ab 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
interface contains.
Required properties:
-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
+- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
+ "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
"renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
"renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
"renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
2017-07-05 15:56 ` Biju Das
(?)
@ 2017-07-05 15:56 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:56 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA, Biju Das
The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
To increase hardware support enable the driver in the shmobile_defconfig
multiplatform configuration.
Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Acked-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3c66a42..d992911 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
# CONFIG_NET_VENDOR_MICREL is not set
# CONFIG_NET_VENDOR_NATSEMI is not set
CONFIG_SH_ETH=y
+CONFIG_RAVB=y
# CONFIG_NET_VENDOR_SEEQ is not set
CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-05 15:56 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:56 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, linux-renesas-soc, linux-arm-kernel, netdev,
Biju Das
The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
To increase hardware support enable the driver in the shmobile_defconfig
multiplatform configuration.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3c66a42..d992911 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
# CONFIG_NET_VENDOR_MICREL is not set
# CONFIG_NET_VENDOR_NATSEMI is not set
CONFIG_SH_ETH=y
+CONFIG_RAVB=y
# CONFIG_NET_VENDOR_SEEQ is not set
CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-05 15:56 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-05 15:56 UTC (permalink / raw)
To: linux-arm-kernel
The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
Gigabit Ethernet support is available in Renesas AVB driver.
To increase hardware support enable the driver in the shmobile_defconfig
multiplatform configuration.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3c66a42..d992911 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
# CONFIG_NET_VENDOR_MICREL is not set
# CONFIG_NET_VENDOR_NATSEMI is not set
CONFIG_SH_ETH=y
+CONFIG_RAVB=y
# CONFIG_NET_VENDOR_SEEQ is not set
CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* Re: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
2017-07-05 15:56 ` Biju Das
(?)
@ 2017-07-05 16:13 ` Sergei Shtylyov
-1 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-05 16:13 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: Simon Horman, Magnus Damm, Chris Paterson,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA
Hello!
On 07/05/2017 06:56 PM, Biju Das wrote:
> The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
> Gigabit Ethernet support is available in Renesas AVB driver.
> To increase hardware support enable the driver in the shmobile_defconfig
> multiplatform configuration.
>
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> Acked-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> ---
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 3c66a42..d992911 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> # CONFIG_NET_VENDOR_MICREL is not set
> # CONFIG_NET_VENDOR_NATSEMI is not set
> CONFIG_SH_ETH=y
> +CONFIG_RAVB=y
Hm, I would enable it only as a module, given it's not easy to make use of
AVB on the 32-bit boards.
[...]
MBR Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-05 16:13 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-05 16:13 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
Hello!
On 07/05/2017 06:56 PM, Biju Das wrote:
> The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
> Gigabit Ethernet support is available in Renesas AVB driver.
> To increase hardware support enable the driver in the shmobile_defconfig
> multiplatform configuration.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 3c66a42..d992911 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> # CONFIG_NET_VENDOR_MICREL is not set
> # CONFIG_NET_VENDOR_NATSEMI is not set
> CONFIG_SH_ETH=y
> +CONFIG_RAVB=y
Hm, I would enable it only as a module, given it's not easy to make use of
AVB on the 32-bit boards.
[...]
MBR Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-05 16:13 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-05 16:13 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 07/05/2017 06:56 PM, Biju Das wrote:
> The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX).
> Gigabit Ethernet support is available in Renesas AVB driver.
> To increase hardware support enable the driver in the shmobile_defconfig
> multiplatform configuration.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 3c66a42..d992911 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> # CONFIG_NET_VENDOR_MICREL is not set
> # CONFIG_NET_VENDOR_NATSEMI is not set
> CONFIG_SH_ETH=y
> +CONFIG_RAVB=y
Hm, I would enable it only as a module, given it's not easy to make use of
AVB on the 32-bit boards.
[...]
MBR Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
2017-07-05 16:13 ` Sergei Shtylyov
(?)
@ 2017-07-06 8:05 ` Chris Paterson
-1 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-06 8:05 UTC (permalink / raw)
To: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: devicetree, netdev, Magnus Damm, linux-renesas-soc, Simon Horman,
linux-arm-kernel
Hello Sergei,
Thank you for your comments.
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: 05 July 2017 17:14
>
> Hello!
>
> On 07/05/2017 06:56 PM, Biju Das wrote:
>
> > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel
> KSZ9031MNX).
> > Gigabit Ethernet support is available in Renesas AVB driver.
> > To increase hardware support enable the driver in the
> > shmobile_defconfig multiplatform configuration.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm/configs/shmobile_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > index 3c66a42..d992911 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> > # CONFIG_NET_VENDOR_MICREL is not set #
> CONFIG_NET_VENDOR_NATSEMI is
> > not set CONFIG_SH_ETH=y
> > +CONFIG_RAVB=y
>
> Hm, I would enable it only as a module, given it's not easy to make use of
> AVB on the 32-bit boards.
On the iWave-M platforms the only available Ethernet interface is AVB. Without including the RAVB driver in the Kernel we won't be able to use NFS.
I know adding CONFIG_RAVB for all shmobile devices may increase the Kernel size for everyone, especially when most cannot use AVB without an add-on board, but I don't think the increase will be big.
Kind regards, Chris
>
> [...]
>
> MBR Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-06 8:05 ` Chris Paterson
0 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-06 8:05 UTC (permalink / raw)
To: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: Simon Horman, Magnus Damm, devicetree, linux-renesas-soc,
linux-arm-kernel, netdev
Hello Sergei,
Thank you for your comments.
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: 05 July 2017 17:14
>
> Hello!
>
> On 07/05/2017 06:56 PM, Biju Das wrote:
>
> > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel
> KSZ9031MNX).
> > Gigabit Ethernet support is available in Renesas AVB driver.
> > To increase hardware support enable the driver in the
> > shmobile_defconfig multiplatform configuration.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm/configs/shmobile_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > index 3c66a42..d992911 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> > # CONFIG_NET_VENDOR_MICREL is not set #
> CONFIG_NET_VENDOR_NATSEMI is
> > not set CONFIG_SH_ETH=y
> > +CONFIG_RAVB=y
>
> Hm, I would enable it only as a module, given it's not easy to make use of
> AVB on the 32-bit boards.
On the iWave-M platforms the only available Ethernet interface is AVB. Without including the RAVB driver in the Kernel we won't be able to use NFS.
I know adding CONFIG_RAVB for all shmobile devices may increase the Kernel size for everyone, especially when most cannot use AVB without an add-on board, but I don't think the increase will be big.
Kind regards, Chris
>
> [...]
>
> MBR Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-06 8:05 ` Chris Paterson
0 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-06 8:05 UTC (permalink / raw)
To: linux-arm-kernel
Hello Sergei,
Thank you for your comments.
> From: Sergei Shtylyov [mailto:sergei.shtylyov at cogentembedded.com]
> Sent: 05 July 2017 17:14
>
> Hello!
>
> On 07/05/2017 06:56 PM, Biju Das wrote:
>
> > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel
> KSZ9031MNX).
> > Gigabit Ethernet support is available in Renesas AVB driver.
> > To increase hardware support enable the driver in the
> > shmobile_defconfig multiplatform configuration.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm/configs/shmobile_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > index 3c66a42..d992911 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> > # CONFIG_NET_VENDOR_MICREL is not set #
> CONFIG_NET_VENDOR_NATSEMI is
> > not set CONFIG_SH_ETH=y
> > +CONFIG_RAVB=y
>
> Hm, I would enable it only as a module, given it's not easy to make use of
> AVB on the 32-bit boards.
On the iWave-M platforms the only available Ethernet interface is AVB. Without including the RAVB driver in the Kernel we won't be able to use NFS.
I know adding CONFIG_RAVB for all shmobile devices may increase the Kernel size for everyone, especially when most cannot use AVB without an add-on board, but I don't think the increase will be big.
Kind regards, Chris
>
> [...]
>
> MBR Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-05 13:01 ` Biju Das
(?)
@ 2017-07-10 1:20 ` Rob Herring
-1 siblings, 0 replies; 66+ messages in thread
From: Rob Herring @ 2017-07-10 1:20 UTC (permalink / raw)
To: Biju Das
Cc: Mark Rutland, Russell King, Sergei Shtylyov, Simon Horman,
Magnus Damm, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA
On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
For the subject: "dt-bindings: net: ..."
>
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
> drivers/net/ethernet/renesas/ravb_main.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index b519503..bc692ab 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
> interface contains.
>
> Required properties:
> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
> + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
Please re-format like this:
- compatible: Must be one of:
...
So it's a one line change to add new compatibles.
> "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 5931e85..e35b30f 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-10 1:20 ` Rob Herring
0 siblings, 0 replies; 66+ messages in thread
From: Rob Herring @ 2017-07-10 1:20 UTC (permalink / raw)
To: Biju Das
Cc: Mark Rutland, Russell King, Sergei Shtylyov, Simon Horman,
Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc,
linux-arm-kernel, netdev
On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
For the subject: "dt-bindings: net: ..."
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
> Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
> drivers/net/ethernet/renesas/ravb_main.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index b519503..bc692ab 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
> interface contains.
>
> Required properties:
> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
> + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
Please re-format like this:
- compatible: Must be one of:
...
So it's a one line change to add new compatibles.
> "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 5931e85..e35b30f 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-10 1:20 ` Rob Herring
0 siblings, 0 replies; 66+ messages in thread
From: Rob Herring @ 2017-07-10 1:20 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
For the subject: "dt-bindings: net: ..."
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
> Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
> drivers/net/ethernet/renesas/ravb_main.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index b519503..bc692ab 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
> interface contains.
>
> Required properties:
> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
> + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
Please re-format like this:
- compatible: Must be one of:
...
So it's a one line change to add new compatibles.
> "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 5931e85..e35b30f 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
> }
>
> static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-10 1:20 ` Rob Herring
@ 2017-07-10 8:20 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-10 8:20 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Russell King, Sergei Shtylyov, Simon Horman,
Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc,
linux-arm-kernel, netdev
Hello,
Thanks for the review.
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 10 July 2017 02:20
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Mark Rutland <mark.rutland@arm.com>; Russell King
> <linux@armlinux.org.uk>; Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com>; Simon Horman
> <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris
> Paterson <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; linux-
> renesas-soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
>
> For the subject: "dt-bindings: net: ..."
I will change the subject to "dt-bindings: net: ravb: ..
>
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > ---
> > Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
> > drivers/net/ethernet/renesas/ravb_main.c | 1 +
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..bc692ab 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,7 +4,8 @@ This file provides information on what the device node
> > for the Ethernet AVB interface contains.
> >
> > Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743
> SoC.
> > + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>
> Please re-format like this:
>
> - compatible: Must be one of:
> ...
>
Ok. I will change this as well.
> So it's a one line change to add new compatibles.
>
> > "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> > "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> > "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv) }
> >
> > static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
> > --
> > 1.9.1
> >
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-10 8:20 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-10 8:20 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
Thanks for the review.
> -----Original Message-----
> From: Rob Herring [mailto:robh at kernel.org]
> Sent: 10 July 2017 02:20
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Mark Rutland <mark.rutland@arm.com>; Russell King
> <linux@armlinux.org.uk>; Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com>; Simon Horman
> <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris
> Paterson <Chris.Paterson2@renesas.com>; devicetree at vger.kernel.org; linux-
> renesas-soc at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> netdev at vger.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
>
> For the subject: "dt-bindings: net: ..."
I will change the subject to "dt-bindings: net: ravb: ..
>
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > ---
> > Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
> > drivers/net/ethernet/renesas/ravb_main.c | 1 +
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..bc692ab 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,7 +4,8 @@ This file provides information on what the device node
> > for the Ethernet AVB interface contains.
> >
> > Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743
> SoC.
> > + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>
> Please re-format like this:
>
> - compatible: Must be one of:
> ...
>
Ok. I will change this as well.
> So it's a one line change to add new compatibles.
>
> > "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> > "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> > "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv) }
> >
> > static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
> > --
> > 1.9.1
> >
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
2017-07-06 8:05 ` Chris Paterson
@ 2017-07-10 8:38 ` Simon Horman
-1 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-10 8:38 UTC (permalink / raw)
To: Chris Paterson
Cc: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland,
Russell King, Magnus Damm, devicetree, linux-renesas-soc,
linux-arm-kernel, netdev
On Thu, Jul 06, 2017 at 08:05:43AM +0000, Chris Paterson wrote:
> Hello Sergei,
>
> Thank you for your comments.
>
> > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> > Sent: 05 July 2017 17:14
> >
> > Hello!
> >
> > On 07/05/2017 06:56 PM, Biju Das wrote:
> >
> > > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel
> > KSZ9031MNX).
> > > Gigabit Ethernet support is available in Renesas AVB driver.
> > > To increase hardware support enable the driver in the
> > > shmobile_defconfig multiplatform configuration.
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > arch/arm/configs/shmobile_defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/configs/shmobile_defconfig
> > > b/arch/arm/configs/shmobile_defconfig
> > > index 3c66a42..d992911 100644
> > > --- a/arch/arm/configs/shmobile_defconfig
> > > +++ b/arch/arm/configs/shmobile_defconfig
> > > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> > > # CONFIG_NET_VENDOR_MICREL is not set #
> > CONFIG_NET_VENDOR_NATSEMI is
> > > not set CONFIG_SH_ETH=y
> > > +CONFIG_RAVB=y
> >
> > Hm, I would enable it only as a module, given it's not easy to make use of
> > AVB on the 32-bit boards.
>
> On the iWave-M platforms the only available Ethernet interface is AVB.
> Without including the RAVB driver in the Kernel we won't be able to use
> NFS.
>
> I know adding CONFIG_RAVB for all shmobile devices may increase the
> Kernel size for everyone, especially when most cannot use AVB without an
> add-on board, but I don't think the increase will be big.
Thanks for the explanation, applied for v4.14.
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB
@ 2017-07-10 8:38 ` Simon Horman
0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-10 8:38 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 06, 2017 at 08:05:43AM +0000, Chris Paterson wrote:
> Hello Sergei,
>
> Thank you for your comments.
>
> > From: Sergei Shtylyov [mailto:sergei.shtylyov at cogentembedded.com]
> > Sent: 05 July 2017 17:14
> >
> > Hello!
> >
> > On 07/05/2017 06:56 PM, Biju Das wrote:
> >
> > > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel
> > KSZ9031MNX).
> > > Gigabit Ethernet support is available in Renesas AVB driver.
> > > To increase hardware support enable the driver in the
> > > shmobile_defconfig multiplatform configuration.
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > arch/arm/configs/shmobile_defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/configs/shmobile_defconfig
> > > b/arch/arm/configs/shmobile_defconfig
> > > index 3c66a42..d992911 100644
> > > --- a/arch/arm/configs/shmobile_defconfig
> > > +++ b/arch/arm/configs/shmobile_defconfig
> > > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y
> > > # CONFIG_NET_VENDOR_MICREL is not set #
> > CONFIG_NET_VENDOR_NATSEMI is
> > > not set CONFIG_SH_ETH=y
> > > +CONFIG_RAVB=y
> >
> > Hm, I would enable it only as a module, given it's not easy to make use of
> > AVB on the 32-bit boards.
>
> On the iWave-M platforms the only available Ethernet interface is AVB.
> Without including the RAVB driver in the Kernel we won't be able to use
> NFS.
>
> I know adding CONFIG_RAVB for all shmobile devices may increase the
> Kernel size for everyone, especially when most cannot use AVB without an
> add-on board, but I don't think the increase will be big.
Thanks for the explanation, applied for v4.14.
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
2017-07-10 1:20 ` Rob Herring
@ 2017-07-10 9:31 ` Sergei Shtylyov
-1 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-10 9:31 UTC (permalink / raw)
To: Rob Herring, Biju Das
Cc: Mark Rutland, Russell King, Simon Horman, Magnus Damm,
Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel,
netdev
Hello!
On 7/10/2017 4:20 AM, Rob Herring wrote:
>> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
>> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
>> family.
>
> For the subject: "dt-bindings: net: ..."
>
>>
>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>> ---
>> Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
>> drivers/net/ethernet/renesas/ravb_main.c | 1 +
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> index b519503..bc692ab 100644
>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
>> interface contains.
>>
>> Required properties:
>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>> +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
>> + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>
> Please re-format like this:
>
> - compatible: Must be one of:
> ...
>
> So it's a one line change to add new compatibles.
Note that the common gen2/3 values are at end of this list, so they'll
need different treating if you add these words.
MBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v 1/2] ravb: Add support for r8a7743 SoC
@ 2017-07-10 9:31 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-10 9:31 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 7/10/2017 4:20 AM, Rob Herring wrote:
>> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
>> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
>> family.
>
> For the subject: "dt-bindings: net: ..."
>
>>
>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>> ---
>> Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
>> drivers/net/ethernet/renesas/ravb_main.c | 1 +
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> index b519503..bc692ab 100644
>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB
>> interface contains.
>>
>> Required properties:
>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>> +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC.
>> + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>
> Please re-format like this:
>
> - compatible: Must be one of:
> ...
>
> So it's a one line change to add new compatibles.
Note that the common gen2/3 values are at end of this list, so they'll
need different treating if you add these words.
MBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-10 1:20 ` Rob Herring
@ 2017-07-10 15:32 ` Biju Das
-1 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-10 15:32 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: David S. Miller, Sergei Shtylyov, Simon Horman, Magnus Damm,
Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel,
netdev, Biju Das
Add a new compatible string for the RZ/G1M (R8A7743) SoC.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
v1->v2
* Changed the subject
* re-formatted the required properties
.../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b519503..4717bc2 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
interface contains.
Required properties:
-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
+- compatible: Must contain one or more of the following:
+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
+ - "renesas,etheravb-rcar-gen2" as a fallback for the above
+ R-Car Gen2 and RZ/G1 devices.
- When compatible with the generic version, nodes must list the
- SoC-specific version corresponding to the platform first
- followed by the generic version.
+ - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
+ - "renesas,etheravb-r8a7796" for the R8A7796 SoC.
+ - "renesas,etheravb-rcar-gen3" as a fallback for the above
+ R-Car Gen3 devices.
+
+ When compatible with the generic version, nodes must list the
+ SoC-specific version corresponding to the platform first followed by
+ the generic version.
- reg: offset and length of (1) the register block and (2) the stream buffer.
- interrupts: A list of interrupt-specifiers, one for each entry in
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-10 15:32 ` Biju Das
0 siblings, 0 replies; 66+ messages in thread
From: Biju Das @ 2017-07-10 15:32 UTC (permalink / raw)
To: linux-arm-kernel
Add a new compatible string for the RZ/G1M (R8A7743) SoC.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
v1->v2
* Changed the subject
* re-formatted the required properties
.../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b519503..4717bc2 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
interface contains.
Required properties:
-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
+- compatible: Must contain one or more of the following:
+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
+ - "renesas,etheravb-rcar-gen2" as a fallback for the above
+ R-Car Gen2 and RZ/G1 devices.
- When compatible with the generic version, nodes must list the
- SoC-specific version corresponding to the platform first
- followed by the generic version.
+ - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
+ - "renesas,etheravb-r8a7796" for the R8A7796 SoC.
+ - "renesas,etheravb-rcar-gen3" as a fallback for the above
+ R-Car Gen3 devices.
+
+ When compatible with the generic version, nodes must list the
+ SoC-specific version corresponding to the platform first followed by
+ the generic version.
- reg: offset and length of (1) the register block and (2) the stream buffer.
- interrupts: A list of interrupt-specifiers, one for each entry in
--
1.9.1
^ permalink raw reply related [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-10 15:32 ` Biju Das
(?)
@ 2017-07-10 15:51 ` Geert Uytterhoeven
-1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 15:51 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Russell King, David S. Miller,
Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-Renesas,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA
On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> wrote:
> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-10 15:51 ` Geert Uytterhoeven
0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 15:51 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Russell King, David S. Miller,
Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, Linux-Renesas, linux-arm-kernel, netdev
On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-10 15:51 ` Geert Uytterhoeven
0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 15:51 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-10 15:51 ` Geert Uytterhoeven
@ 2017-07-11 9:07 ` Simon Horman
-1 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-11 9:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Biju Das, Rob Herring, Mark Rutland, Russell King,
David S. Miller, Sergei Shtylyov, Magnus Damm, Chris Paterson,
devicetree, Linux-Renesas, linux-arm-kernel, netdev
On Mon, Jul 10, 2017 at 05:51:09PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
I believe that as net-next is currently closed you should repost it once
it re-opens (likely in about a week) with the following subject prefix
and Geert's tag.
[PATCH net-next repost v2]
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 9:07 ` Simon Horman
0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-11 9:07 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 05:51:09PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
I believe that as net-next is currently closed you should repost it once
it re-opens (likely in about a week) with the following subject prefix
and Geert's tag.
[PATCH net-next repost v2]
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-10 15:32 ` Biju Das
@ 2017-07-11 12:12 ` Sergei Shtylyov
-1 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-11 12:12 UTC (permalink / raw)
To: Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: David S. Miller, Simon Horman, Magnus Damm, Chris Paterson,
devicetree, linux-renesas-soc, linux-arm-kernel, netdev
Hello!
On 07/10/2017 06:32 PM, Biju Das wrote:
> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> v1->v2
> * Changed the subject
> * re-formatted the required properties
>
> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
> 1 file changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index b519503..4717bc2 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
> interface contains.
>
> Required properties:
> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
> +- compatible: Must contain one or more of the following:
No, it can't contain more than one SoC specific value.
> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
> + R-Car Gen2 and RZ/G1 devices.
>
> - When compatible with the generic version, nodes must list the
> - SoC-specific version corresponding to the platform first
> - followed by the generic version.
> + - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
> + - "renesas,etheravb-r8a7796" for the R8A7796 SoC.
Neither here.
> + - "renesas,etheravb-rcar-gen3" as a fallback for the above
> + R-Car Gen3 devices.
> +
> + When compatible with the generic version, nodes must list the
> + SoC-specific version corresponding to the platform first followed by
> + the generic version.
>
> - reg: offset and length of (1) the register block and (2) the stream buffer.
> - interrupts: A list of interrupt-specifiers, one for each entry in
WBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 12:12 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-11 12:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 07/10/2017 06:32 PM, Biju Das wrote:
> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> v1->v2
> * Changed the subject
> * re-formatted the required properties
>
> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
> 1 file changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index b519503..4717bc2 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
> interface contains.
>
> Required properties:
> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
> +- compatible: Must contain one or more of the following:
No, it can't contain more than one SoC specific value.
> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
> + R-Car Gen2 and RZ/G1 devices.
>
> - When compatible with the generic version, nodes must list the
> - SoC-specific version corresponding to the platform first
> - followed by the generic version.
> + - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
> + - "renesas,etheravb-r8a7796" for the R8A7796 SoC.
Neither here.
> + - "renesas,etheravb-rcar-gen3" as a fallback for the above
> + R-Car Gen3 devices.
> +
> + When compatible with the generic version, nodes must list the
> + SoC-specific version corresponding to the platform first followed by
> + the generic version.
>
> - reg: offset and length of (1) the register block and (2) the stream buffer.
> - interrupts: A list of interrupt-specifiers, one for each entry in
WBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-11 12:12 ` Sergei Shtylyov
(?)
@ 2017-07-11 12:20 ` Chris Paterson
-1 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-11 12:20 UTC (permalink / raw)
To: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: David S. Miller, Simon Horman, Magnus Damm,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA
Hello Sergei,
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: 11 July 2017 13:12
>
> Hello!
>
> On 07/10/2017 06:32 PM, Biju Das wrote:
>
> > Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > v1->v2
> > * Changed the subject
> > * re-formatted the required properties
> >
> > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------
> ---
> > 1 file changed, 17 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..4717bc2 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,19 +4,24 @@ This file provides information on what the device
> > node for the Ethernet AVB interface contains.
> >
> > Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> > - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> > - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> > - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> > - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> > - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible
> interface.
> > - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible
> interface.
> > +- compatible: Must contain one or more of the following:
>
> No, it can't contain more than one SoC specific value.
Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example?
As indeed dictated by the instruction further down:
> > + When compatible with the generic version, nodes must list the
> > + SoC-specific version corresponding to the platform first followed by
> > + the generic version.
Kind regards, Chris
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 12:20 ` Chris Paterson
0 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-11 12:20 UTC (permalink / raw)
To: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: David S. Miller, Simon Horman, Magnus Damm, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
Hello Sergei,
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: 11 July 2017 13:12
>
> Hello!
>
> On 07/10/2017 06:32 PM, Biju Das wrote:
>
> > Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > v1->v2
> > * Changed the subject
> > * re-formatted the required properties
> >
> > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------
> ---
> > 1 file changed, 17 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..4717bc2 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,19 +4,24 @@ This file provides information on what the device
> > node for the Ethernet AVB interface contains.
> >
> > Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> > - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> > - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> > - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> > - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> > - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible
> interface.
> > - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible
> interface.
> > +- compatible: Must contain one or more of the following:
>
> No, it can't contain more than one SoC specific value.
Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example?
As indeed dictated by the instruction further down:
> > + When compatible with the generic version, nodes must list the
> > + SoC-specific version corresponding to the platform first followed by
> > + the generic version.
Kind regards, Chris
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 12:20 ` Chris Paterson
0 siblings, 0 replies; 66+ messages in thread
From: Chris Paterson @ 2017-07-11 12:20 UTC (permalink / raw)
To: linux-arm-kernel
Hello Sergei,
> From: Sergei Shtylyov [mailto:sergei.shtylyov at cogentembedded.com]
> Sent: 11 July 2017 13:12
>
> Hello!
>
> On 07/10/2017 06:32 PM, Biju Das wrote:
>
> > Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > v1->v2
> > * Changed the subject
> > * re-formatted the required properties
> >
> > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------
> ---
> > 1 file changed, 17 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..4717bc2 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,19 +4,24 @@ This file provides information on what the device
> > node for the Ethernet AVB interface contains.
> >
> > Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> > - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> > - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> > - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> > - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> > - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible
> interface.
> > - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible
> interface.
> > +- compatible: Must contain one or more of the following:
>
> No, it can't contain more than one SoC specific value.
Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example?
As indeed dictated by the instruction further down:
> > + When compatible with the generic version, nodes must list the
> > + SoC-specific version corresponding to the platform first followed by
> > + the generic version.
Kind regards, Chris
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-11 12:12 ` Sergei Shtylyov
@ 2017-07-11 12:21 ` Simon Horman
-1 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-11 12:21 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Biju Das, Rob Herring, Mark Rutland, Russell King,
David S. Miller, Magnus Damm, Chris Paterson, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
On Tue, Jul 11, 2017 at 03:12:14PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 07/10/2017 06:32 PM, Biju Das wrote:
>
> >Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> >Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >---
> >v1->v2
> >* Changed the subject
> >* re-formatted the required properties
> >
> > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
> > 1 file changed, 17 insertions(+), 12 deletions(-)
> >
> >diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >index b519503..4717bc2 100644
> >--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
> > interface contains.
> >
> > Required properties:
> >-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> >- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> >- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> >- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> >- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> >- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> >- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> >- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
> >- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
> >+- compatible: Must contain one or more of the following:
>
> No, it can't contain more than one SoC specific value.
The text above does not say it can unless one is under the delusion
that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
If you would prefer an alternate wording please provide a suggestion.
> >+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> >+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
> >+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
> >+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
> >+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
> >+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
> >+ - "renesas,etheravb-rcar-gen2" as a fallback for the above
> >+ R-Car Gen2 and RZ/G1 devices.
> >
> >- When compatible with the generic version, nodes must list the
> >- SoC-specific version corresponding to the platform first
> >- followed by the generic version.
> >+ - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
> >+ - "renesas,etheravb-r8a7796" for the R8A7796 SoC.
>
> Neither here.
>
> >+ - "renesas,etheravb-rcar-gen3" as a fallback for the above
> >+ R-Car Gen3 devices.
> >+
> >+ When compatible with the generic version, nodes must list the
> >+ SoC-specific version corresponding to the platform first followed by
> >+ the generic version.
> >
> > - reg: offset and length of (1) the register block and (2) the stream buffer.
> > - interrupts: A list of interrupt-specifiers, one for each entry in
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 12:21 ` Simon Horman
0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-11 12:21 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 11, 2017 at 03:12:14PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 07/10/2017 06:32 PM, Biju Das wrote:
>
> >Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> >Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >---
> >v1->v2
> >* Changed the subject
> >* re-formatted the required properties
> >
> > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
> > 1 file changed, 17 insertions(+), 12 deletions(-)
> >
> >diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >index b519503..4717bc2 100644
> >--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
> > interface contains.
> >
> > Required properties:
> >-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> >- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> >- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> >- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> >- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> >- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> >- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> >- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
> >- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
> >+- compatible: Must contain one or more of the following:
>
> No, it can't contain more than one SoC specific value.
The text above does not say it can unless one is under the delusion
that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
If you would prefer an alternate wording please provide a suggestion.
> >+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> >+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
> >+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
> >+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
> >+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
> >+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
> >+ - "renesas,etheravb-rcar-gen2" as a fallback for the above
> >+ R-Car Gen2 and RZ/G1 devices.
> >
> >- When compatible with the generic version, nodes must list the
> >- SoC-specific version corresponding to the platform first
> >- followed by the generic version.
> >+ - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
> >+ - "renesas,etheravb-r8a7796" for the R8A7796 SoC.
>
> Neither here.
>
> >+ - "renesas,etheravb-rcar-gen3" as a fallback for the above
> >+ R-Car Gen3 devices.
> >+
> >+ When compatible with the generic version, nodes must list the
> >+ SoC-specific version corresponding to the platform first followed by
> >+ the generic version.
> >
> > - reg: offset and length of (1) the register block and (2) the stream buffer.
> > - interrupts: A list of interrupt-specifiers, one for each entry in
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-11 12:21 ` Simon Horman
(?)
@ 2017-07-11 12:51 ` Sergei Shtylyov
-1 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-11 12:51 UTC (permalink / raw)
To: Simon Horman
Cc: Biju Das, Rob Herring, Mark Rutland, Russell King,
David S. Miller, Magnus Damm, Chris Paterson,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA
On 07/11/2017 03:21 PM, Simon Horman wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
>>> interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> The text above does not say it can unless one is under the delusion
> that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
Hm, you're right. Sorry about my misunderstanding...
The only problem I'm still seeing with the current wording is that gen2/3
fallback
values are declared optional, while you can't get the driver to bind without
them on
the newer SoCs. But this is probably not a new problem...
> If you would prefer an alternate wording please provide a suggestion.
Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
>>> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
>>> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
>>> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
>>> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
>>> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
>>> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
>>> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
>>> + R-Car Gen2 and RZ/G1 devices.
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 12:51 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-11 12:51 UTC (permalink / raw)
To: Simon Horman
Cc: Biju Das, Rob Herring, Mark Rutland, Russell King,
David S. Miller, Magnus Damm, Chris Paterson, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
On 07/11/2017 03:21 PM, Simon Horman wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
>>> interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> The text above does not say it can unless one is under the delusion
> that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
Hm, you're right. Sorry about my misunderstanding...
The only problem I'm still seeing with the current wording is that gen2/3
fallback
values are declared optional, while you can't get the driver to bind without
them on
the newer SoCs. But this is probably not a new problem...
> If you would prefer an alternate wording please provide a suggestion.
Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
>>> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
>>> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
>>> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
>>> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
>>> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
>>> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
>>> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
>>> + R-Car Gen2 and RZ/G1 devices.
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 12:51 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-11 12:51 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2017 03:21 PM, Simon Horman wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
>>> interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> The text above does not say it can unless one is under the delusion
> that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
Hm, you're right. Sorry about my misunderstanding...
The only problem I'm still seeing with the current wording is that gen2/3
fallback
values are declared optional, while you can't get the driver to bind without
them on
the newer SoCs. But this is probably not a new problem...
> If you would prefer an alternate wording please provide a suggestion.
Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
>>> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
>>> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
>>> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
>>> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
>>> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
>>> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
>>> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
>>> + R-Car Gen2 and RZ/G1 devices.
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-11 12:20 ` Chris Paterson
@ 2017-07-11 12:55 ` Sergei Shtylyov
-1 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-11 12:55 UTC (permalink / raw)
To: Chris Paterson, Biju Das, Rob Herring, Mark Rutland, Russell King
Cc: David S. Miller, Simon Horman, Magnus Damm, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
On 07/11/2017 03:20 PM, Chris Paterson wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------
>> ---
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device
>>> node for the Ethernet AVB interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
>> SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible
>> interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible
>> interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example?
>
> As indeed dictated by the instruction further down:
Yes. Sorry, I should have been more attentive.
>>> + When compatible with the generic version, nodes must list the
>>> + SoC-specific version corresponding to the platform first followed by
>>> + the generic version.
> Kind regards, Chris
MBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-11 12:55 ` Sergei Shtylyov
0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-07-11 12:55 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2017 03:20 PM, Chris Paterson wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------
>> ---
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device
>>> node for the Ethernet AVB interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
>> SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible
>> interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible
>> interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example?
>
> As indeed dictated by the instruction further down:
Yes. Sorry, I should have been more attentive.
>>> + When compatible with the generic version, nodes must list the
>>> + SoC-specific version corresponding to the platform first followed by
>>> + the generic version.
> Kind regards, Chris
MBR, Sergei
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
2017-07-11 12:51 ` Sergei Shtylyov
@ 2017-07-12 5:52 ` Simon Horman
-1 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-12 5:52 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Biju Das, Rob Herring, Mark Rutland, Russell King,
David S. Miller, Magnus Damm, Chris Paterson, devicetree,
linux-renesas-soc, linux-arm-kernel, netdev
On Tue, Jul 11, 2017 at 03:51:40PM +0300, Sergei Shtylyov wrote:
> On 07/11/2017 03:21 PM, Simon Horman wrote:
>
> >>>Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >>>
> >>>Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >>>---
> >>>v1->v2
> >>>* Changed the subject
> >>>* re-formatted the required properties
> >>>
> >>>.../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
> >>>1 file changed, 17 insertions(+), 12 deletions(-)
> >>>
> >>>diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >>>index b519503..4717bc2 100644
> >>>--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >>>+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >>>@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
> >>>interface contains.
> >>>
> >>>Required properties:
> >>>-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> >>>- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> >>>- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> >>>- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> >>>- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> >>>- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> >>>- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> >>>- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
> >>>- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
> >>>+- compatible: Must contain one or more of the following:
> >>
> >> No, it can't contain more than one SoC specific value.
> >
> >The text above does not say it can unless one is under the delusion
> >that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
>
> Hm, you're right. Sorry about my misunderstanding...
>
> The only problem I'm still seeing with the current wording is that gen2/3
> fallback
> values are declared optional, while you can't get the driver to bind without
> them on
> the newer SoCs. But this is probably not a new problem...
>
> >If you would prefer an alternate wording please provide a suggestion.
>
> Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
It's only mandatory for SoCs covered by those values - admittedly all SoCs
supported by the driver at this time. But that is an artifact of the
implementation rather than a property of the binding.
In any case I think is already described sufficiently in:
When compatible with the generic version, nodes must list the
SoC-specific version corresponding to the platform first followed by
the generic version.
> >>>+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> >>>+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
> >>>+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
> >>>+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
> >>>+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
> >>>+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
> >>>+ - "renesas,etheravb-rcar-gen2" as a fallback for the above
> >>>+ R-Car Gen2 and RZ/G1 devices.
> [...]
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
@ 2017-07-12 5:52 ` Simon Horman
0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-07-12 5:52 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 11, 2017 at 03:51:40PM +0300, Sergei Shtylyov wrote:
> On 07/11/2017 03:21 PM, Simon Horman wrote:
>
> >>>Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >>>
> >>>Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >>>---
> >>>v1->v2
> >>>* Changed the subject
> >>>* re-formatted the required properties
> >>>
> >>>.../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
> >>>1 file changed, 17 insertions(+), 12 deletions(-)
> >>>
> >>>diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >>>index b519503..4717bc2 100644
> >>>--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >>>+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >>>@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
> >>>interface contains.
> >>>
> >>>Required properties:
> >>>-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
> >>>- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> >>>- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> >>>- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> >>>- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> >>>- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> >>>- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> >>>- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
> >>>- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
> >>>+- compatible: Must contain one or more of the following:
> >>
> >> No, it can't contain more than one SoC specific value.
> >
> >The text above does not say it can unless one is under the delusion
> >that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
>
> Hm, you're right. Sorry about my misunderstanding...
>
> The only problem I'm still seeing with the current wording is that gen2/3
> fallback
> values are declared optional, while you can't get the driver to bind without
> them on
> the newer SoCs. But this is probably not a new problem...
>
> >If you would prefer an alternate wording please provide a suggestion.
>
> Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
It's only mandatory for SoCs covered by those values - admittedly all SoCs
supported by the driver at this time. But that is an artifact of the
implementation rather than a property of the binding.
In any case I think is already described sufficiently in:
When compatible with the generic version, nodes must list the
SoC-specific version corresponding to the platform first followed by
the generic version.
> >>>+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> >>>+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
> >>>+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
> >>>+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
> >>>+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
> >>>+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
> >>>+ - "renesas,etheravb-rcar-gen2" as a fallback for the above
> >>>+ R-Car Gen2 and RZ/G1 devices.
> [...]
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 66+ messages in thread
end of thread, other threads:[~2017-07-12 5:52 UTC | newest]
Thread overview: 66+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 13:01 [PATCH v 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support Biju Das
2017-07-05 13:01 ` Biju Das
2017-07-05 13:01 ` [PATCH v 1/2] ravb: Add support for r8a7743 SoC Biju Das
2017-07-05 13:01 ` Biju Das
2017-07-05 13:20 ` Sergei Shtylyov
2017-07-05 13:20 ` Sergei Shtylyov
[not found] ` <afcd181c-c805-8f3c-955f-652d001a03d4-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-07-05 15:02 ` Biju Das
2017-07-05 15:02 ` Biju Das
2017-07-05 15:02 ` Biju Das
2017-07-05 15:56 ` [PATCH v2 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support Biju Das
2017-07-05 15:56 ` Biju Das
2017-07-05 15:56 ` [PATCH v2 1/2] ravb: Document binding for r8a7743 SoC Biju Das
2017-07-05 15:56 ` Biju Das
[not found] ` <1499270189-29945-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-05 15:56 ` [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB Biju Das
2017-07-05 15:56 ` Biju Das
2017-07-05 15:56 ` Biju Das
[not found] ` <1499270189-29945-3-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-05 16:13 ` Sergei Shtylyov
2017-07-05 16:13 ` Sergei Shtylyov
2017-07-05 16:13 ` Sergei Shtylyov
2017-07-06 8:05 ` Chris Paterson
2017-07-06 8:05 ` Chris Paterson
2017-07-06 8:05 ` Chris Paterson
2017-07-10 8:38 ` Simon Horman
2017-07-10 8:38 ` Simon Horman
2017-07-05 13:47 ` [PATCH v 1/2] ravb: Add support for r8a7743 SoC Geert Uytterhoeven
2017-07-05 13:47 ` Geert Uytterhoeven
2017-07-05 13:47 ` Geert Uytterhoeven
2017-07-05 13:51 ` Chris Paterson
2017-07-05 13:51 ` Chris Paterson
2017-07-05 14:55 ` Geert Uytterhoeven
2017-07-05 14:55 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUXxHU8JaO0riJ7h7hJpCwAw27titTfo3Ox6CqO3i8E9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-05 14:59 ` Chris Paterson
2017-07-05 14:59 ` Chris Paterson
2017-07-05 14:59 ` Chris Paterson
[not found] ` <1499259711-56175-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-10 1:20 ` Rob Herring
2017-07-10 1:20 ` Rob Herring
2017-07-10 1:20 ` Rob Herring
2017-07-10 8:20 ` Biju Das
2017-07-10 8:20 ` Biju Das
2017-07-10 9:31 ` Sergei Shtylyov
2017-07-10 9:31 ` Sergei Shtylyov
2017-07-10 15:32 ` [PATCH v2] dt-bindings: net: ravb : " Biju Das
2017-07-10 15:32 ` Biju Das
[not found] ` <1499700776-54504-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-10 15:51 ` Geert Uytterhoeven
2017-07-10 15:51 ` Geert Uytterhoeven
2017-07-10 15:51 ` Geert Uytterhoeven
2017-07-11 9:07 ` Simon Horman
2017-07-11 9:07 ` Simon Horman
2017-07-11 12:12 ` Sergei Shtylyov
2017-07-11 12:12 ` Sergei Shtylyov
[not found] ` <52eb0b92-5d25-e1f4-df54-e4fcf648c90e-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-07-11 12:20 ` Chris Paterson
2017-07-11 12:20 ` Chris Paterson
2017-07-11 12:20 ` Chris Paterson
2017-07-11 12:55 ` Sergei Shtylyov
2017-07-11 12:55 ` Sergei Shtylyov
2017-07-11 12:21 ` Simon Horman
2017-07-11 12:21 ` Simon Horman
[not found] ` <20170711122100.GM4517-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-07-11 12:51 ` Sergei Shtylyov
2017-07-11 12:51 ` Sergei Shtylyov
2017-07-11 12:51 ` Sergei Shtylyov
2017-07-12 5:52 ` Simon Horman
2017-07-12 5:52 ` Simon Horman
2017-07-05 13:01 ` [PATCH v 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB Biju Das
2017-07-05 13:01 ` Biju Das
2017-07-05 13:45 ` Geert Uytterhoeven
2017-07-05 13:45 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.