From: Hanjie Lin <hanjie.lin@amlogic.com>
To: Rob Herring <robh@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Kevin Hilman <khilman@baylibre.com>,
Yue Wang <yue.wang@amlogic.com>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
Carlo Caione <carlo@caione.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Liang Yang <liang.yang@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>
Subject: Re: [PATCH v6 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings
Date: Sun, 19 Jan 2020 10:54:46 +0800 [thread overview]
Message-ID: <12c5287e-61af-0712-ae5b-019b8495055b@amlogic.com> (raw)
In-Reply-To: <20200117163219.GA25603@bogus>
On 2020/1/18 0:32, Rob Herring wrote:
> On Fri, 17 Jan 2020 08:21:40 +0800, Hanjie Lin wrote:
>> The Amlogic A1 SoC Family embeds 1 USB Controllers:
>> - a DWC3 IP configured as Host for USB2 and USB3
>>
>> A glue connects the controllers to the USB2 PHY of A1 SoC.
>>
>> Signed-off-by: Yue Wang <yue.wang@amlogic.com>
>> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com>
>> ---
>> .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 38 ++++++++++++++++++++--
>> 1 file changed, 35 insertions(+), 3 deletions(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml: while parsing a block mapping
> in "<unicode string>", line 107, column 7
> did not find expected key
> in "<unicode string>", line 111, column 8
> Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts' failed
> make[1]: *** [Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts] Error 1
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1224563
> Please check and re-submit.
>
> .
>
Hi Rob,
Sorry, I missed a blank and didn't notice it.
I will fix it in next version, and also pay more attentions to these problems later.
Thanks,
Hanjie
WARNING: multiple messages have this Message-ID (diff)
From: Hanjie Lin <hanjie.lin@amlogic.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Victor Wan <victor.wan@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-usb@vger.kernel.org, Yue Wang <yue.wang@amlogic.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jian Hu <jian.hu@amlogic.com>,
Liang Yang <liang.yang@amlogic.com>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v6 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings
Date: Sun, 19 Jan 2020 10:54:46 +0800 [thread overview]
Message-ID: <12c5287e-61af-0712-ae5b-019b8495055b@amlogic.com> (raw)
In-Reply-To: <20200117163219.GA25603@bogus>
On 2020/1/18 0:32, Rob Herring wrote:
> On Fri, 17 Jan 2020 08:21:40 +0800, Hanjie Lin wrote:
>> The Amlogic A1 SoC Family embeds 1 USB Controllers:
>> - a DWC3 IP configured as Host for USB2 and USB3
>>
>> A glue connects the controllers to the USB2 PHY of A1 SoC.
>>
>> Signed-off-by: Yue Wang <yue.wang@amlogic.com>
>> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com>
>> ---
>> .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 38 ++++++++++++++++++++--
>> 1 file changed, 35 insertions(+), 3 deletions(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml: while parsing a block mapping
> in "<unicode string>", line 107, column 7
> did not find expected key
> in "<unicode string>", line 111, column 8
> Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts' failed
> make[1]: *** [Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts] Error 1
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1224563
> Please check and re-submit.
>
> .
>
Hi Rob,
Sorry, I missed a blank and didn't notice it.
I will fix it in next version, and also pay more attentions to these problems later.
Thanks,
Hanjie
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Hanjie Lin <hanjie.lin@amlogic.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Victor Wan <victor.wan@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-usb@vger.kernel.org, Yue Wang <yue.wang@amlogic.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jian Hu <jian.hu@amlogic.com>,
Liang Yang <liang.yang@amlogic.com>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v6 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings
Date: Sun, 19 Jan 2020 10:54:46 +0800 [thread overview]
Message-ID: <12c5287e-61af-0712-ae5b-019b8495055b@amlogic.com> (raw)
In-Reply-To: <20200117163219.GA25603@bogus>
On 2020/1/18 0:32, Rob Herring wrote:
> On Fri, 17 Jan 2020 08:21:40 +0800, Hanjie Lin wrote:
>> The Amlogic A1 SoC Family embeds 1 USB Controllers:
>> - a DWC3 IP configured as Host for USB2 and USB3
>>
>> A glue connects the controllers to the USB2 PHY of A1 SoC.
>>
>> Signed-off-by: Yue Wang <yue.wang@amlogic.com>
>> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com>
>> ---
>> .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 38 ++++++++++++++++++++--
>> 1 file changed, 35 insertions(+), 3 deletions(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml: while parsing a block mapping
> in "<unicode string>", line 107, column 7
> did not find expected key
> in "<unicode string>", line 111, column 8
> Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts' failed
> make[1]: *** [Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts] Error 1
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1224563
> Please check and re-submit.
>
> .
>
Hi Rob,
Sorry, I missed a blank and didn't notice it.
I will fix it in next version, and also pay more attentions to these problems later.
Thanks,
Hanjie
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-01-19 2:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 0:21 [PATCH v6 0/6] arm64: meson: Add support for USB on Amlogic A1 Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` [PATCH v6 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 16:36 ` Rob Herring
2020-01-17 16:36 ` Rob Herring
2020-01-17 16:36 ` Rob Herring
2020-01-17 0:21 ` [PATCH v6 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 16:32 ` Rob Herring
2020-01-17 16:32 ` Rob Herring
2020-01-17 16:32 ` Rob Herring
2020-01-19 2:54 ` Hanjie Lin [this message]
2020-01-19 2:54 ` Hanjie Lin
2020-01-19 2:54 ` Hanjie Lin
2020-01-17 0:21 ` [PATCH v6 3/6] phy: amlogic: Add Amlogic A1 USB2 PHY Driver Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` [PATCH v6 4/6] usb: dwc3: Add Amlogic A1 DWC3 glue Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-18 22:00 ` Martin Blumenstingl
2020-01-18 22:00 ` Martin Blumenstingl
2020-01-18 22:00 ` Martin Blumenstingl
2020-01-17 0:21 ` [PATCH v6 5/6] arm64: dts: meson: a1: Enable USB2 PHY Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-18 22:05 ` Martin Blumenstingl
2020-01-18 22:05 ` Martin Blumenstingl
2020-01-18 22:05 ` Martin Blumenstingl
2020-01-19 3:01 ` Hanjie Lin
2020-01-19 3:01 ` Hanjie Lin
2020-01-19 3:01 ` Hanjie Lin
2020-01-17 0:21 ` [PATCH v6 6/6] arm64: dts: meson: a1: Enable DWC3 controller Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
2020-01-17 0:21 ` Hanjie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c5287e-61af-0712-ae5b-019b8495055b@amlogic.com \
--to=hanjie.lin@amlogic.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=victor.wan@amlogic.com \
--cc=xingyu.chen@amlogic.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.