All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: David Miller <davem@davemloft.net>, <ivan.khoronzhuk@linaro.org>
Cc: <linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <alexander.h.duyck@intel.com>,
	<bjorn@mork.no>
Subject: Re: [PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast
Date: Thu, 25 Oct 2018 14:25:27 -0500	[thread overview]
Message-ID: <12ca7599-e5f0-087f-674d-a887f3768913@ti.com> (raw)
In-Reply-To: <20181025.113441.567599603045046210.davem@davemloft.net>

Hi David,

On 10/25/18 1:34 PM, David Miller wrote:
> From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Date: Thu, 25 Oct 2018 01:10:55 +0300
> 
>> The cpsw holds separate mcast entires for vlan entries. At this moment
>> driver adds only not vlan mcast addresses, omitting vlan/mcast entries.
>> As result mcast for vlans doesn't work. It can be fixed by adding same
>> mcast entries for every created vlan, but this patchseries uses more
>> sophisticated way and allows to create mcast entries only for vlans
>> that really require it. Generic functions from this series can be
>> reused for fixing vlan and macvlan unicast.
> 
> This is a bug fix but targetted at net-next, and indeed it is quite
> invasive as it adds new core infrastructure and converts the generic
> vlan code over to using it.
> 
> Unfortunately net-next is closed.
> 
> So if you want this bug fixed in mainline you will have to come up
> with a less invasive fix, and resubmit this net-next approach when the
> net-next tree opens back up.

I think it's ok to wait as this issue was always here, so it's not critical.

-- 
regards,
-grygorii

WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: David Miller <davem@davemloft.net>, ivan.khoronzhuk@linaro.org
Cc: linux-omap@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, alexander.h.duyck@intel.com,
	bjorn@mork.no
Subject: Re: [PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast
Date: Thu, 25 Oct 2018 14:25:27 -0500	[thread overview]
Message-ID: <12ca7599-e5f0-087f-674d-a887f3768913@ti.com> (raw)
In-Reply-To: <20181025.113441.567599603045046210.davem@davemloft.net>

Hi David,

On 10/25/18 1:34 PM, David Miller wrote:
> From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Date: Thu, 25 Oct 2018 01:10:55 +0300
> 
>> The cpsw holds separate mcast entires for vlan entries. At this moment
>> driver adds only not vlan mcast addresses, omitting vlan/mcast entries.
>> As result mcast for vlans doesn't work. It can be fixed by adding same
>> mcast entries for every created vlan, but this patchseries uses more
>> sophisticated way and allows to create mcast entries only for vlans
>> that really require it. Generic functions from this series can be
>> reused for fixing vlan and macvlan unicast.
> 
> This is a bug fix but targetted at net-next, and indeed it is quite
> invasive as it adds new core infrastructure and converts the generic
> vlan code over to using it.
> 
> Unfortunately net-next is closed.
> 
> So if you want this bug fixed in mainline you will have to come up
> with a less invasive fix, and resubmit this net-next approach when the
> net-next tree opens back up.

I think it's ok to wait as this issue was always here, so it's not critical.

-- 
regards,
-grygorii

  reply	other threads:[~2018-10-25 19:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 22:10 [PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast Ivan Khoronzhuk
2018-10-24 22:10 ` [PATCH net-next 1/4] net: core: dev_addr_lists: add auxiliary func to handle reference address updates Ivan Khoronzhuk
2018-10-24 22:10 ` [PATCH net-next 2/4] net: 8021q: vlan_core: allow use list of vlans for real device Ivan Khoronzhuk
2018-10-24 22:10 ` [PATCH net-next 3/4] net: ethernet: ti: cpsw: fix vlan mcast Ivan Khoronzhuk
2018-10-24 22:10 ` [PATCH net-next 4/4] net: ethernet: ti: cpsw: fix vlan configuration while down/up Ivan Khoronzhuk
2018-10-25 18:34 ` [PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast David Miller
2018-10-25 19:25   ` Grygorii Strashko [this message]
2018-10-25 19:25     ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12ca7599-e5f0-087f-674d-a887f3768913@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.