All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Watt <jpewhacker@gmail.com>,
	Alexander Kanavin <alex.kanavin@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 04/10] lib/oe/package_manager: turn postinst_intercept warnings into failures for nativesdk
Date: Fri, 25 Jan 2019 15:38:57 +0000	[thread overview]
Message-ID: <12e06882b3c8cf4e17e0e6663dc8fa50c770d46a.camel@linuxfoundation.org> (raw)
In-Reply-To: <c207a65d9262320feaf5d32ee7d906beee506102.camel@gmail.com>

On Fri, 2019-01-25 at 09:37 -0600, Joshua Watt wrote:
> On Fri, 2019-01-25 at 13:13 +0100, Alexander Kanavin wrote:
> > There is a similar issue in multilib for target packages (a warning
> > because qemu usermode support is missing):
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/214/steps/7/logs/warnings
> > 
> > I'm as well not sure how to handle this:
> > 1. Keep these two warnings as warnings so users see them in their
> > local builds, but
> >  add some kind of string pattern to AB so it excludes missing qemu
> > support and missing wine support warnings.
> > 
> > 2. Turn them into notes, which means they will go to the logs only,
> > and users are not going to see them ever. On the other hand, the
> > postinsts tend to
> > create things like font caches and similar, which should not
> > generally
> > be needed at compile time (which is what SDKs are for).
> > 
> > I'm leaning towards option two.
> 
> I was leaning toward keeping them warnings and then suppressing them in
> the cases where we know they don't work and are unnecessary (perhaps
> with a variable like POSTINST_INTERCEPT_${PN} = "0" ?)
> 
> That way if a user enables a package where it's not going to run and we
> haven't previously evaluated it to be OK, they will at least see the
> warning. I naively think this might help reduce the number of bugs
> filed, or at least make them easier to triage :)

I think this may be safer...

Cheers,

Richard



  reply	other threads:[~2019-01-25 15:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 16:17 [PATCH 01/10] sstate.bbclass: make sure changes to SSTATE_SCAN_FILES are not ignored Alexander Kanavin
2019-01-23 16:17 ` [PATCH 02/10] fontcache: fix postinst for nativesdk case Alexander Kanavin
2019-01-23 16:17 ` [PATCH 03/10] qemuwrapper-cross: check qemu usermode only when building a target package Alexander Kanavin
2019-01-23 16:17 ` [PATCH 04/10] lib/oe/package_manager: turn postinst_intercept warnings into failures for nativesdk Alexander Kanavin
2019-01-24 22:43   ` Richard Purdie
2019-01-24 23:18     ` Joshua Watt
2019-01-25 12:13       ` Alexander Kanavin
2019-01-25 15:37         ` Joshua Watt
2019-01-25 15:38           ` Richard Purdie [this message]
2019-01-25 16:10             ` Alexander Kanavin
2019-01-25 16:33               ` Joshua Watt
2019-01-25 17:21                 ` Alexander Kanavin
2019-01-23 16:17 ` [PATCH 05/10] cmake: do not look into native sysroot in the nativesdk environment Alexander Kanavin
2019-01-23 16:17 ` [PATCH 06/10] testimage.bbclass: add support for passing runqemu params Alexander Kanavin
2019-01-23 16:17 ` [PATCH 07/10] kmscube: update to latest commit, switch over to meson Alexander Kanavin
2019-01-23 16:17 ` [PATCH 08/10] kmscube: make gstreamer dependency optional Alexander Kanavin
2019-01-23 16:17 ` [PATCH 09/10] lib/oe/reciputils.py: parallelize upstream version checks Alexander Kanavin
2019-01-23 16:17 ` [PATCH 10/10] devtool: add a command to print an overall list of recipes that can be updated Alexander Kanavin
2019-01-23 23:31   ` akuster808

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12e06882b3c8cf4e17e0e6663dc8fa50c770d46a.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=jpewhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.