Re: [PATCH 04/10] lib/oe/package_manager: turn postinst_intercept warnings into failures for nativesdk

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2019-01-23 at 17:17 +0100, Alexander Kanavin wrote:
> The few cases where they failed should be now all fixed. The only allowed
> exception is when building mingw32 SDKs, as there is currently no support for running
> postinst_intercepts through wine.
> 
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>  meta/lib/oe/package_manager.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
> index 1087144d47f..f26f597d03d 100644
> --- a/meta/lib/oe/package_manager.py
> +++ b/meta/lib/oe/package_manager.py
> @@ -439,6 +439,11 @@ class PackageManager(object, metaclass=ABCMeta):
>                  self._postpone_to_first_boot(script_full)
>                  continue
>  
> +            if populate_sdk == 'host' and self.d.getVar('SDK_OS') == 'mingw32':
> +                bb.warn("The postinstall intercept hook '%s' could not be executed due to missing wine support, details in %s/log.do_%s"
> +                                % (script, self.d.getVar('T'), self.d.getVar('BB_CURRENTTASK')))
> +                continue
> +
>              bb.note("> Executing %s intercept ..." % script)
>  
>              try:
> @@ -447,7 +452,7 @@ class PackageManager(object, metaclass=ABCMeta):
>              except subprocess.CalledProcessError as e:
>                  bb.note("Exit code %d. Output:\n%s" % (e.returncode, e.output.decode("utf-8")))
>                  if populate_sdk == 'host':
> -                    bb.warn("The postinstall intercept hook '%s' failed, details in %s/log.do_%s" % (script, self.d.getVar('T'), self.d.getVar('BB_CURRENTTASK')))
> +                    bb.fatal("The postinstall intercept hook '%s' failed, details in %s/log.do_%s" % (script, self.d.getVar('T'), self.d.getVar('BB_CURRENTTASK')))
>                  elif populate_sdk == 'target':
>                      if "qemuwrapper: qemu usermode is not supported" in e.output.decode("utf-8"):
>                          bb.warn("The postinstall intercept hook '%s' could not be executed due to missing qemu usermode support, details in %s/log.do_%s"

I'm ok with this but could we change the bb.warn to something less
important like a note?

The reason I say this is that I'd like to get the autobuilder to the
point where its warning free. This warning is the only reason meta-
mingw shows warnings now. Either we fix them or if we can't, they
probably aren't warnings.

What should we do here?

(also cc'd Joshua)

Cheers,

Richard