* [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
@ 2020-12-15 10:30 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2020-12-15 10:30 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Catalin Marinas, Will Deacon
Cc: Gavin Shan, linux-arm-kernel, linux-kernel, Geert Uytterhoeven
arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
| ^~~
The removal of the last user forgot to remove the variable.
Fixes: 2f516e34383d0e97 ("arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
One more issue in irq-core-2020-12-14.
arch/arm64/kernel/smp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 3aef3bc22d3250b5..10b39328268687e3 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -805,7 +805,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
unsigned int cpu, i;
for (i = 0; i < NR_IPI; i++) {
- unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
prec >= 4 ? " " : "");
for_each_online_cpu(cpu)
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
@ 2020-12-15 10:30 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2020-12-15 10:30 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Catalin Marinas, Will Deacon
Cc: Geert Uytterhoeven, Gavin Shan, linux-kernel, linux-arm-kernel
arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
| ^~~
The removal of the last user forgot to remove the variable.
Fixes: 2f516e34383d0e97 ("arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
One more issue in irq-core-2020-12-14.
arch/arm64/kernel/smp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 3aef3bc22d3250b5..10b39328268687e3 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -805,7 +805,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
unsigned int cpu, i;
for (i = 0; i < NR_IPI; i++) {
- unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
prec >= 4 ? " " : "");
for_each_online_cpu(cpu)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
2020-12-15 10:30 ` Geert Uytterhoeven
(?)
@ 2020-12-15 16:07 ` kernel test robot
2020-12-15 16:11 ` Geert Uytterhoeven
-1 siblings, 1 reply; 12+ messages in thread
From: kernel test robot @ 2020-12-15 16:07 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3817 bytes --]
Hi Geert,
I love your patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on v5.10 next-20201215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/arm64-smp-Remove-unused-irq-variable-in-arch_show_interrupts/20201215-183804
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/846fff4a14d7c14a353d85b97cf8fbd625f4a887
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/arm64-smp-Remove-unused-irq-variable-in-arch_show_interrupts/20201215-183804
git checkout 846fff4a14d7c14a353d85b97cf8fbd625f4a887
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/arm64/kernel/smp.c: In function 'arch_show_interrupts':
>> arch/arm64/kernel/smp.c:811:42: error: 'irq' undeclared (first use in this function); did you mean 'rq'?
811 | seq_printf(p, "%10u ", kstat_irqs_cpu(irq, cpu));
| ^~~
| rq
arch/arm64/kernel/smp.c:811:42: note: each undeclared identifier is reported only once for each function it appears in
arch/arm64/kernel/smp.c: At top level:
arch/arm64/kernel/smp.c:837:6: warning: no previous prototype for 'arch_irq_work_raise' [-Wmissing-prototypes]
837 | void arch_irq_work_raise(void)
| ^~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/smp.c:857:6: warning: no previous prototype for 'panic_smp_self_stop' [-Wmissing-prototypes]
857 | void panic_smp_self_stop(void)
| ^~~~~~~~~~~~~~~~~~~
vim +811 arch/arm64/kernel/smp.c
a263881525310e1 Marc Zyngier 2020-06-20 802
a263881525310e1 Marc Zyngier 2020-06-20 803 int arch_show_interrupts(struct seq_file *p, int prec)
08e875c16a16c95 Catalin Marinas 2012-03-05 804 {
08e875c16a16c95 Catalin Marinas 2012-03-05 805 unsigned int cpu, i;
08e875c16a16c95 Catalin Marinas 2012-03-05 806
08e875c16a16c95 Catalin Marinas 2012-03-05 807 for (i = 0; i < NR_IPI; i++) {
45ed695ac10a23c Nicolas Pitre 2014-07-25 808 seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
08e875c16a16c95 Catalin Marinas 2012-03-05 809 prec >= 4 ? " " : "");
67317c2689567c2 Sudeep Holla 2013-11-07 810 for_each_online_cpu(cpu)
a263881525310e1 Marc Zyngier 2020-06-20 @811 seq_printf(p, "%10u ", kstat_irqs_cpu(irq, cpu));
08e875c16a16c95 Catalin Marinas 2012-03-05 812 seq_printf(p, " %s\n", ipi_types[i]);
08e875c16a16c95 Catalin Marinas 2012-03-05 813 }
08e875c16a16c95 Catalin Marinas 2012-03-05 814
a263881525310e1 Marc Zyngier 2020-06-20 815 seq_printf(p, "%*s: %10lu\n", prec, "Err", irq_err_count);
a263881525310e1 Marc Zyngier 2020-06-20 816 return 0;
08e875c16a16c95 Catalin Marinas 2012-03-05 817 }
08e875c16a16c95 Catalin Marinas 2012-03-05 818
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 75560 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
2020-12-15 16:07 ` kernel test robot
@ 2020-12-15 16:11 ` Geert Uytterhoeven
2020-12-16 8:05 ` Rong Chen
0 siblings, 1 reply; 12+ messages in thread
From: Geert Uytterhoeven @ 2020-12-15 16:11 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
Dear Robot,
On Tue, Dec 15, 2020 at 5:07 PM kernel test robot <lkp@intel.com> wrote:
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on arm64/for-next/core]
> [also build test ERROR on v5.10 next-20201215]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
Indeed, none of the above contain the commit mentioned in the Fixes tag.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
2020-12-15 16:11 ` Geert Uytterhoeven
@ 2020-12-16 8:05 ` Rong Chen
2020-12-16 8:12 ` Geert Uytterhoeven
0 siblings, 1 reply; 12+ messages in thread
From: Rong Chen @ 2020-12-16 8:05 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On 12/16/20 12:11 AM, Geert Uytterhoeven wrote:
> Dear Robot,
>
> On Tue, Dec 15, 2020 at 5:07 PM kernel test robot <lkp@intel.com> wrote:
>> I love your patch! Yet something to improve:
>>
>> [auto build test ERROR on arm64/for-next/core]
>> [also build test ERROR on v5.10 next-20201215]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
> Indeed, none of the above contain the commit mentioned in the Fixes tag.
>
> Gr{oetje,eeting}s,
>
> Geert
>
Hi Geert,
We have fixed it to find the Fixes tag.
Best Regards,
Rong Chen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
2020-12-16 8:05 ` Rong Chen
@ 2020-12-16 8:12 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2020-12-16 8:12 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
Hi Rong,
On Wed, Dec 16, 2020 at 9:06 AM Rong Chen <rong.a.chen@intel.com> wrote:
> On 12/16/20 12:11 AM, Geert Uytterhoeven wrote:
> > On Tue, Dec 15, 2020 at 5:07 PM kernel test robot <lkp@intel.com> wrote:
> >> I love your patch! Yet something to improve:
> >>
> >> [auto build test ERROR on arm64/for-next/core]
> >> [also build test ERROR on v5.10 next-20201215]
> >> [If your patch is applied to the wrong git tree, kindly drop us a note.
> >> And when submitting patch, we suggest to use '--base' as documented in
> >> https://git-scm.com/docs/git-format-patch]
> > Indeed, none of the above contain the commit mentioned in the Fixes tag.
>
> We have fixed it to find the Fixes tag.
Great, thanks a lot!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
2020-12-15 10:30 ` Geert Uytterhoeven
@ 2020-12-25 7:05 ` Zenghui Yu
-1 siblings, 0 replies; 12+ messages in thread
From: Zenghui Yu @ 2020-12-25 7:05 UTC (permalink / raw)
To: Geert Uytterhoeven, Thomas Gleixner, Marc Zyngier,
Catalin Marinas, Will Deacon
Cc: Gavin Shan, linux-kernel, linux-arm-kernel, wanghaibin.wang
On 2020/12/15 18:30, Geert Uytterhoeven wrote:
> arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
> arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
> 808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> | ^~~
>
> The removal of the last user forgot to remove the variable.
>
> Fixes: 2f516e34383d0e97 ("arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()")
This is in mainline now and the commit id is 5089bc51f81f.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> One more issue in irq-core-2020-12-14.
>
> arch/arm64/kernel/smp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 3aef3bc22d3250b5..10b39328268687e3 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -805,7 +805,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
> unsigned int cpu, i;
>
> for (i = 0; i < NR_IPI; i++) {
> - unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
> prec >= 4 ? " " : "");
> for_each_online_cpu(cpu)
And I guess we have the same problem on 32-bit ARM. 'irq' in
show_ipi_list() is no longer used since commit 88c637748e31
("ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()").
Thanks,
Zenghui
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
@ 2020-12-25 7:05 ` Zenghui Yu
0 siblings, 0 replies; 12+ messages in thread
From: Zenghui Yu @ 2020-12-25 7:05 UTC (permalink / raw)
To: Geert Uytterhoeven, Thomas Gleixner, Marc Zyngier,
Catalin Marinas, Will Deacon
Cc: wanghaibin.wang, Gavin Shan, linux-kernel, linux-arm-kernel
On 2020/12/15 18:30, Geert Uytterhoeven wrote:
> arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
> arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
> 808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> | ^~~
>
> The removal of the last user forgot to remove the variable.
>
> Fixes: 2f516e34383d0e97 ("arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()")
This is in mainline now and the commit id is 5089bc51f81f.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> One more issue in irq-core-2020-12-14.
>
> arch/arm64/kernel/smp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 3aef3bc22d3250b5..10b39328268687e3 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -805,7 +805,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
> unsigned int cpu, i;
>
> for (i = 0; i < NR_IPI; i++) {
> - unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
> prec >= 4 ? " " : "");
> for_each_online_cpu(cpu)
And I guess we have the same problem on 32-bit ARM. 'irq' in
show_ipi_list() is no longer used since commit 88c637748e31
("ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()").
Thanks,
Zenghui
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
2020-12-15 10:30 ` Geert Uytterhoeven
@ 2021-01-04 11:49 ` Catalin Marinas
-1 siblings, 0 replies; 12+ messages in thread
From: Catalin Marinas @ 2021-01-04 11:49 UTC (permalink / raw)
To: Marc Zyngier, Will Deacon, Geert Uytterhoeven, Thomas Gleixner
Cc: linux-arm-kernel, linux-kernel, Gavin Shan
On Tue, 15 Dec 2020 11:30:26 +0100, Geert Uytterhoeven wrote:
> arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
> arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
> 808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> | ^~~
>
> The removal of the last user forgot to remove the variable.
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64/smp: Remove unused irq variable in arch_show_interrupts()
https://git.kernel.org/arm64/c/42e85f90171a
Also adjusted the Fixes tag (before seeing that you posted a v2).
--
Catalin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
@ 2021-01-04 11:49 ` Catalin Marinas
0 siblings, 0 replies; 12+ messages in thread
From: Catalin Marinas @ 2021-01-04 11:49 UTC (permalink / raw)
To: Marc Zyngier, Will Deacon, Geert Uytterhoeven, Thomas Gleixner
Cc: Gavin Shan, linux-kernel, linux-arm-kernel
On Tue, 15 Dec 2020 11:30:26 +0100, Geert Uytterhoeven wrote:
> arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
> arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
> 808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> | ^~~
>
> The removal of the last user forgot to remove the variable.
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64/smp: Remove unused irq variable in arch_show_interrupts()
https://git.kernel.org/arm64/c/42e85f90171a
Also adjusted the Fixes tag (before seeing that you posted a v2).
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
2020-12-25 7:05 ` Zenghui Yu
@ 2021-01-26 10:06 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2021-01-26 10:06 UTC (permalink / raw)
To: Zenghui Yu
Cc: Thomas Gleixner, Marc Zyngier, Catalin Marinas, Will Deacon,
Gavin Shan, Linux Kernel Mailing List, Linux ARM,
wanghaibin.wang
Hi Zenghui,
On Fri, Dec 25, 2020 at 8:05 AM Zenghui Yu <yuzenghui@huawei.com> wrote:
> On 2020/12/15 18:30, Geert Uytterhoeven wrote:
> > arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
> > arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
> > 808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> > | ^~~
> >
> > The removal of the last user forgot to remove the variable.
> >
> > Fixes: 2f516e34383d0e97 ("arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()")
>
> This is in mainline now and the commit id is 5089bc51f81f.
>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > One more issue in irq-core-2020-12-14.
> >
> > arch/arm64/kernel/smp.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> > index 3aef3bc22d3250b5..10b39328268687e3 100644
> > --- a/arch/arm64/kernel/smp.c
> > +++ b/arch/arm64/kernel/smp.c
> > @@ -805,7 +805,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
> > unsigned int cpu, i;
> >
> > for (i = 0; i < NR_IPI; i++) {
> > - unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> > seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
> > prec >= 4 ? " " : "");
> > for_each_online_cpu(cpu)
>
> And I guess we have the same problem on 32-bit ARM. 'irq' in
> show_ipi_list() is no longer used since commit 88c637748e31
> ("ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()").
Indeed. I didn't see it with my compiler version, but Wolfram did, and
sent a patch:
https://lore.kernel.org/linux-arm-kernel/20201228120147.59387-1-wsa+renesas@sang-engineering.com/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts()
@ 2021-01-26 10:06 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2021-01-26 10:06 UTC (permalink / raw)
To: Zenghui Yu
Cc: Gavin Shan, Marc Zyngier, Linux Kernel Mailing List,
Catalin Marinas, wanghaibin.wang, Thomas Gleixner, Will Deacon,
Linux ARM
Hi Zenghui,
On Fri, Dec 25, 2020 at 8:05 AM Zenghui Yu <yuzenghui@huawei.com> wrote:
> On 2020/12/15 18:30, Geert Uytterhoeven wrote:
> > arch/arm64/kernel/smp.c: In function ‘arch_show_interrupts’:
> > arch/arm64/kernel/smp.c:808:16: warning: unused variable ‘irq’ [-Wunused-variable]
> > 808 | unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> > | ^~~
> >
> > The removal of the last user forgot to remove the variable.
> >
> > Fixes: 2f516e34383d0e97 ("arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()")
>
> This is in mainline now and the commit id is 5089bc51f81f.
>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > One more issue in irq-core-2020-12-14.
> >
> > arch/arm64/kernel/smp.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> > index 3aef3bc22d3250b5..10b39328268687e3 100644
> > --- a/arch/arm64/kernel/smp.c
> > +++ b/arch/arm64/kernel/smp.c
> > @@ -805,7 +805,6 @@ int arch_show_interrupts(struct seq_file *p, int prec)
> > unsigned int cpu, i;
> >
> > for (i = 0; i < NR_IPI; i++) {
> > - unsigned int irq = irq_desc_get_irq(ipi_desc[i]);
> > seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
> > prec >= 4 ? " " : "");
> > for_each_online_cpu(cpu)
>
> And I guess we have the same problem on 32-bit ARM. 'irq' in
> show_ipi_list() is no longer used since commit 88c637748e31
> ("ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()").
Indeed. I didn't see it with my compiler version, but Wolfram did, and
sent a patch:
https://lore.kernel.org/linux-arm-kernel/20201228120147.59387-1-wsa+renesas@sang-engineering.com/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-01-26 11:34 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 10:30 [PATCH] arm64/smp: Remove unused irq variable in arch_show_interrupts() Geert Uytterhoeven
2020-12-15 10:30 ` Geert Uytterhoeven
2020-12-15 16:07 ` kernel test robot
2020-12-15 16:11 ` Geert Uytterhoeven
2020-12-16 8:05 ` Rong Chen
2020-12-16 8:12 ` Geert Uytterhoeven
2020-12-25 7:05 ` Zenghui Yu
2020-12-25 7:05 ` Zenghui Yu
2021-01-26 10:06 ` Geert Uytterhoeven
2021-01-26 10:06 ` Geert Uytterhoeven
2021-01-04 11:49 ` Catalin Marinas
2021-01-04 11:49 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.