From: "G, Manjunath Kondaiah" <manjugk@ti.com> To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: khilman@ti.com, paul@pwsan.com, tony@atomide.com Subject: [PATCH v4 4/4] OMAP: DMA: Fix: context restore during off mode Date: Mon, 28 Mar 2011 19:57:02 +0530 [thread overview] Message-ID: <1301322422-29886-5-git-send-email-manjugk@ti.com> (raw) In-Reply-To: <1301322422-29886-1-git-send-email-manjugk@ti.com> The current DMA context restore clears all the DMA channel registers even if the channels are in use. This will result in transfer failures if repeated DMA transfers are initiated with one time DMA channel configuration. Also, remove access to sysconfig register during context save/restore since it will be handled through hwmod layer. Tested on OMAP3430 Zoom2 with - off mode enabled - one time DMA channel configuration - repeated DMA transfers Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com> --- arch/arm/plat-omap/dma.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 3c39794..5c4ae7d 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -2059,29 +2059,20 @@ void omap_dma_global_context_save(void) pm_runtime_get_sync(dev); omap_dma_global_context.dma_irqenable_l0 = p->dma_read(IRQENABLE_L0, 0); - omap_dma_global_context.dma_ocp_sysconfig = - p->dma_read(OCP_SYSCONFIG, 0); omap_dma_global_context.dma_gcr = p->dma_read(GCR, 0); pm_runtime_put_autosuspend(dev); } void omap_dma_global_context_restore(void) { - int ch; - pm_runtime_get_sync(dev); p->dma_write(omap_dma_global_context.dma_gcr, GCR, 0); - p->dma_write(omap_dma_global_context.dma_ocp_sysconfig, - OCP_SYSCONFIG, 0); p->dma_write(omap_dma_global_context.dma_irqenable_l0, IRQENABLE_L0, 0); if (IS_DMA_ERRATA(DMA_ROMCODE_BUG)) p->dma_write(0x3 , IRQSTATUS_L0, 0); - for (ch = 0; ch < dma_chan_count; ch++) - if (dma_chan[ch].dev_id != -1) - omap_clear_dma(ch); pm_runtime_put_autosuspend(dev); } -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: manjugk@ti.com (G, Manjunath Kondaiah) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 4/4] OMAP: DMA: Fix: context restore during off mode Date: Mon, 28 Mar 2011 19:57:02 +0530 [thread overview] Message-ID: <1301322422-29886-5-git-send-email-manjugk@ti.com> (raw) In-Reply-To: <1301322422-29886-1-git-send-email-manjugk@ti.com> The current DMA context restore clears all the DMA channel registers even if the channels are in use. This will result in transfer failures if repeated DMA transfers are initiated with one time DMA channel configuration. Also, remove access to sysconfig register during context save/restore since it will be handled through hwmod layer. Tested on OMAP3430 Zoom2 with - off mode enabled - one time DMA channel configuration - repeated DMA transfers Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com> --- arch/arm/plat-omap/dma.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 3c39794..5c4ae7d 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -2059,29 +2059,20 @@ void omap_dma_global_context_save(void) pm_runtime_get_sync(dev); omap_dma_global_context.dma_irqenable_l0 = p->dma_read(IRQENABLE_L0, 0); - omap_dma_global_context.dma_ocp_sysconfig = - p->dma_read(OCP_SYSCONFIG, 0); omap_dma_global_context.dma_gcr = p->dma_read(GCR, 0); pm_runtime_put_autosuspend(dev); } void omap_dma_global_context_restore(void) { - int ch; - pm_runtime_get_sync(dev); p->dma_write(omap_dma_global_context.dma_gcr, GCR, 0); - p->dma_write(omap_dma_global_context.dma_ocp_sysconfig, - OCP_SYSCONFIG, 0); p->dma_write(omap_dma_global_context.dma_irqenable_l0, IRQENABLE_L0, 0); if (IS_DMA_ERRATA(DMA_ROMCODE_BUG)) p->dma_write(0x3 , IRQSTATUS_L0, 0); - for (ch = 0; ch < dma_chan_count; ch++) - if (dma_chan[ch].dev_id != -1) - omap_clear_dma(ch); pm_runtime_put_autosuspend(dev); } -- 1.7.1
next prev parent reply other threads:[~2011-03-28 14:32 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-28 14:26 [PATCH v4 0/4] OMAP: DMA: mstandby mode and runtime pm support G, Manjunath Kondaiah 2011-03-28 14:26 ` G, Manjunath Kondaiah 2011-03-28 14:26 ` [PATCH v4 1/4] OMAP2+: PM: omap device: API's for handling mstandby mode G, Manjunath Kondaiah 2011-03-28 14:26 ` G, Manjunath Kondaiah 2011-05-06 20:24 ` Paul Walmsley 2011-05-06 20:24 ` Paul Walmsley 2011-03-28 14:27 ` [PATCH v4 2/4] OMAP2+: DMA: prevent races while setting M idle mode to nostandby G, Manjunath Kondaiah 2011-03-28 14:27 ` G, Manjunath Kondaiah 2011-03-28 14:27 ` [PATCH v4 3/4] OMAP: PM: DMA: Enable runtime pm G, Manjunath Kondaiah 2011-03-28 14:27 ` G, Manjunath Kondaiah 2011-03-28 14:27 ` G, Manjunath Kondaiah [this message] 2011-03-28 14:27 ` [PATCH v4 4/4] OMAP: DMA: Fix: context restore during off mode G, Manjunath Kondaiah 2011-04-07 0:45 ` [PATCH v4 0/4] OMAP: DMA: mstandby mode and runtime pm support G, Manjunath Kondaiah 2011-04-07 0:45 ` G, Manjunath Kondaiah 2011-04-19 11:05 ` Tony Lindgren 2011-04-19 11:05 ` Tony Lindgren 2011-04-28 13:56 ` Russell King - ARM Linux 2011-04-28 13:56 ` Russell King - ARM Linux
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1301322422-29886-5-git-send-email-manjugk@ti.com \ --to=manjugk@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.