* [PATCH] xfstests: allow deeper symlink recursion in 005
@ 2011-04-10 20:03 Christoph Hellwig
2011-04-11 1:49 ` Dave Chinner
2011-04-13 17:24 ` Alex Elder
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2011-04-10 20:03 UTC (permalink / raw)
To: xfs
Recent kernels allow more than 40 nested symlinks, so up the limit
to still reproduce a failure.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/005
===================================================================
--- xfstests-dev.orig/005 2011-03-16 13:10:39.000000000 +0000
+++ xfstests-dev/005 2011-03-16 13:11:00.000000000 +0000
@@ -45,7 +45,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 1
_cleanup()
{
cd $testdir
- rm -f symlink_{0,1,2,3}{0,1,2,3,4,5,6,7,8,9} symlink_self empty_file
+ rm -f symlink_{0,1,2,3,4}{0,1,2,3,4,5,6,7,8,9} symlink_self empty_file
cd /
_cleanup_testdir
}
@@ -82,7 +82,7 @@ cd $testdir
o=empty_file
touch $o
-for f in symlink_{0,1,2,3}{0,1,2,3,4,5,6,7,8,9}
+for f in symlink_{0,1,2,3,4}{0,1,2,3,4,5,6,7,8,9}
do
ln -s $o $f
o=$f
@@ -92,7 +92,7 @@ ln -s symlink_self symlink_self
echo "*** touch deep symlinks"
echo ""
-_touch symlink_{0,1,2,3}{0,1,2,3,4,5,6,7,8,9}
+_touch symlink_{0,1,2,3,4}{0,1,2,3,4,5,6,7,8,9}
echo ""
echo "*** touch recusive symlinks"
echo ""
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: allow deeper symlink recursion in 005
2011-04-10 20:03 [PATCH] xfstests: allow deeper symlink recursion in 005 Christoph Hellwig
@ 2011-04-11 1:49 ` Dave Chinner
2011-04-13 17:24 ` Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2011-04-11 1:49 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Sun, Apr 10, 2011 at 04:03:32PM -0400, Christoph Hellwig wrote:
> Recent kernels allow more than 40 nested symlinks, so up the limit
> to still reproduce a failure.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: allow deeper symlink recursion in 005
2011-04-10 20:03 [PATCH] xfstests: allow deeper symlink recursion in 005 Christoph Hellwig
2011-04-11 1:49 ` Dave Chinner
@ 2011-04-13 17:24 ` Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2011-04-13 17:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Sun, 2011-04-10 at 16:03 -0400, Christoph Hellwig wrote:
> Recent kernels allow more than 40 nested symlinks, so up the limit
> to still reproduce a failure.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good, and I confirm it fixes the output mismatch on 005.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-13 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-10 20:03 [PATCH] xfstests: allow deeper symlink recursion in 005 Christoph Hellwig
2011-04-11 1:49 ` Dave Chinner
2011-04-13 17:24 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.