* Please pull 'to-upstream' of http://sgh.dk/~sgh/oe.git
@ 2011-04-20 8:07 Søren Holm
2011-04-20 9:47 ` Paul Menzel
2011-04-22 19:51 ` [PATCH] wvstreams: add patch to add missing header includes Paul Menzel
0 siblings, 2 replies; 13+ messages in thread
From: Søren Holm @ 2011-04-20 8:07 UTC (permalink / raw)
To: openembedded-devel
commit 59c811aaebd84424451058f019aaa32c257e4fc1
Author: Søren Holm <soeren.holm@mikrofyn.com>
Date: Wed Apr 20 09:48:43 2011 +0200
wvstreams: Added patch to fix compilation.
.../files/0001-Fixed-missing-header-includes.patch | 37
++++++++++++++++++++
recipes/wvstreams/wvstreams_4.6.bb | 1 +
2 files changed, 38 insertions(+), 0 deletions(-)
--
Søren Holm
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Please pull 'to-upstream' of http://sgh.dk/~sgh/oe.git
2011-04-20 8:07 Please pull 'to-upstream' of http://sgh.dk/~sgh/oe.git Søren Holm
@ 2011-04-20 9:47 ` Paul Menzel
2011-04-20 10:19 ` Please pull 'wvstreams-fixes' " Søren Holm
2011-04-22 19:51 ` [PATCH] wvstreams: add patch to add missing header includes Paul Menzel
1 sibling, 1 reply; 13+ messages in thread
From: Paul Menzel @ 2011-04-20 9:47 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]
Dear Søren,
thank you for your patch.
Unfortunately
$ git remote add wvstream http://sgh.dk/~sgh/oe.git
$ git fetch wvstream # lasts forever/times out
does not work.
Naming the branch descriptively, for example »wvstream-fix« would also
help in my opinion.
Am Mittwoch, den 20.04.2011, 10:07 +0200 schrieb Søren Holm:
> commit 59c811aaebd84424451058f019aaa32c257e4fc1
> Author: Søren Holm <soeren.holm@mikrofyn.com>
> Date: Wed Apr 20 09:48:43 2011 +0200
>
> wvstreams: Added patch to fix compilation.
Please add an excerpt from the error message to the commit message.
| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
| ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
| ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
| make: *** [ipstreams/wvunixdgsocket.o] Error 1
> .../files/0001-Fixed-missing-header-includes.patch | 37
> ++++++++++++++++++++
please turn off line wrapping for pasted sections.
> recipes/wvstreams/wvstreams_4.6.bb | 1 +
> 2 files changed, 38 insertions(+), 0 deletions(-)
Could next time, please also send the patches to the list. This way, our
patch queue Patchwork [1] can keep track of it. There should be some
kind of option.
Thanks,
Paul
[1] http://patches.openembedded.org/project/oe/list/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Please pull 'wvstreams-fixes' of http://sgh.dk/~sgh/oe.git
2011-04-20 9:47 ` Paul Menzel
@ 2011-04-20 10:19 ` Søren Holm
2011-04-20 10:45 ` Paul Menzel
0 siblings, 1 reply; 13+ messages in thread
From: Søren Holm @ 2011-04-20 10:19 UTC (permalink / raw)
To: openembedded-devel
Hej Paul
The server should be responding now.
I added the compiler error to the commit and changed the branchname.
You could consider to do :
$ git fetch http://sgh.dk/~sgh/oe.git wvstreams-fixes
the fetched HEAD will then end in the FETCH_HEAD refname.
Onsdag 20 april 2011 11:47:20 skrev Paul Menzel:
> Dear Søren,
>
>
> thank you for your patch.
>
> Unfortunately
>
> $ git remote add wvstream http://sgh.dk/~sgh/oe.git
> $ git fetch wvstream # lasts forever/times out
>
> does not work.
>
> Naming the branch descriptively, for example »wvstream-fix« would also
> help in my opinion.
>
> Am Mittwoch, den 20.04.2011, 10:07 +0200 schrieb Søren Holm:
> > commit 59c811aaebd84424451058f019aaa32c257e4fc1
> > Author: Søren Holm <soeren.holm@mikrofyn.com>
> > Date: Wed Apr 20 09:48:43 2011 +0200
> >
> > wvstreams: Added patch to fix compilation.
>
> Please add an excerpt from the error message to the commit message.
>
> | ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> | ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer
> | will break strict-aliasing rules ipstreams/wvunixdgsocket.cc: In
> | constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool,
> | int)': ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not
> | declared in this scope make: *** [ipstreams/wvunixdgsocket.o] Error 1
> |
> > .../files/0001-Fixed-missing-header-includes.patch | 37
> >
> > ++++++++++++++++++++
>
> please turn off line wrapping for pasted sections.
>
> > recipes/wvstreams/wvstreams_4.6.bb | 1 +
> > 2 files changed, 38 insertions(+), 0 deletions(-)
>
> Could next time, please also send the patches to the list. This way, our
> patch queue Patchwork [1] can keep track of it. There should be some
> kind of option.
>
--
Søren Holm
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Please pull 'wvstreams-fixes' of http://sgh.dk/~sgh/oe.git
2011-04-20 10:19 ` Please pull 'wvstreams-fixes' " Søren Holm
@ 2011-04-20 10:45 ` Paul Menzel
2011-04-20 12:05 ` Søren Holm
0 siblings, 1 reply; 13+ messages in thread
From: Paul Menzel @ 2011-04-20 10:45 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
Dear Søren,
Am Mittwoch, den 20.04.2011, 12:19 +0200 schrieb Søren Holm:
> The server should be responding now.
I am now getting the following error.
$ git fetch http://sgh.dk/~sgh/oe.git wvstreams-fixes
error: Unable to find a76908145053c3f4a90988ce4c6e312fa7578e42 under http://sgh.dk/~sgh/oe.git
Cannot obtain needed object a76908145053c3f4a90988ce4c6e312fa7578e42
error: Fetch failed.
> I added the compiler error to the commit and changed the branchname.
Thank you.
> You could consider to do :
> $ git fetch http://sgh.dk/~sgh/oe.git wvstreams-fixes
>
> the fetched HEAD will then end in the FETCH_HEAD refname.
Thank you very much for the hint. I should send a patch to the Git
developers to add that to the example section.
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Please pull 'wvstreams-fixes' of http://sgh.dk/~sgh/oe.git
2011-04-20 10:45 ` Paul Menzel
@ 2011-04-20 12:05 ` Søren Holm
2011-04-20 13:38 ` Paul Menzel
0 siblings, 1 reply; 13+ messages in thread
From: Søren Holm @ 2011-04-20 12:05 UTC (permalink / raw)
To: openembedded-devel
Hi Paul
Please use this url instead. Somehow http export is not working.
git://github.com/sgh/oe.git
Onsdag 20 april 2011 12:45:45 skrev Paul Menzel:
>
> Am Mittwoch, den 20.04.2011, 12:19 +0200 schrieb Søren Holm:
> > The server should be responding now.
>
> I am now getting the following error.
>
> $ git fetch http://sgh.dk/~sgh/oe.git wvstreams-fixes
> error: Unable to find a76908145053c3f4a90988ce4c6e312fa7578e42
> under http://sgh.dk/~sgh/oe.git Cannot obtain needed object
> a76908145053c3f4a90988ce4c6e312fa7578e42 error: Fetch failed.
>
--
Søren Holm
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Please pull 'wvstreams-fixes' of http://sgh.dk/~sgh/oe.git
2011-04-20 12:05 ` Søren Holm
@ 2011-04-20 13:38 ` Paul Menzel
2011-04-23 10:18 ` Søren Holm
0 siblings, 1 reply; 13+ messages in thread
From: Paul Menzel @ 2011-04-20 13:38 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
Dear Søren,
Am Mittwoch, den 20.04.2011, 14:05 +0200 schrieb Søren Holm:
> Please use this url instead. Somehow http export is not working.
>
> git://github.com/sgh/oe.git
thank you. That worked.
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] wvstreams: add patch to add missing header includes
2011-04-20 8:07 Please pull 'to-upstream' of http://sgh.dk/~sgh/oe.git Søren Holm
2011-04-20 9:47 ` Paul Menzel
@ 2011-04-22 19:51 ` Paul Menzel
2011-04-23 0:00 ` Khem Raj
2011-04-23 11:08 ` Søren Holm
1 sibling, 2 replies; 13+ messages in thread
From: Paul Menzel @ 2011-04-22 19:51 UTC (permalink / raw)
To: openembedded-devel; +Cc: Søren Holm
[-- Attachment #1: Type: text/plain, Size: 3605 bytes --]
From: Søren Holm <soeren.holm@mikrofyn.com>
Date: Wed, 20 Apr 2011 09:48:43 +0200
Building fails with the following error.
| ./CXX -c ipstreams/wvunixdgsocket
| In file included from ./include/wvunixdgsocket.h:13:0,
| from ipstreams/wvunixdgsocket.cc:1:
| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
| ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
| ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
| make: *** [ipstreams/wvunixdgsocket.o] Error 1
This patch is build tested using `angstrom-2010.x` and `minimal` for `MACHINE = "beagleboard"`. The build still fails when uClibc is used.
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Søren Holm <soeren.holm@mikrofyn.com>
CC: Khem Raj <raj.khem@gmail.com>
---
1. Søren, please add your Signed-off-by line in front of mine. This is a demanded by the commit policy [1].
2. I am adding Khem, since he seems to be the original author of this patch. It would be great to get his Acked-by too.
3. Søren, please send your patch upstream.
4. Søren, when you have a little time it would be great if you could update WvStreams to 4.6.1 and test it.
5. Søren, I removed `apply=yes` since that is the default.
[1] http://openembedded.org/index.php/Commit_Policy
---
| 37 ++++++++++++++++++++
recipes/wvstreams/wvstreams_4.6.bb | 1 +
2 files changed, 38 insertions(+), 0 deletions(-)
create mode 100644 recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch
--git a/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch b/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch
new file mode 100644
index 0000000..f6d99f0
--- /dev/null
+++ b/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch
@@ -0,0 +1,37 @@
+From d76ec92a9e09fefa3083250f4aa588d0e94fe20c Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?S=C3=B8ren=20Holm?= <sh@mikrofyn.com>
+Date: Wed, 20 Apr 2011 09:41:22 +0200
+Subject: [PATCH] Fixed missing header includes.
+
+---
+ ipstreams/wvunixdgsocket.cc | 2 +-
+ streams/wvatomicfile.cc | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/ipstreams/wvunixdgsocket.cc b/ipstreams/wvunixdgsocket.cc
+index 41d2911..6dc12fc 100644
+--- a/ipstreams/wvunixdgsocket.cc
++++ b/ipstreams/wvunixdgsocket.cc
+@@ -1,5 +1,5 @@
+ #include "wvunixdgsocket.h"
+-#ifdef MACOS
++#if defined(MACOS) || defined(__GNUC__)
+ #include <sys/types.h>
+ #include <sys/stat.h>
+ #endif
+diff --git a/streams/wvatomicfile.cc b/streams/wvatomicfile.cc
+index 65ae202..0a58069 100644
+--- a/streams/wvatomicfile.cc
++++ b/streams/wvatomicfile.cc
+@@ -11,7 +11,7 @@
+ #include "wvfileutils.h"
+ #include "wvstrutils.h"
+
+-#ifdef MACOS
++#if defined(MACOS) || defined(__GNUC__)
+ #include <sys/stat.h>
+ #endif
+
+--
+1.7.4.1
+
diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
index 1c11268..0eb0198 100644
--- a/recipes/wvstreams/wvstreams_4.6.bb
+++ b/recipes/wvstreams/wvstreams_4.6.bb
@@ -6,6 +6,7 @@ DEPENDS = "zlib openssl (>= 0.9.8)"
PR = "r1"
SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
+ file://0001-Fixed-missing-header-includes.patch \
"
inherit autotools pkgconfig
--
1.7.4.4
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] wvstreams: add patch to add missing header includes
2011-04-22 19:51 ` [PATCH] wvstreams: add patch to add missing header includes Paul Menzel
@ 2011-04-23 0:00 ` Khem Raj
2011-04-23 11:08 ` Søren Holm
1 sibling, 0 replies; 13+ messages in thread
From: Khem Raj @ 2011-04-23 0:00 UTC (permalink / raw)
To: Paul Menzel; +Cc: Søren Holm, openembedded-devel
On Fri, Apr 22, 2011 at 12:51 PM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> From: Søren Holm <soeren.holm@mikrofyn.com>
> Date: Wed, 20 Apr 2011 09:48:43 +0200
>
> Building fails with the following error.
>
> | ./CXX -c ipstreams/wvunixdgsocket
> | In file included from ./include/wvunixdgsocket.h:13:0,
> | from ipstreams/wvunixdgsocket.cc:1:
> | ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> | ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> | ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
> | ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
> | make: *** [ipstreams/wvunixdgsocket.o] Error 1
>
> This patch is build tested using `angstrom-2010.x` and `minimal` for `MACHINE = "beagleboard"`. The build still fails when uClibc is used.
>
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> CC: Søren Holm <soeren.holm@mikrofyn.com>
> CC: Khem Raj <raj.khem@gmail.com>
Looks ok to me.
Acked-by: Khem Raj <raj.khem@gmail.com>
> ---
> 1. Søren, please add your Signed-off-by line in front of mine. This is a demanded by the commit policy [1].
> 2. I am adding Khem, since he seems to be the original author of this patch. It would be great to get his Acked-by too.
> 3. Søren, please send your patch upstream.
> 4. Søren, when you have a little time it would be great if you could update WvStreams to 4.6.1 and test it.
> 5. Søren, I removed `apply=yes` since that is the default.
>
> [1] http://openembedded.org/index.php/Commit_Policy
> ---
> .../files/0001-Fixed-missing-header-includes.patch | 37 ++++++++++++++++++++
> recipes/wvstreams/wvstreams_4.6.bb | 1 +
> 2 files changed, 38 insertions(+), 0 deletions(-)
> create mode 100644 recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch
>
> diff --git a/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch b/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch
> new file mode 100644
> index 0000000..f6d99f0
> --- /dev/null
> +++ b/recipes/wvstreams/files/0001-Fixed-missing-header-includes.patch
> @@ -0,0 +1,37 @@
> +From d76ec92a9e09fefa3083250f4aa588d0e94fe20c Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?S=C3=B8ren=20Holm?= <sh@mikrofyn.com>
> +Date: Wed, 20 Apr 2011 09:41:22 +0200
> +Subject: [PATCH] Fixed missing header includes.
> +
> +---
> + ipstreams/wvunixdgsocket.cc | 2 +-
> + streams/wvatomicfile.cc | 2 +-
> + 2 files changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/ipstreams/wvunixdgsocket.cc b/ipstreams/wvunixdgsocket.cc
> +index 41d2911..6dc12fc 100644
> +--- a/ipstreams/wvunixdgsocket.cc
> ++++ b/ipstreams/wvunixdgsocket.cc
> +@@ -1,5 +1,5 @@
> + #include "wvunixdgsocket.h"
> +-#ifdef MACOS
> ++#if defined(MACOS) || defined(__GNUC__)
> + #include <sys/types.h>
> + #include <sys/stat.h>
> + #endif
> +diff --git a/streams/wvatomicfile.cc b/streams/wvatomicfile.cc
> +index 65ae202..0a58069 100644
> +--- a/streams/wvatomicfile.cc
> ++++ b/streams/wvatomicfile.cc
> +@@ -11,7 +11,7 @@
> + #include "wvfileutils.h"
> + #include "wvstrutils.h"
> +
> +-#ifdef MACOS
> ++#if defined(MACOS) || defined(__GNUC__)
> + #include <sys/stat.h>
> + #endif
> +
> +--
> +1.7.4.1
> +
> diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
> index 1c11268..0eb0198 100644
> --- a/recipes/wvstreams/wvstreams_4.6.bb
> +++ b/recipes/wvstreams/wvstreams_4.6.bb
> @@ -6,6 +6,7 @@ DEPENDS = "zlib openssl (>= 0.9.8)"
> PR = "r1"
>
> SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
> + file://0001-Fixed-missing-header-includes.patch \
> "
>
> inherit autotools pkgconfig
> --
> 1.7.4.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Please pull 'wvstreams-fixes' of http://sgh.dk/~sgh/oe.git
2011-04-20 13:38 ` Paul Menzel
@ 2011-04-23 10:18 ` Søren Holm
0 siblings, 0 replies; 13+ messages in thread
From: Søren Holm @ 2011-04-23 10:18 UTC (permalink / raw)
To: openembedded-devel
Onsdag den 20. april 2011 15:38:12 skrev Paul Menzel:
>
> thank you. That worked.
>
Will my change be merged in sometime soon. It is a rather simple change I
think.
--
Søren Holm
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wvstreams: add patch to add missing header includes
2011-04-22 19:51 ` [PATCH] wvstreams: add patch to add missing header includes Paul Menzel
2011-04-23 0:00 ` Khem Raj
@ 2011-04-23 11:08 ` Søren Holm
2011-04-23 11:46 ` Paul Menzel
1 sibling, 1 reply; 13+ messages in thread
From: Søren Holm @ 2011-04-23 11:08 UTC (permalink / raw)
To: openembedded-devel
Fredag den 22. april 2011 21:51:07 skrev Paul Menzel:
> 1. Søren, please add your Signed-off-by line in front of mine. This is a demanded by the commit policy [1].
I kind of novice into this. How do I add my signed-off line ?
> 2. I am adding Khem, since he seems to be the original author of this patch. It would be great to get his Acked-by too.
> 3. Søren, please send your patch upstream.
> 4. Søren, when you have a little time it would be great if you could update WvStreams to 4.6.1 and test it.
will do
> 5. Søren, I removed `apply=yes` since that is the default.
great.
btw. The emaileaddress mixup won't happen again.
--
Søren Holm
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wvstreams: add patch to add missing header includes
2011-04-23 11:08 ` Søren Holm
@ 2011-04-23 11:46 ` Paul Menzel
2011-04-23 12:04 ` Søren Holm
0 siblings, 1 reply; 13+ messages in thread
From: Paul Menzel @ 2011-04-23 11:46 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
Am Samstag, den 23.04.2011, 13:08 +0200 schrieb Søren Holm:
> Fredag den 22. april 2011 21:51:07 skrev Paul Menzel:
> > 1. Søren, please add your Signed-off-by line in front of mine. This is a demanded by the commit policy [1].
>
> I kind of novice into this. How do I add my signed-off line ?
When committing the change, just add the option `-s` and it is added
automatically by what you have configured using `git config`.
For now, you can just reply to this message and add that line where you
like.
I will add it to the commit message using `git commit --amend`.
> > 2. I am adding Khem, since he seems to be the original author of this patch. It would be great to get his Acked-by too.
> > 3. Søren, please send your patch upstream.
> > 4. Søren, when you have a little time it would be great if you could update WvStreams to 4.6.1 and test it.
>
> will do
>
> > 5. Søren, I removed `apply=yes` since that is the default.
>
> great.
>
> btw. The emaileaddress mixup won't happen again.
Just tell me what the correct one is and I will push your patch.
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wvstreams: add patch to add missing header includes
2011-04-23 11:46 ` Paul Menzel
@ 2011-04-23 12:04 ` Søren Holm
2011-04-25 14:48 ` Paul Menzel
0 siblings, 1 reply; 13+ messages in thread
From: Søren Holm @ 2011-04-23 12:04 UTC (permalink / raw)
To: openembedded-devel
Lørdag den 23. april 2011 13:46:02 skrev Paul Menzel:
> Am Samstag, den 23.04.2011, 13:08 +0200 schrieb Søren Holm:
> > Fredag den 22. april 2011 21:51:07 skrev Paul Menzel:
> > > 1. Søren, please add your Signed-off-by line in front of mine. This is a demanded by the commit policy [1].
> >
> > I kind of novice into this. How do I add my signed-off line ?
>
> When committing the change, just add the option `-s` and it is added
> automatically by what you have configured using `git config`.
>
> For now, you can just reply to this message and add that line where you
> like.
Signed-off-by: Søren Holm <sgh@sgh.dk>
I rebased my branch at github repo to master. Now ait lso contains a 4.6.1 recipe if your would like.
I added my Signed-Off to both commits there also.
>
> I will add it to the commit message using `git commit --amend`.
>
> > > 2. I am adding Khem, since he seems to be the original author of this patch. It would be great to get his Acked-by too.
> > > 3. Søren, please send your patch upstream.
> > > 4. Søren, when you have a little time it would be great if you could update WvStreams to 4.6.1 and test it.
> >
> > will do
> >
> > > 5. Søren, I removed `apply=yes` since that is the default.
> >
> > great.
> >
> > btw. The emaileaddress mixup won't happen again.
>
> Just tell me what the correct one is and I will push your patch.
>
>
> Thanks,
>
> Paul
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] wvstreams: add patch to add missing header includes
2011-04-23 12:04 ` Søren Holm
@ 2011-04-25 14:48 ` Paul Menzel
0 siblings, 0 replies; 13+ messages in thread
From: Paul Menzel @ 2011-04-25 14:48 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]
Am Samstag, den 23.04.2011, 14:04 +0200 schrieb Søren Holm:
> Lørdag den 23. april 2011 13:46:02 skrev Paul Menzel:
> > Am Samstag, den 23.04.2011, 13:08 +0200 schrieb Søren Holm:
> > > Fredag den 22. april 2011 21:51:07 skrev Paul Menzel:
> > > > 1. Søren, please add your Signed-off-by line in front of mine. This is a demanded by the commit policy [1].
> > >
> > > I kind of novice into this. How do I add my signed-off line ?
> >
> > When committing the change, just add the option `-s` and it is added
> > automatically by what you have configured using `git config`.
> >
> > For now, you can just reply to this message and add that line where you
> > like.
>
> Signed-off-by: Søren Holm <sgh@sgh.dk>
>
> I rebased my branch at github repo to master. Now ait lso contains a 4.6.1 recipe if your would like.
> I added my Signed-Off to both commits there also.
>
> > I will add it to the commit message using `git commit --amend`.
> >
> > > > 2. I am adding Khem, since he seems to be the original author of this patch. It would be great to get his Acked-by too.
> > > > 3. Søren, please send your patch upstream.
> > > > 4. Søren, when you have a little time it would be great if you could update WvStreams to 4.6.1 and test it.
> > >
> > > will do
> > >
> > > > 5. Søren, I removed `apply=yes` since that is the default.
> > >
> > > great.
> > >
> > > btw. The emaileaddress mixup won't happen again.
> >
> > Just tell me what the correct one is and I will push your patch.
I pushed this commit yesterday [1]. I am sorry I messed up and omitted
the commit summary.
Thanks,
Paul
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=3cb4c65dbd0fba178208bc908ce93e6b1ae9fe9b
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-04-25 14:51 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-20 8:07 Please pull 'to-upstream' of http://sgh.dk/~sgh/oe.git Søren Holm
2011-04-20 9:47 ` Paul Menzel
2011-04-20 10:19 ` Please pull 'wvstreams-fixes' " Søren Holm
2011-04-20 10:45 ` Paul Menzel
2011-04-20 12:05 ` Søren Holm
2011-04-20 13:38 ` Paul Menzel
2011-04-23 10:18 ` Søren Holm
2011-04-22 19:51 ` [PATCH] wvstreams: add patch to add missing header includes Paul Menzel
2011-04-23 0:00 ` Khem Raj
2011-04-23 11:08 ` Søren Holm
2011-04-23 11:46 ` Paul Menzel
2011-04-23 12:04 ` Søren Holm
2011-04-25 14:48 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.