* [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S
@ 2011-04-16 23:24 Stanislav Brabec
2011-04-19 11:20 ` Andreas Oberritter
0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Brabec @ 2011-04-16 23:24 UTC (permalink / raw)
To: openembedded-devel
Searching for .pc files in S makes more problems than it
brings benefits. Searching in the installed root seems to be more
logical.
Fixes possible subtle breakages:
- .pc files populated with a different name that upstream intended
- populated .pc files files that were not intended to be populated
Signed-off-by: Stanislav Brabec <utx@penguin.cz>
diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
index d96b708..00298ca 100644
--- a/classes/pkgconfig.bbclass
+++ b/classes/pkgconfig.bbclass
@@ -14,7 +14,7 @@ SYSROOT_PREPROCESS_FUNCS += "pkgconfig_sysroot_preprocess"
pkgconfig_sysroot_preprocess () {
install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
- for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
+ for pc in `find ${D} -name '*.pc' -type f`; do
pcname=`basename $pc`
if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
oenote "$pcname was not installed."
--
________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S
2011-04-16 23:24 [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S Stanislav Brabec
@ 2011-04-19 11:20 ` Andreas Oberritter
2011-04-20 15:47 ` Stanislav Brabec
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Oberritter @ 2011-04-19 11:20 UTC (permalink / raw)
To: openembedded-devel
On 04/17/2011 01:24 AM, Stanislav Brabec wrote:
> Searching for .pc files in S makes more problems than it
> brings benefits. Searching in the installed root seems to be more
> logical.
>
> Fixes possible subtle breakages:
> - .pc files populated with a different name that upstream intended
> - populated .pc files files that were not intended to be populated
This has already been fixed with commit
c2c8fe4c5629add94bd0b922f5b3446624a9f4d8.
> Signed-off-by: Stanislav Brabec <utx@penguin.cz>
>
> diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
> index d96b708..00298ca 100644
> --- a/classes/pkgconfig.bbclass
> +++ b/classes/pkgconfig.bbclass
> @@ -14,7 +14,7 @@ SYSROOT_PREPROCESS_FUNCS += "pkgconfig_sysroot_preprocess"
>
> pkgconfig_sysroot_preprocess () {
> install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
> - for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
> + for pc in `find ${D} -name '*.pc' -type f`; do
> pcname=`basename $pc`
> if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
> oenote "$pcname was not installed."
>
This function just prints a warning, if it finds a .pc file that didn't
get installed. Using ${D} at this point makes this function a no-op.
It might be better to just remove it completely.
Regards,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S
2011-04-19 11:20 ` Andreas Oberritter
@ 2011-04-20 15:47 ` Stanislav Brabec
0 siblings, 0 replies; 3+ messages in thread
From: Stanislav Brabec @ 2011-04-20 15:47 UTC (permalink / raw)
To: openembedded-devel
Andreas Oberritter wrote:
> > diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
> > index d96b708..00298ca 100644
> > --- a/classes/pkgconfig.bbclass
> > +++ b/classes/pkgconfig.bbclass
> > @@ -14,7 +14,7 @@ SYSROOT_PREPROCESS_FUNCS += "pkgconfig_sysroot_preprocess"
> >
> > pkgconfig_sysroot_preprocess () {
> > install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
> > - for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
> > + for pc in `find ${D} -name '*.pc' -type f`; do
> > pcname=`basename $pc`
> > if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
> > oenote "$pcname was not installed."
> >
>
> This function just prints a warning, if it finds a .pc file that didn't
> get installed. Using ${D} at this point makes this function a no-op.
>
> It might be better to just remove it completely.
Good hint. So I'll not submit this patch. Your commit c2c8fe4 already
did the right fix here.
--
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-20 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-16 23:24 [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S Stanislav Brabec
2011-04-19 11:20 ` Andreas Oberritter
2011-04-20 15:47 ` Stanislav Brabec
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.