All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sanjeev Premi <premi@ti.com>
To: <linux-media@vger.kernel.org>
Cc: Sanjeev Premi <premi@ti.com>, <laurent.pinchart@ideasonboard.com>
Subject: [PATCH] omap3: isp: fix compiler warning
Date: Wed, 18 May 2011 21:36:51 +0530	[thread overview]
Message-ID: <1305734811-2354-1-git-send-email-premi@ti.com> (raw)

This patch fixes this compiler warning:
  drivers/media/video/omap3isp/isp.c: In function 'isp_isr_dbg':
  drivers/media/video/omap3isp/isp.c:392:2: warning: zero-length
   gnu_printf format string

Since printk() is used in next few statements, same was used
here as well.

Signed-off-by: Sanjeev Premi <premi@ti.com>
Cc: laurent.pinchart@ideasonboard.com
---

 Actually full block can be converted to dev_dbg()
 as well; but i am not sure about original intent
 of the mix.

 Based on comments, i can resubmit with all prints
 converted to dev_dbg.



 drivers/media/video/omap3isp/isp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/omap3isp/isp.c b/drivers/media/video/omap3isp/isp.c
index 503bd79..1d38d96 100644
--- a/drivers/media/video/omap3isp/isp.c
+++ b/drivers/media/video/omap3isp/isp.c
@@ -387,7 +387,7 @@ static inline void isp_isr_dbg(struct isp_device *isp, u32 irqstatus)
 	};
 	int i;
 
-	dev_dbg(isp->dev, "");
+	printk(KERN_DEBUG "%s:\n", dev_driver_string(isp->dev));
 
 	for (i = 0; i < ARRAY_SIZE(name); i++) {
 		if ((1 << i) & irqstatus)
-- 
1.7.2.2


             reply	other threads:[~2011-05-18 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 16:06 Sanjeev Premi [this message]
2011-05-21 10:55 ` [PATCH] omap3: isp: fix compiler warning Mauro Carvalho Chehab
2011-05-22 19:25   ` Laurent Pinchart
2011-05-23 18:09     ` Premi, Sanjeev
2011-05-25  8:14       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305734811-2354-1-git-send-email-premi@ti.com \
    --to=premi@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.