Re: [PATCH] omap3: isp: fix compiler warning

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sanjeev,

On Monday 23 May 2011 20:09:58 Premi, Sanjeev wrote:
> On Monday, May 23, 2011 12:56 AM Laurent Pinchart wrote:
> > On Saturday 21 May 2011 12:55:32 Mauro Carvalho Chehab wrote:
> > > Em 18-05-2011 13:06, Sanjeev Premi escreveu:

[snip]

> > > > @@ -387,7 +387,7 @@ static inline void isp_isr_dbg(struct
> > > > isp_device *isp, u32 irqstatus)
> > > > 
> > > >  	};
> > > >  	int i;
> > > > 
> > > > -	dev_dbg(isp->dev, "");
> > > > +	printk(KERN_DEBUG "%s:\n", dev_driver_string(isp->dev));
> > 
> > The original code doesn't include any \n. Is there a
> > particular reason why you
> > want to add one ?
> 
> [sp] Sorry, that's a mistake out of habit.
>      Another way to fix warning would be to make the string meaningful:
> 
> -	dev_dbg(isp->dev, "");
> +	dev_dbg (isp->dev, "ISP_IRQ:");
> 
>      Is this better?

That looks good to me. I'll queue your patch in my tree (with a space after 
the colon). Thanks.

-- 
Regards,

Laurent Pinchart