From: Benjamin Herrenschmidt <benh@kernel.crashing.org> To: "Ira W. Snyder" <iws@ovro.caltech.edu> Cc: linuxppc-dev@lists.ozlabs.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFCv7 0/2] CARMA Board Support Date: Thu, 19 May 2011 14:13:41 +1000 [thread overview] Message-ID: <1305778421.7481.38.camel@pasglop> (raw) In-Reply-To: <1297467270-29576-1-git-send-email-iws@ovro.caltech.edu> On Fri, 2011-02-11 at 15:34 -0800, Ira W. Snyder wrote: > Hello everyone, > > This is the seventh posting of these drivers, taking into account comments > from earlier postings. I've made sure that the drivers both pass checkpatch > without any errors or warnings. I would appreciate as much review as you > can offer, so that these can get into the next merge cycle. They've been > sitting outside mainline for far too long. This has been bitrotting for way too long indeed. I'm sticking this into powerpc -next today. Cheers, Ben. > RFCv6 -> RFCv7: > - reference count private data structure (to support unbind) > - use #defines instead of hex values for registers > - keep lines <=80 characters > > RFCv5 -> RFCv6: > - change locking in several functions > - use list_move_tail() to simplify code > - remove unused helper functions > > RFCv4 -> RFCv5: > - remove unecessary locking per review comments > - do not clobber return values from *_interruptible() > - explicitly track buffer DMA mapping > - use #defines instead of raw hex addresses > - change enable sysfs attribute to root-writeable only > > RFCv3 -> RFCv4: > - updates for DATA-FPGA version 2 > > RFCv2 -> RFCv3: > - use miscdevice framework (removing the carma class) > - add bitfile readback capability to the programmer > > RFCv1 -> RFCv2: > - change comments to kerneldoc format > - Kconfig improvements > - use the videobuf_dma_sg API in the programmer > - updates for Freescale DMAEngine DMA_SLAVE API changes > > KNOWN ISSUES: > - untested with a setup that can generate interrupts (will get access soon) > - does not handle runtime "unbind" > > Information about the CARMA board: > > The CARMA board is essentially an MPC8349EA MDS reference design with a > 1GHz ADC and 4 high powered data processing FPGAs connected to the local > bus. It is all packed into a compact PCI form factor. It is used at the > Owens Valley Radio Observatory as the main component in the correlator > system. > > For board information, see: > http://www.mmarray.org/~dwh/carma_board/index.html > > For DATA-FPGA register layout, see: > http://www.mmarray.org/memos/carma_memo46.pdf > > These drivers are the necessary pieces to get the data processing FPGAs > working and producing data. Despite the fact that the hardware is custom > and we are the only users, I'd still like to get the drivers upstream. > Several people have suggested that this is possible. > > Some further patches will be forthcoming. I have a driver for the LED > subsystem and the PPS subsystem. The LED register layout is expected to > change soon, so I won't post the driver until that is finished. The PPS > driver will be posted seperately from this patch series; it is very > generic. > > Thanks to everyone who has provided comments on earlier versions! > > Ira W. Snyder (2): > misc: add CARMA DATA-FPGA Access Driver > misc: add CARMA DATA-FPGA Programmer support > > drivers/misc/Kconfig | 1 + > drivers/misc/Makefile | 1 + > drivers/misc/carma/Kconfig | 18 + > drivers/misc/carma/Makefile | 2 + > drivers/misc/carma/carma-fpga-program.c | 1141 ++++++++++++++++++++++++ > drivers/misc/carma/carma-fpga.c | 1433 +++++++++++++++++++++++++++++++ > 6 files changed, 2596 insertions(+), 0 deletions(-) > create mode 100644 drivers/misc/carma/Kconfig > create mode 100644 drivers/misc/carma/Makefile > create mode 100644 drivers/misc/carma/carma-fpga-program.c > create mode 100644 drivers/misc/carma/carma-fpga.c >
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> To: "Ira W. Snyder" <iws@ovro.caltech.edu> Cc: dmitry.torokhov@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFCv7 0/2] CARMA Board Support Date: Thu, 19 May 2011 14:13:41 +1000 [thread overview] Message-ID: <1305778421.7481.38.camel@pasglop> (raw) In-Reply-To: <1297467270-29576-1-git-send-email-iws@ovro.caltech.edu> On Fri, 2011-02-11 at 15:34 -0800, Ira W. Snyder wrote: > Hello everyone, > > This is the seventh posting of these drivers, taking into account comments > from earlier postings. I've made sure that the drivers both pass checkpatch > without any errors or warnings. I would appreciate as much review as you > can offer, so that these can get into the next merge cycle. They've been > sitting outside mainline for far too long. This has been bitrotting for way too long indeed. I'm sticking this into powerpc -next today. Cheers, Ben. > RFCv6 -> RFCv7: > - reference count private data structure (to support unbind) > - use #defines instead of hex values for registers > - keep lines <=80 characters > > RFCv5 -> RFCv6: > - change locking in several functions > - use list_move_tail() to simplify code > - remove unused helper functions > > RFCv4 -> RFCv5: > - remove unecessary locking per review comments > - do not clobber return values from *_interruptible() > - explicitly track buffer DMA mapping > - use #defines instead of raw hex addresses > - change enable sysfs attribute to root-writeable only > > RFCv3 -> RFCv4: > - updates for DATA-FPGA version 2 > > RFCv2 -> RFCv3: > - use miscdevice framework (removing the carma class) > - add bitfile readback capability to the programmer > > RFCv1 -> RFCv2: > - change comments to kerneldoc format > - Kconfig improvements > - use the videobuf_dma_sg API in the programmer > - updates for Freescale DMAEngine DMA_SLAVE API changes > > KNOWN ISSUES: > - untested with a setup that can generate interrupts (will get access soon) > - does not handle runtime "unbind" > > Information about the CARMA board: > > The CARMA board is essentially an MPC8349EA MDS reference design with a > 1GHz ADC and 4 high powered data processing FPGAs connected to the local > bus. It is all packed into a compact PCI form factor. It is used at the > Owens Valley Radio Observatory as the main component in the correlator > system. > > For board information, see: > http://www.mmarray.org/~dwh/carma_board/index.html > > For DATA-FPGA register layout, see: > http://www.mmarray.org/memos/carma_memo46.pdf > > These drivers are the necessary pieces to get the data processing FPGAs > working and producing data. Despite the fact that the hardware is custom > and we are the only users, I'd still like to get the drivers upstream. > Several people have suggested that this is possible. > > Some further patches will be forthcoming. I have a driver for the LED > subsystem and the PPS subsystem. The LED register layout is expected to > change soon, so I won't post the driver until that is finished. The PPS > driver will be posted seperately from this patch series; it is very > generic. > > Thanks to everyone who has provided comments on earlier versions! > > Ira W. Snyder (2): > misc: add CARMA DATA-FPGA Access Driver > misc: add CARMA DATA-FPGA Programmer support > > drivers/misc/Kconfig | 1 + > drivers/misc/Makefile | 1 + > drivers/misc/carma/Kconfig | 18 + > drivers/misc/carma/Makefile | 2 + > drivers/misc/carma/carma-fpga-program.c | 1141 ++++++++++++++++++++++++ > drivers/misc/carma/carma-fpga.c | 1433 +++++++++++++++++++++++++++++++ > 6 files changed, 2596 insertions(+), 0 deletions(-) > create mode 100644 drivers/misc/carma/Kconfig > create mode 100644 drivers/misc/carma/Makefile > create mode 100644 drivers/misc/carma/carma-fpga-program.c > create mode 100644 drivers/misc/carma/carma-fpga.c >
next prev parent reply other threads:[~2011-05-19 4:14 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-11 23:34 [PATCH RFCv7 0/2] CARMA Board Support Ira W. Snyder 2011-02-11 23:34 ` Ira W. Snyder 2011-02-11 23:34 ` [PATCH RFCv7 1/2] misc: add CARMA DATA-FPGA Access Driver Ira W. Snyder 2011-02-11 23:34 ` Ira W. Snyder 2011-02-11 23:34 ` [PATCH RFCv7 2/2] misc: add CARMA DATA-FPGA Programmer support Ira W. Snyder 2011-02-11 23:34 ` Ira W. Snyder 2011-05-19 4:13 ` Benjamin Herrenschmidt [this message] 2011-05-19 4:13 ` [PATCH RFCv7 0/2] CARMA Board Support Benjamin Herrenschmidt 2011-05-19 16:10 ` Ira W. Snyder 2011-05-19 16:10 ` Ira W. Snyder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1305778421.7481.38.camel@pasglop \ --to=benh@kernel.crashing.org \ --cc=dmitry.torokhov@gmail.com \ --cc=iws@ovro.caltech.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.