All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/5] network based PR service
Date: Thu, 19 May 2011 13:02:11 +0100	[thread overview]
Message-ID: <1305806531.3424.501.camel@rex> (raw)
In-Reply-To: <cover.1305800693.git.lianhao.lu@intel.com>

This patch series looks really good to me in general. I know I've given
feedback about some pieces that need tweaking but overall its good and
I'm pleased with this. There are a few corner cases people have raised
and some tweaks we need to make but nothing that can't be built from
this foundation! :)

On Thu, 2011-05-19 at 18:29 +0800, Lianhao Lu wrote:
> To start the network based PR service daemon, run the following command after 
> "sourcing" the environment file oe-init-build-env:
> 
>   bitbake-prserv --start

The one other area I'm going to worry about is the "build out the box"
use case. Nowhere in the quickstart guide do we mention to the user that
they need to run this. I'd also argue that we shouldn't require the user
to run this at all either and we should be able to autolaunch and use it
in the localhost usecase. Most users shouldn't care, it should just
work. Those who need to use it can either preconfigure it for their
users, or will know how to setup and start the server themselves.

A case in point is an autobuilder running 4 different builds. Ideally,
in the default case, each automated build would setup and just use its
own server on a non-conflicting free port on localhost.

I'm not 100% sure how we make this happen and I can give it some thought
but it is the final piece of this puzzle we need to solve.

Cheers,

Richard




      parent reply	other threads:[~2011-05-19 12:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 10:29 [PATCH 0/5] network based PR service Lianhao Lu
2011-05-19 10:29 ` [PATCH 1/5] Added the " Lianhao Lu
2011-05-19 10:29 ` [PATCH 2/5] conf/bitbake.conf: Added variables for " Lianhao Lu
2011-05-19 11:51   ` Richard Purdie
2011-05-19 10:29 ` [PATCH 3/5] classes/package(prserv).bbclass: Added PR service support Lianhao Lu
2011-05-19 11:54   ` Richard Purdie
2011-05-19 10:29 ` [PATCH 4/5] classes/package_xxx.class: " Lianhao Lu
2011-05-19 10:29 ` [PATCH 5/5] meta-yocto/local.conf.sample: Added PRSERV_HOST and PRSERV_PORT Lianhao Lu
2011-05-19 10:54 ` [PATCH 0/5] network based PR service Koen Kooi
2011-05-19 11:38   ` Richard Purdie
2011-05-19 11:51     ` Koen Kooi
2011-05-19 12:10       ` Richard Purdie
2011-05-19 11:01 ` Frans Meulenbroeks
2011-05-19 11:27   ` Frans Meulenbroeks
2011-05-19 11:35   ` Richard Purdie
2011-05-19 12:02     ` Frans Meulenbroeks
2011-05-19 12:22       ` Richard Purdie
2011-05-19 12:43         ` Frans Meulenbroeks
2011-05-19 13:13           ` Richard Purdie
2011-05-19 14:58             ` Mark Hatle
2011-05-19 12:02 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305806531.3424.501.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.