* [PATCH] HID: Fixed a crash in hid_report_raw_event() function.
@ 2011-05-19 19:41 ` Armando Visconti
0 siblings, 0 replies; 4+ messages in thread
From: Armando Visconti @ 2011-05-19 19:41 UTC (permalink / raw)
To: jkosina; +Cc: linux-input, linux-kernel, Armando Visconti
I'm using a Data Modul EasyTouch USB multitouch controller,
which is issuing a hid report with a size equals to 0. The rsize
value gets set to 536870912 and Linux is crashing in the memset
because the value is too big.
Signed-off-by: Armando Visconti <armando.visconti@st.com>
---
drivers/hid/hid-core.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index c3d6626..3e972e3 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1045,6 +1045,9 @@ void hid_report_raw_event(struct hid_device *hid, int type, u8 *data, int size,
rsize = ((report->size - 1) >> 3) + 1;
+ if (rsize > HID_MAX_BUFFER_SIZE)
+ rsize = HID_MAX_BUFFER_SIZE;
+
if (csize < rsize) {
dbg_hid("report %d is too short, (%d < %d)\n", report->id,
csize, rsize);
--
1.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] HID: Fixed a crash in hid_report_raw_event() function.
@ 2011-05-19 19:41 ` Armando Visconti
0 siblings, 0 replies; 4+ messages in thread
From: Armando Visconti @ 2011-05-19 19:41 UTC (permalink / raw)
To: jkosina; +Cc: linux-input, linux-kernel, Armando Visconti
I'm using a Data Modul EasyTouch USB multitouch controller,
which is issuing a hid report with a size equals to 0. The rsize
value gets set to 536870912 and Linux is crashing in the memset
because the value is too big.
Signed-off-by: Armando Visconti <armando.visconti@st.com>
---
drivers/hid/hid-core.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index c3d6626..3e972e3 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1045,6 +1045,9 @@ void hid_report_raw_event(struct hid_device *hid, int type, u8 *data, int size,
rsize = ((report->size - 1) >> 3) + 1;
+ if (rsize > HID_MAX_BUFFER_SIZE)
+ rsize = HID_MAX_BUFFER_SIZE;
+
if (csize < rsize) {
dbg_hid("report %d is too short, (%d < %d)\n", report->id,
csize, rsize);
--
1.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: Fixed a crash in hid_report_raw_event() function.
2011-05-19 19:41 ` Armando Visconti
(?)
@ 2011-05-20 8:26 ` Jiri Kosina
-1 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2011-05-20 8:26 UTC (permalink / raw)
To: Armando Visconti; +Cc: linux-input, linux-kernel
On Thu, 19 May 2011, Armando Visconti wrote:
> I'm using a Data Modul EasyTouch USB multitouch controller,
> which is issuing a hid report with a size equals to 0. The rsize
> value gets set to 536870912 and Linux is crashing in the memset
> because the value is too big.
>
> Signed-off-by: Armando Visconti <armando.visconti@st.com>
> ---
> drivers/hid/hid-core.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index c3d6626..3e972e3 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1045,6 +1045,9 @@ void hid_report_raw_event(struct hid_device *hid, int type, u8 *data, int size,
>
> rsize = ((report->size - 1) >> 3) + 1;
>
> + if (rsize > HID_MAX_BUFFER_SIZE)
> + rsize = HID_MAX_BUFFER_SIZE;
> +
> if (csize < rsize) {
> dbg_hid("report %d is too short, (%d < %d)\n", report->id,
> csize, rsize);
Applied, thank you.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: Fixed a crash in hid_report_raw_event() function.
2011-05-19 19:41 ` Armando Visconti
(?)
(?)
@ 2011-05-20 16:02 ` Valdis.Kletnieks
-1 siblings, 0 replies; 4+ messages in thread
From: Valdis.Kletnieks @ 2011-05-20 16:02 UTC (permalink / raw)
To: Armando Visconti; +Cc: jkosina, linux-input, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]
On Thu, 19 May 2011 21:41:22 +0200, Armando Visconti said:
> I'm using a Data Modul EasyTouch USB multitouch controller,
> which is issuing a hid report with a size equals to 0. The rsize
> value gets set to 536870912 and Linux is crashing in the memset
> because the value is too big.
>
> Signed-off-by: Armando Visconti <armando.visconti@st.com>
> ---
> drivers/hid/hid-core.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index c3d6626..3e972e3 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1045,6 +1045,9 @@ void hid_report_raw_event(struct hid_device *hid, int type, u8 *data, int size,
>
> rsize = ((report->size - 1) >> 3) + 1;
>
> + if (rsize > HID_MAX_BUFFER_SIZE)
> + rsize = HID_MAX_BUFFER_SIZE;
> +
> if (csize < rsize) {
> dbg_hid("report %d is too short, (%d < %d)\n", report->id,
> csize, rsize);
I'm thinking this is papering over the bug, and causing us to process a max-sized
buffer when the other end gave *zero* bytes back - this can't be good.
Probably should be more like this:
if (!report->size) then /*
rsize = MIN_VALID_SIZE; /* whatever it should be here */
else {
rsize = ((report->size - 1) >> 3) + 1;
if (rsize > HID_MAX_BUFFER_SIZE)
rsize = HID_MAX_BUFFER_SIZE;
}
if (csize < rsize) {
That last if() still looks squirrely - if we have an effectively zero rsize,
the report is short and the dbg_hid should fire. Did we want "csize > rsize"
instead?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-20 16:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 19:41 [PATCH] HID: Fixed a crash in hid_report_raw_event() function Armando Visconti
2011-05-19 19:41 ` Armando Visconti
2011-05-20 8:26 ` Jiri Kosina
2011-05-20 16:02 ` Valdis.Kletnieks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.