* [PATCH] wl12xx: change TX BA window size to 8
@ 2011-05-20 8:25 Luciano Coelho
2011-05-20 12:09 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Luciano Coelho @ 2011-05-20 8:25 UTC (permalink / raw)
To: linux-wireless; +Cc: Luciano Coelho
The wl12xx firmware only supports window size of 8 frames in TX BA
sessions. Currently we are configuring it to 64, which is not
supported and causes problems (ie. firmware crashes).
Fix this by changing the tx_ba_win_size configuration to 8.
Signed-off-by: Luciano Coelho <coelho@ti.com>
---
drivers/net/wireless/wl12xx/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 610be03..b854b5f 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -326,7 +326,7 @@ static struct conf_drv_settings default_conf = {
},
},
.ht = {
- .tx_ba_win_size = 64,
+ .tx_ba_win_size = 8,
.inactivity_timeout = 10000,
},
.mem_wl127x = {
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wl12xx: change TX BA window size to 8
2011-05-20 8:25 [PATCH] wl12xx: change TX BA window size to 8 Luciano Coelho
@ 2011-05-20 12:09 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2011-05-20 12:09 UTC (permalink / raw)
To: linux-wireless
On Fri, 2011-05-20 at 11:25 +0300, Luciano Coelho wrote:
> The wl12xx firmware only supports window size of 8 frames in TX BA
> sessions. Currently we are configuring it to 64, which is not
> supported and causes problems (ie. firmware crashes).
>
> Fix this by changing the tx_ba_win_size configuration to 8.
>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> ---
I'm holding this one back for a while. It seems that using 8 for the
win_size is more robust, but we're still discussing with firmware people
what the actual cause of the firmware crash is, since, in theory, a
window size of 64 should be fine.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-20 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-20 8:25 [PATCH] wl12xx: change TX BA window size to 8 Luciano Coelho
2011-05-20 12:09 ` Luciano Coelho
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.