* [PATCH] KVM Test: Switch current working folder in unattended_install.py.
@ 2011-05-19 10:24 fyang
2011-05-20 18:59 ` [Autotest] " Lucas Meneghel Rodrigues
0 siblings, 1 reply; 3+ messages in thread
From: fyang @ 2011-05-19 10:24 UTC (permalink / raw)
To: autotest; +Cc: kvm, Feng Yang
From: Feng Yang <fyang@redhat.com>
Current working folder for
unattended_install_config = UnattendedInstallConfig(test, params)
unattended_install_config.setup()
must be kvm folder.
Signed-off-by: Feng Yang <fyang@redhat.com>
---
client/tests/kvm/tests/unattended_install.py | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py
index 50a8c7a..eee1761 100644
--- a/client/tests/kvm/tests/unattended_install.py
+++ b/client/tests/kvm/tests/unattended_install.py
@@ -506,8 +506,11 @@ def run_unattended_install(test, params, env):
@param params: Dictionary with the test parameters.
@param env: Dictionary with test environment.
"""
+ cur_folder = os.getcwd()
+ os.chdir(test.bindir)
unattended_install_config = UnattendedInstallConfig(test, params)
unattended_install_config.setup()
+ os.chdir(cur_folder)
vm = env.get_vm(params["main_vm"])
vm.create()
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Autotest] [PATCH] KVM Test: Switch current working folder in unattended_install.py.
2011-05-19 10:24 [PATCH] KVM Test: Switch current working folder in unattended_install.py fyang
@ 2011-05-20 18:59 ` Lucas Meneghel Rodrigues
2011-05-23 2:25 ` Feng Yang
0 siblings, 1 reply; 3+ messages in thread
From: Lucas Meneghel Rodrigues @ 2011-05-20 18:59 UTC (permalink / raw)
To: fyang; +Cc: autotest, kvm
On Thu, 2011-05-19 at 18:24 +0800, fyang@redhat.com wrote:
> From: Feng Yang <fyang@redhat.com>
>
> Current working folder for
> unattended_install_config = UnattendedInstallConfig(test, params)
> unattended_install_config.setup()
> must be kvm folder.
This is not needed at all. What might be going on your setup is some
incorrectly set or absent path that might be messing up with relative
paths during your install.
Please provide some more info so we can fix your problem properly.
Meanwhile I'm marking this as 'rejected'.
Thanks!
> Signed-off-by: Feng Yang <fyang@redhat.com>
> ---
> client/tests/kvm/tests/unattended_install.py | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py
> index 50a8c7a..eee1761 100644
> --- a/client/tests/kvm/tests/unattended_install.py
> +++ b/client/tests/kvm/tests/unattended_install.py
> @@ -506,8 +506,11 @@ def run_unattended_install(test, params, env):
> @param params: Dictionary with the test parameters.
> @param env: Dictionary with test environment.
> """
> + cur_folder = os.getcwd()
> + os.chdir(test.bindir)
> unattended_install_config = UnattendedInstallConfig(test, params)
> unattended_install_config.setup()
> + os.chdir(cur_folder)
> vm = env.get_vm(params["main_vm"])
> vm.create()
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM Test: Switch current working folder in unattended_install.py.
2011-05-20 18:59 ` [Autotest] " Lucas Meneghel Rodrigues
@ 2011-05-23 2:25 ` Feng Yang
0 siblings, 0 replies; 3+ messages in thread
From: Feng Yang @ 2011-05-23 2:25 UTC (permalink / raw)
To: Lucas Meneghel Rodrigues; +Cc: autotest, kvm
On 05/21/2011 02:59 AM, Lucas Meneghel Rodrigues wrote:
> On Thu, 2011-05-19 at 18:24 +0800, fyang@redhat.com wrote:
>> From: Feng Yang<fyang@redhat.com>
>>
>> Current working folder for
>> unattended_install_config = UnattendedInstallConfig(test, params)
>> unattended_install_config.setup()
>> must be kvm folder.
> This is not needed at all. What might be going on your setup is some
> incorrectly set or absent path that might be messing up with relative
> paths during your install.
>
> Please provide some more info so we can fix your problem properly.
> Meanwhile I'm marking this as 'rejected'.
>
> Thanks!
Thanks for your comment.
After merge upstream code to our local tree, I found that our local
unattended_install could not work.
Before, Current working folder for unattended.py is kvm folder,
changed in process_command.
Now Current working folder for
unattended_install_config = UnattendedInstallConfig(test, params)
unattended_install_config.setup()
changed to case result folder. So our unattended_install always fails at
could not find ks.iso.
Then I send this patch.
I will recheck our local code and configure.
Thanks very much!
Feng Yang
>> Signed-off-by: Feng Yang<fyang@redhat.com>
>> ---
>> client/tests/kvm/tests/unattended_install.py | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py
>> index 50a8c7a..eee1761 100644
>> --- a/client/tests/kvm/tests/unattended_install.py
>> +++ b/client/tests/kvm/tests/unattended_install.py
>> @@ -506,8 +506,11 @@ def run_unattended_install(test, params, env):
>> @param params: Dictionary with the test parameters.
>> @param env: Dictionary with test environment.
>> """
>> + cur_folder = os.getcwd()
>> + os.chdir(test.bindir)
>> unattended_install_config = UnattendedInstallConfig(test, params)
>> unattended_install_config.setup()
>> + os.chdir(cur_folder)
>> vm = env.get_vm(params["main_vm"])
>> vm.create()
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-23 2:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 10:24 [PATCH] KVM Test: Switch current working folder in unattended_install.py fyang
2011-05-20 18:59 ` [Autotest] " Lucas Meneghel Rodrigues
2011-05-23 2:25 ` Feng Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.