* [PATCH] powerpc: Fix 32-bit SMP build
@ 2011-05-20 20:22 Josh Boyer
2011-05-20 21:58 ` [stable] " Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Josh Boyer @ 2011-05-20 20:22 UTC (permalink / raw)
To: benh, linuxppc-dev; +Cc: stable
Commit 69e3cea8d5fd526 introduced start_secondary_resume to misc_32.S,
however it uses a 64-bit instruction which is not valid on 32-bit
platforms. Use 'stw' instead.
Reported-by: Richard Cochran <richardcochran@gmail.com>
Tested-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
---
diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index 402560e..998a100 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -700,7 +700,7 @@ _GLOBAL(start_secondary_resume)
rlwinm r1,r1,0,0,(31-THREAD_SHIFT) /* current_thread_info() */
addi r1,r1,THREAD_SIZE-STACK_FRAME_OVERHEAD
li r3,0
- std r3,0(r1) /* Zero the stack frame pointer */
+ stw r3,0(r1) /* Zero the stack frame pointer */
bl start_secondary
b .
#endif /* CONFIG_SMP */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [stable] [PATCH] powerpc: Fix 32-bit SMP build
2011-05-20 20:22 [PATCH] powerpc: Fix 32-bit SMP build Josh Boyer
@ 2011-05-20 21:58 ` Greg KH
2011-05-20 22:24 ` Benjamin Herrenschmidt
2011-05-21 0:38 ` Josh Boyer
0 siblings, 2 replies; 4+ messages in thread
From: Greg KH @ 2011-05-20 21:58 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, stable
On Fri, May 20, 2011 at 04:22:25PM -0400, Josh Boyer wrote:
> Commit 69e3cea8d5fd526 introduced start_secondary_resume to misc_32.S,
> however it uses a 64-bit instruction which is not valid on 32-bit
> platforms. Use 'stw' instead.
>
> Reported-by: Richard Cochran <richardcochran@gmail.com>
> Tested-by: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>
> ---
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] [PATCH] powerpc: Fix 32-bit SMP build
2011-05-20 21:58 ` [stable] " Greg KH
@ 2011-05-20 22:24 ` Benjamin Herrenschmidt
2011-05-21 0:38 ` Josh Boyer
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2011-05-20 22:24 UTC (permalink / raw)
To: Greg KH; +Cc: linuxppc-dev, stable
On Fri, 2011-05-20 at 14:58 -0700, Greg KH wrote:
> On Fri, May 20, 2011 at 04:22:25PM -0400, Josh Boyer wrote:
> > Commit 69e3cea8d5fd526 introduced start_secondary_resume to misc_32.S,
> > however it uses a 64-bit instruction which is not valid on 32-bit
> > platforms. Use 'stw' instead.
> >
> > Reported-by: Richard Cochran <richardcochran@gmail.com>
> > Tested-by: Richard Cochran <richardcochran@gmail.com>
> > Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> >
> > ---
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>
The function is in a different place in 2.6.39 anyways. I'll do a proper
backport when Linus merges this one.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] [PATCH] powerpc: Fix 32-bit SMP build
2011-05-20 21:58 ` [stable] " Greg KH
2011-05-20 22:24 ` Benjamin Herrenschmidt
@ 2011-05-21 0:38 ` Josh Boyer
1 sibling, 0 replies; 4+ messages in thread
From: Josh Boyer @ 2011-05-21 0:38 UTC (permalink / raw)
To: Greg KH; +Cc: linuxppc-dev, stable
On Fri, May 20, 2011 at 5:58 PM, Greg KH <greg@kroah.com> wrote:
> On Fri, May 20, 2011 at 04:22:25PM -0400, Josh Boyer wrote:
>> Commit 69e3cea8d5fd526 introduced start_secondary_resume to misc_32.S,
>> however it uses a 64-bit instruction which is not valid on 32-bit
>> platforms. =A0Use 'stw' instead.
>>
>> Reported-by: Richard Cochran <richardcochran@gmail.com>
>> Tested-by: Richard Cochran <richardcochran@gmail.com>
>> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>>
>> ---
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. =A0Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>
Sigh. I know that. My fault for rushing it and not thinking.
josh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-21 0:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-20 20:22 [PATCH] powerpc: Fix 32-bit SMP build Josh Boyer
2011-05-20 21:58 ` [stable] " Greg KH
2011-05-20 22:24 ` Benjamin Herrenschmidt
2011-05-21 0:38 ` Josh Boyer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.