* [PATCH] jbd: Fix comment to match the code in journal_start()
@ 2011-05-23 16:17 Eryu Guan
2011-05-23 22:28 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Eryu Guan @ 2011-05-23 16:17 UTC (permalink / raw)
To: linux-ext4; +Cc: Eryu Guan, Jan Kara
journal_start returns an ERR_PTR() value rather than NULL on failure.
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
---
fs/jbd/transaction.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 60d2319..f7ee81a 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -266,7 +266,8 @@ static handle_t *new_handle(int nblocks)
* This function is visible to journal users (like ext3fs), so is not
* called with the journal already locked.
*
- * Return a pointer to a newly allocated handle, or NULL on failure
+ * Return a pointer to a newly allocated handle, or an ERR_PTR() value
+ * on failure.
*/
handle_t *journal_start(journal_t *journal, int nblocks)
{
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] jbd: Fix comment to match the code in journal_start()
2011-05-23 16:17 [PATCH] jbd: Fix comment to match the code in journal_start() Eryu Guan
@ 2011-05-23 22:28 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2011-05-23 22:28 UTC (permalink / raw)
To: Eryu Guan; +Cc: linux-ext4, Jan Kara
On Tue 24-05-11 00:17:34, Eryu Guan wrote:
> journal_start returns an ERR_PTR() value rather than NULL on failure.
>
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Tnanks. Merged.
Honza
> ---
> fs/jbd/transaction.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 60d2319..f7ee81a 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -266,7 +266,8 @@ static handle_t *new_handle(int nblocks)
> * This function is visible to journal users (like ext3fs), so is not
> * called with the journal already locked.
> *
> - * Return a pointer to a newly allocated handle, or NULL on failure
> + * Return a pointer to a newly allocated handle, or an ERR_PTR() value
> + * on failure.
> */
> handle_t *journal_start(journal_t *journal, int nblocks)
> {
> --
> 1.7.3.4
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-23 22:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-23 16:17 [PATCH] jbd: Fix comment to match the code in journal_start() Eryu Guan
2011-05-23 22:28 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.