All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] wireless: Default to 'n' for 2 new added devices in Kconfig.
@ 2011-05-24 15:11 Tao Ma
  2011-05-24 15:19 ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Tao Ma @ 2011-05-24 15:11 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-wireless, John W. Linville

From: Tao Ma <boyu.mt@taobao.com>

We make oldconfig every time when a new kernel arrives, but
if we don't have such a device(I guess this is the most common
case for a new device), the default value should be 'n' so
that the kernel size we build doesn't grow up too much quickly.
For anyone who has the device, it is OK for them to turn it on
by themselves.

Cc: "John W. Linville" <linville@tuxdriver.com>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 drivers/net/wireless/ath/ath9k/Kconfig |    1 +
 drivers/net/wireless/rt2x00/Kconfig    |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index d9ff841..2548f47 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -25,6 +25,7 @@ config ATH9K
 
 config ATH9K_PCI
 	bool "Atheros ath9k PCI/PCIe bus support"
+	default n
 	depends on ATH9K && PCI
 	default PCI
 	---help---
diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
index 9def1e5..677abc9 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -166,7 +166,7 @@ config RT2800USB_RT35XX
 config RT2800USB_RT53XX
        bool "rt2800usb - Include support for rt53xx devices (EXPERIMENTAL)"
        depends on EXPERIMENTAL
-       default y
+       default n
        ---help---
          This adds support for rt53xx wireless chipset family to the
          rt2800pci driver.
-- 
1.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] wireless: Default to 'n' for 2 new added devices in Kconfig.
  2011-05-24 15:11 [PATCH] wireless: Default to 'n' for 2 new added devices in Kconfig Tao Ma
@ 2011-05-24 15:19 ` Johannes Berg
  2011-05-25  1:44   ` [PATCH v2] " Tao Ma
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2011-05-24 15:19 UTC (permalink / raw)
  To: Tao Ma; +Cc: linux-kernel, linux-wireless, John W. Linville

On Tue, 2011-05-24 at 23:11 +0800, Tao Ma wrote:

>  config ATH9K_PCI
>  	bool "Atheros ath9k PCI/PCIe bus support"
> +	default n
>  	depends on ATH9K && PCI
>  	default PCI

should just remove the "default PCI" instead, "default n" is the default
if no default is given.

>  config RT2800USB_RT53XX
>         bool "rt2800usb - Include support for rt53xx devices (EXPERIMENTAL)"
>         depends on EXPERIMENTAL
> -       default y
> +       default n

ditto just remove "default y"

johannes


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] wireless: Default to 'n' for 2 new added devices in Kconfig.
  2011-05-24 15:19 ` Johannes Berg
@ 2011-05-25  1:44   ` Tao Ma
  0 siblings, 0 replies; 3+ messages in thread
From: Tao Ma @ 2011-05-25  1:44 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-wireless, John W. Linville, Johannes Berg

From: Tao Ma <boyu.mt@taobao.com>

We make oldconfig every time when a new kernel arrives, but
if we don't have such a device(I guess this is the most common
case for a new device), the default value should be 'n' so
that the kernel size we build doesn't grow up too much quickly.
For anyone who has the device, it is OK for them to turn it on
by themselves.

Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 drivers/net/wireless/ath/ath9k/Kconfig |    1 -
 drivers/net/wireless/rt2x00/Kconfig    |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index d9ff841..d9c08c6 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -26,7 +26,6 @@ config ATH9K
 config ATH9K_PCI
 	bool "Atheros ath9k PCI/PCIe bus support"
 	depends on ATH9K && PCI
-	default PCI
 	---help---
 	  This option enables the PCI bus support in ath9k.
 
diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
index 9def1e5..b2f8b8f 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -166,7 +166,6 @@ config RT2800USB_RT35XX
 config RT2800USB_RT53XX
        bool "rt2800usb - Include support for rt53xx devices (EXPERIMENTAL)"
        depends on EXPERIMENTAL
-       default y
        ---help---
          This adds support for rt53xx wireless chipset family to the
          rt2800pci driver.
-- 
1.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-05-25  1:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-24 15:11 [PATCH] wireless: Default to 'n' for 2 new added devices in Kconfig Tao Ma
2011-05-24 15:19 ` Johannes Berg
2011-05-25  1:44   ` [PATCH v2] " Tao Ma

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.