* [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs attributes
@ 2011-05-24 19:48 Guenter Roeck
2011-06-11 9:36 ` [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs Jean Delvare
2011-06-11 16:05 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2011-05-24 19:48 UTC (permalink / raw)
To: lm-sensors
Initialize dynamically allocated sysfs attributes before device_create_file()
call to suppress lockdep_init_map() warning if lockdep debugging is enabled.
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---
Compile tested only.
drivers/hwmon/ibmaem.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
index bc6e2ab..affc17e 100644
--- a/drivers/hwmon/ibmaem.c
+++ b/drivers/hwmon/ibmaem.c
@@ -947,6 +947,7 @@ static int aem_register_sensors(struct aem_data *data,
/* Set up read-only sensors */
while (ro->label) {
+ sysfs_attr_init(&sensors->dev_attr.attr);
sensors->dev_attr.attr.name = ro->label;
sensors->dev_attr.attr.mode = S_IRUGO;
sensors->dev_attr.show = ro->show;
@@ -963,6 +964,7 @@ static int aem_register_sensors(struct aem_data *data,
/* Set up read-write sensors */
while (rw->label) {
+ sysfs_attr_init(&sensors->dev_attr.attr);
sensors->dev_attr.attr.name = rw->label;
sensors->dev_attr.attr.mode = S_IRUGO | S_IWUSR;
sensors->dev_attr.show = rw->show;
--
1.7.3.1
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs
2011-05-24 19:48 [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs attributes Guenter Roeck
@ 2011-06-11 9:36 ` Jean Delvare
2011-06-11 16:05 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2011-06-11 9:36 UTC (permalink / raw)
To: lm-sensors
On Tue, 24 May 2011 13:10:12 -0700, Guenter Roeck wrote:
> Initialize dynamically allocated sysfs attributes before device_create_file()
> call to suppress lockdep_init_map() warning if lockdep debugging is enabled.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Compile tested only.
Can't test either, but looks good to me:
Acked-by: Jean Delvare <khali@linux-fr.org>
Candidate for stable series?
>
> drivers/hwmon/ibmaem.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
> index bc6e2ab..affc17e 100644
> --- a/drivers/hwmon/ibmaem.c
> +++ b/drivers/hwmon/ibmaem.c
> @@ -947,6 +947,7 @@ static int aem_register_sensors(struct aem_data *data,
>
> /* Set up read-only sensors */
> while (ro->label) {
> + sysfs_attr_init(&sensors->dev_attr.attr);
> sensors->dev_attr.attr.name = ro->label;
> sensors->dev_attr.attr.mode = S_IRUGO;
> sensors->dev_attr.show = ro->show;
> @@ -963,6 +964,7 @@ static int aem_register_sensors(struct aem_data *data,
>
> /* Set up read-write sensors */
> while (rw->label) {
> + sysfs_attr_init(&sensors->dev_attr.attr);
> sensors->dev_attr.attr.name = rw->label;
> sensors->dev_attr.attr.mode = S_IRUGO | S_IWUSR;
> sensors->dev_attr.show = rw->show;
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs
2011-05-24 19:48 [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs attributes Guenter Roeck
2011-06-11 9:36 ` [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs Jean Delvare
@ 2011-06-11 16:05 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2011-06-11 16:05 UTC (permalink / raw)
To: lm-sensors
On Sat, Jun 11, 2011 at 05:36:07AM -0400, Jean Delvare wrote:
> On Tue, 24 May 2011 13:10:12 -0700, Guenter Roeck wrote:
> > Initialize dynamically allocated sysfs attributes before device_create_file()
> > call to suppress lockdep_init_map() warning if lockdep debugging is enabled.
> >
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > ---
> > Compile tested only.
>
> Can't test either, but looks good to me:
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
Applied.
> Candidate for stable series?
>
Yes, I added the necessary Cc:
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-11 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-24 19:48 [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs attributes Guenter Roeck
2011-06-11 9:36 ` [lm-sensors] [PATCH 3/5] hwmon: (ibmaem) Initialize sysfs Jean Delvare
2011-06-11 16:05 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.