All of lore.kernel.org
 help / color / mirror / Atom feed
* build errors on kinect and rc-main - 2.6.38
@ 2011-05-25  6:43 Nicolas WILL
  2011-05-25  7:01 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Nicolas WILL
  2011-05-25 21:34 ` [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG Jarod Wilson
  0 siblings, 2 replies; 11+ messages in thread
From: Nicolas WILL @ 2011-05-25  6:43 UTC (permalink / raw)
  To: linux-media

Hello,

I'm trying to build the media tree using the automatic script and end-up
with at least two errors not allowing me to move forward positively.

Ubuntu 11.04 x86_64 2.6.38-8-generic

First one is on Kinect (don't need it, I can disable the build):

  CC [M]  /home/nico/src/media_build/v4l/kinect.o
/home/nico/src/media_build/v4l/kinect.c:38:19: error: 'D_ERR' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:38:27: error: 'D_PROBE' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:38:37: error: 'D_CONF' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:38:46: error: 'D_STREAM' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:38:57: error: 'D_FRAM' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:38:66: error: 'D_PACK' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:39:2: error: 'D_USBI' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:39:11: error: 'D_USBO' undeclared here (not in a function)
/home/nico/src/media_build/v4l/kinect.c:39:20: error: 'D_V4L2' undeclared here (not in a function)
make[3]: *** [/home/nico/src/media_build/v4l/kinect.o] Error 1
make[2]: *** [_module_/home/nico/src/media_build/v4l] Error 2


The second one is on rc-main (I probably need that!):

  CC [M]  /home/nico/src/media_build/v4l/rc-main.o
/home/nico/src/media_build/v4l/rc-main.c: In function 'rc_allocate_device':
/home/nico/src/media_build/v4l/rc-main.c:993:29: warning: assignment from incompatible pointer type
/home/nico/src/media_build/v4l/rc-main.c:994:29: warning: assignment from incompatible pointer type
  CC [M]  /home/nico/src/media_build/v4l/ir-raw.o
  CC [M]  /home/nico/src/media_build/v4l/mipi-csis.o
/home/nico/src/media_build/v4l/mipi-csis.c:29:28: fatal error: plat/mipi_csis.h: No such file or directory
compilation terminated.


Thanks for looking into it!

Nico


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main)
  2011-05-25  6:43 build errors on kinect and rc-main - 2.6.38 Nicolas WILL
@ 2011-05-25  7:01 ` Nicolas WILL
  2011-05-25  8:10   ` [PATCH] s5p-csis: Add missing dependency on PLAT_S5P Sylwester Nawrocki
                     ` (2 more replies)
  2011-05-25 21:34 ` [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG Jarod Wilson
  1 sibling, 3 replies; 11+ messages in thread
From: Nicolas WILL @ 2011-05-25  7:01 UTC (permalink / raw)
  To: linux-media

On Wed, 2011-05-25 at 07:43 +0100, Nicolas WILL wrote:
> The second one is on rc-main (I probably need that!):
> 
>   CC [M]  /home/nico/src/media_build/v4l/rc-main.o
> /home/nico/src/media_build/v4l/rc-main.c: In function 'rc_allocate_device':
> /home/nico/src/media_build/v4l/rc-main.c:993:29: warning: assignment from incompatible pointer type
> /home/nico/src/media_build/v4l/rc-main.c:994:29: warning: assignment from incompatible pointer type
>   CC [M]  /home/nico/src/media_build/v4l/ir-raw.o
>   CC [M]  /home/nico/src/media_build/v4l/mipi-csis.o
> /home/nico/src/media_build/v4l/mipi-csis.c:29:28: fatal error: plat/mipi_csis.h: No such file or directory
> compilation terminated.

Oh, not rc-main, but mipi-csis!

Sorry...

Nico


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] s5p-csis: Add missing dependency on PLAT_S5P
  2011-05-25  7:01 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Nicolas WILL
@ 2011-05-25  8:10   ` Sylwester Nawrocki
  2011-05-25  8:34   ` [PATCH v2] " Sylwester Nawrocki
  2011-05-25 21:41   ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Jarod Wilson
  2 siblings, 0 replies; 11+ messages in thread
From: Sylwester Nawrocki @ 2011-05-25  8:10 UTC (permalink / raw)
  To: linux-media; +Cc: Sylwester Nawrocki

s5p-csis is to be built only on S5P SoC platforms.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---

Hi Nicolas,

On x86 mipi-csis build should be disabled. This patch should the issue.

Regards,
Sylwester Nawrocki
Samsung Poland R&D Center

---
 drivers/media/video/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index cf5a1f6..bd739a6 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -954,7 +954,7 @@ config  VIDEO_SAMSUNG_S5P_FIMC
 
 config VIDEO_S5P_MIPI_CSIS
 	tristate "Samsung S5P and EXYNOS4 MIPI CSI receiver driver"
-	depends on VIDEO_V4L2 && PM_RUNTIME && VIDEO_V4L2_SUBDEV_API
+	depends on VIDEO_V4L2 && PM_RUNTIME && PLAT_S5P && VIDEO_V4L2_SUBDEV_API && PLAT_S5P
 	---help---
 	  This is a v4l2 driver for Samsung S5P/EXYNOS4 MIPI-CSI receiver.
 
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2] s5p-csis: Add missing dependency on PLAT_S5P
  2011-05-25  7:01 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Nicolas WILL
  2011-05-25  8:10   ` [PATCH] s5p-csis: Add missing dependency on PLAT_S5P Sylwester Nawrocki
@ 2011-05-25  8:34   ` Sylwester Nawrocki
  2011-05-25 21:41   ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Jarod Wilson
  2 siblings, 0 replies; 11+ messages in thread
From: Sylwester Nawrocki @ 2011-05-25  8:34 UTC (permalink / raw)
  To: linux-media; +Cc: nico, Sylwester Nawrocki

s5p-csis is to be built only on S5P SoC platforms.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Resending, as the previous patch had PLAT_S5P added twice..

---
 drivers/media/video/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index cf5a1f6..bb53de7 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -954,7 +954,7 @@ config  VIDEO_SAMSUNG_S5P_FIMC
 
 config VIDEO_S5P_MIPI_CSIS
 	tristate "Samsung S5P and EXYNOS4 MIPI CSI receiver driver"
-	depends on VIDEO_V4L2 && PM_RUNTIME && VIDEO_V4L2_SUBDEV_API
+	depends on VIDEO_V4L2 && PM_RUNTIME && PLAT_S5P && VIDEO_V4L2_SUBDEV_API
 	---help---
 	  This is a v4l2 driver for Samsung S5P/EXYNOS4 MIPI-CSI receiver.
 
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG
  2011-05-25  6:43 build errors on kinect and rc-main - 2.6.38 Nicolas WILL
  2011-05-25  7:01 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Nicolas WILL
@ 2011-05-25 21:34 ` Jarod Wilson
  2011-05-26  6:49   ` Jean-Francois Moine
  1 sibling, 1 reply; 11+ messages in thread
From: Jarod Wilson @ 2011-05-25 21:34 UTC (permalink / raw)
  To: linux-media; +Cc: Jarod Wilson

Fixes media_build, and presumably certain other upstream kernel build
option combos.

Before:
  CC [M]  /home/jarod/src/media_build/v4l/kinect.o
/home/jarod/src/media_build/v4l/kinect.c:38:19: error: 'D_ERR' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:38:27: error: 'D_PROBE' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:38:37: error: 'D_CONF' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:38:46: error: 'D_STREAM' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:38:57: error: 'D_FRAM' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:38:66: error: 'D_PACK' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:39:2: error: 'D_USBI' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:39:11: error: 'D_USBO' undeclared here (not in a function)
/home/jarod/src/media_build/v4l/kinect.c:39:20: error: 'D_V4L2' undeclared here (not in a function)
make[3]: *** [/home/jarod/src/media_build/v4l/kinect.o] Error 1

After:
  CC [M]  /home/jarod/src/media_build/v4l/kinect.o
  ...
  LD [M]  /home/jarod/src/media_build/v4l/gspca_kinect.ko
  ...
  profit

Reported-by: Nicolas Will <nico@youplala.net>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 drivers/media/video/gspca/kinect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
index 66671a4..26fc206 100644
--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>");
 MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
 MODULE_LICENSE("GPL");
 
-#ifdef DEBUG
+#ifdef GSPCA_DEBUG
 int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
 	D_USBI | D_USBO | D_V4L2;
 #endif
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main)
  2011-05-25  7:01 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Nicolas WILL
  2011-05-25  8:10   ` [PATCH] s5p-csis: Add missing dependency on PLAT_S5P Sylwester Nawrocki
  2011-05-25  8:34   ` [PATCH v2] " Sylwester Nawrocki
@ 2011-05-25 21:41   ` Jarod Wilson
  2011-05-25 22:02     ` Jarod Wilson
  2 siblings, 1 reply; 11+ messages in thread
From: Jarod Wilson @ 2011-05-25 21:41 UTC (permalink / raw)
  To: Nicolas WILL; +Cc: linux-media

On May 25, 2011, at 3:01 AM, Nicolas WILL wrote:

> On Wed, 2011-05-25 at 07:43 +0100, Nicolas WILL wrote:
>> The second one is on rc-main (I probably need that!):
>> 
>>  CC [M]  /home/nico/src/media_build/v4l/rc-main.o
>> /home/nico/src/media_build/v4l/rc-main.c: In function 'rc_allocate_device':
>> /home/nico/src/media_build/v4l/rc-main.c:993:29: warning: assignment from incompatible pointer type
>> /home/nico/src/media_build/v4l/rc-main.c:994:29: warning: assignment from incompatible pointer type
>>  CC [M]  /home/nico/src/media_build/v4l/ir-raw.o
>>  CC [M]  /home/nico/src/media_build/v4l/mipi-csis.o
>> /home/nico/src/media_build/v4l/mipi-csis.c:29:28: fatal error: plat/mipi_csis.h: No such file or directory
>> compilation terminated.
> 
> Oh, not rc-main, but mipi-csis!

True, but the rc-main warning is actually a valid issue that needs to
be fixed as well. I'll get the necessary backport patch into media_build
shortly, I hope...

-- 
Jarod Wilson
jarod@wilsonet.com




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main)
  2011-05-25 21:41   ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Jarod Wilson
@ 2011-05-25 22:02     ` Jarod Wilson
  2011-05-25 22:07       ` Nicolas WILL
  0 siblings, 1 reply; 11+ messages in thread
From: Jarod Wilson @ 2011-05-25 22:02 UTC (permalink / raw)
  To: Linux Media Mailing List

On May 25, 2011, at 5:41 PM, Jarod Wilson wrote:

> On May 25, 2011, at 3:01 AM, Nicolas WILL wrote:
> 
>> On Wed, 2011-05-25 at 07:43 +0100, Nicolas WILL wrote:
>>> The second one is on rc-main (I probably need that!):
>>> 
>>> CC [M]  /home/nico/src/media_build/v4l/rc-main.o
>>> /home/nico/src/media_build/v4l/rc-main.c: In function 'rc_allocate_device':
>>> /home/nico/src/media_build/v4l/rc-main.c:993:29: warning: assignment from incompatible pointer type
>>> /home/nico/src/media_build/v4l/rc-main.c:994:29: warning: assignment from incompatible pointer type
>>> CC [M]  /home/nico/src/media_build/v4l/ir-raw.o
>>> CC [M]  /home/nico/src/media_build/v4l/mipi-csis.o
>>> /home/nico/src/media_build/v4l/mipi-csis.c:29:28: fatal error: plat/mipi_csis.h: No such file or directory
>>> compilation terminated.
>> 
>> Oh, not rc-main, but mipi-csis!
> 
> True, but the rc-main warning is actually a valid issue that needs to
> be fixed as well. I'll get the necessary backport patch into media_build
> shortly, I hope...

Patches pushed.

-- 
Jarod Wilson
jarod@wilsonet.com




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main)
  2011-05-25 22:02     ` Jarod Wilson
@ 2011-05-25 22:07       ` Nicolas WILL
  0 siblings, 0 replies; 11+ messages in thread
From: Nicolas WILL @ 2011-05-25 22:07 UTC (permalink / raw)
  To: Linux Media Mailing List

On Wed, 2011-05-25 at 18:02 -0400, Jarod Wilson wrote:
> On May 25, 2011, at 5:41 PM, Jarod Wilson wrote:
> 
> > On May 25, 2011, at 3:01 AM, Nicolas WILL wrote:
> > 
> >> On Wed, 2011-05-25 at 07:43 +0100, Nicolas WILL wrote:
> >>> The second one is on rc-main (I probably need that!):
> >>> 
> >>> CC [M]  /home/nico/src/media_build/v4l/rc-main.o
> >>> /home/nico/src/media_build/v4l/rc-main.c: In function
> 'rc_allocate_device':
> >>> /home/nico/src/media_build/v4l/rc-main.c:993:29: warning:
> assignment from incompatible pointer type
> >>> /home/nico/src/media_build/v4l/rc-main.c:994:29: warning:
> assignment from incompatible pointer type
> >>> CC [M]  /home/nico/src/media_build/v4l/ir-raw.o
> >>> CC [M]  /home/nico/src/media_build/v4l/mipi-csis.o
> >>> /home/nico/src/media_build/v4l/mipi-csis.c:29:28: fatal error:
> plat/mipi_csis.h: No such file or directory
> >>> compilation terminated.
> >> 
> >> Oh, not rc-main, but mipi-csis!
> > 
> > True, but the rc-main warning is actually a valid issue that needs
> to
> > be fixed as well. I'll get the necessary backport patch into
> media_build
> > shortly, I hope...
> 
> Patches pushed. 

:o)

Thanks !

Nico


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG
  2011-05-25 21:34 ` [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG Jarod Wilson
@ 2011-05-26  6:49   ` Jean-Francois Moine
  2011-05-26  7:47     ` Antonio Ospite
  2011-05-26 13:48     ` Jarod Wilson
  0 siblings, 2 replies; 11+ messages in thread
From: Jean-Francois Moine @ 2011-05-26  6:49 UTC (permalink / raw)
  To: linux-media

On Wed, 25 May 2011 17:34:32 -0400
Jarod Wilson <jarod@redhat.com> wrote:

> diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
> index 66671a4..26fc206 100644
> --- a/drivers/media/video/gspca/kinect.c
> +++ b/drivers/media/video/gspca/kinect.c
> @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>");
>  MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
>  MODULE_LICENSE("GPL");
>  
> -#ifdef DEBUG
> +#ifdef GSPCA_DEBUG
>  int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
>  	D_USBI | D_USBO | D_V4L2;
>  #endif

Hi Jarod,

Sorry, it is not the right fix. In fact, the variable gspca_debug must
not be defined in gspca subdrivers:

--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -34,11 +34,6 @@
 MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
 MODULE_LICENSE("GPL");
 
-#ifdef DEBUG
-int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
-	D_USBI | D_USBO | D_V4L2;
-#endif
-
 struct pkt_hdr {
 	uint8_t magic[2];
 	uint8_t pad;

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG
  2011-05-26  6:49   ` Jean-Francois Moine
@ 2011-05-26  7:47     ` Antonio Ospite
  2011-05-26 13:48     ` Jarod Wilson
  1 sibling, 0 replies; 11+ messages in thread
From: Antonio Ospite @ 2011-05-26  7:47 UTC (permalink / raw)
  To: Jean-Francois Moine; +Cc: linux-media

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

On Thu, 26 May 2011 08:49:12 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> On Wed, 25 May 2011 17:34:32 -0400
> Jarod Wilson <jarod@redhat.com> wrote:
> 
> > diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
> > index 66671a4..26fc206 100644
> > --- a/drivers/media/video/gspca/kinect.c
> > +++ b/drivers/media/video/gspca/kinect.c
> > @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>");
> >  MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
> >  MODULE_LICENSE("GPL");
> >  
> > -#ifdef DEBUG
> > +#ifdef GSPCA_DEBUG
> >  int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
> >  	D_USBI | D_USBO | D_V4L2;
> >  #endif
> 
> Hi Jarod,
> 
> Sorry, it is not the right fix. In fact, the variable gspca_debug must
> not be defined in gspca subdrivers:
> 
> --- a/drivers/media/video/gspca/kinect.c
> +++ b/drivers/media/video/gspca/kinect.c
> @@ -34,11 +34,6 @@
>  MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
>  MODULE_LICENSE("GPL");
>  
> -#ifdef DEBUG
> -int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
> -	D_USBI | D_USBO | D_V4L2;
> -#endif
> -
>  struct pkt_hdr {
>  	uint8_t magic[2];
>  	uint8_t pad;
> 

OK.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG
  2011-05-26  6:49   ` Jean-Francois Moine
  2011-05-26  7:47     ` Antonio Ospite
@ 2011-05-26 13:48     ` Jarod Wilson
  1 sibling, 0 replies; 11+ messages in thread
From: Jarod Wilson @ 2011-05-26 13:48 UTC (permalink / raw)
  To: jean-francois Moine; +Cc: linux-media

On May 26, 2011, at 2:49 AM, jean-francois Moine wrote:

> On Wed, 25 May 2011 17:34:32 -0400
> Jarod Wilson <jarod@redhat.com> wrote:
> 
>> diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
>> index 66671a4..26fc206 100644
>> --- a/drivers/media/video/gspca/kinect.c
>> +++ b/drivers/media/video/gspca/kinect.c
>> @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>");
>> MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
>> MODULE_LICENSE("GPL");
>> 
>> -#ifdef DEBUG
>> +#ifdef GSPCA_DEBUG
>> int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
>> 	D_USBI | D_USBO | D_V4L2;
>> #endif
> 
> Hi Jarod,
> 
> Sorry, it is not the right fix. In fact, the variable gspca_debug must
> not be defined in gspca subdrivers:
> 
> --- a/drivers/media/video/gspca/kinect.c
> +++ b/drivers/media/video/gspca/kinect.c
> @@ -34,11 +34,6 @@
> MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
> MODULE_LICENSE("GPL");
> 
> -#ifdef DEBUG
> -int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
> -	D_USBI | D_USBO | D_V4L2;
> -#endif
> -
> struct pkt_hdr {
> 	uint8_t magic[2];
> 	uint8_t pad;

Ah, ok, that works just as well for me, since I don't have the hardware,
was just looking to make sure things still complied. ;)

-- 
Jarod Wilson
jarod@wilsonet.com




^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2011-05-26 13:48 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-25  6:43 build errors on kinect and rc-main - 2.6.38 Nicolas WILL
2011-05-25  7:01 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Nicolas WILL
2011-05-25  8:10   ` [PATCH] s5p-csis: Add missing dependency on PLAT_S5P Sylwester Nawrocki
2011-05-25  8:34   ` [PATCH v2] " Sylwester Nawrocki
2011-05-25 21:41   ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Jarod Wilson
2011-05-25 22:02     ` Jarod Wilson
2011-05-25 22:07       ` Nicolas WILL
2011-05-25 21:34 ` [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG Jarod Wilson
2011-05-26  6:49   ` Jean-Francois Moine
2011-05-26  7:47     ` Antonio Ospite
2011-05-26 13:48     ` Jarod Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.